From 7a263efaa2a689e2e539ce5df1527e217cdf82cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Thu, 31 Jul 2025 10:10:14 +0200 Subject: [PATCH] Always fetch leaderboard with score sort mode in solo results This is borderline pedantic and mostly irrelevant but I think it makes some sense for a bit of extra safety. It definitely does not fix any bugs (that I'm aware of). --- osu.Game/Screens/Ranking/SoloResultsScreen.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/osu.Game/Screens/Ranking/SoloResultsScreen.cs b/osu.Game/Screens/Ranking/SoloResultsScreen.cs index 2d772e5f09..aeb21b09cb 100644 --- a/osu.Game/Screens/Ranking/SoloResultsScreen.cs +++ b/osu.Game/Screens/Ranking/SoloResultsScreen.cs @@ -41,12 +41,12 @@ namespace osu.Game.Screens.Ranking { Debug.Assert(Score != null); + // sort mode intentionally omitted to default to score - results screen only supports sorting by score, so don't pass any other to avoid confusion var criteria = new LeaderboardCriteria( Score.BeatmapInfo!, Score.Ruleset, leaderboardManager.CurrentCriteria?.Scope ?? BeatmapLeaderboardScope.Global, - leaderboardManager.CurrentCriteria?.ExactMods, - leaderboardManager.CurrentCriteria?.Sorting ?? LeaderboardSortMode.Score + leaderboardManager.CurrentCriteria?.ExactMods ); var requestTaskSource = new TaskCompletionSource(); globalScores.BindValueChanged(_ =>