735 Commits

Author	SHA1	Message	Date
Dean Herbert	4c744ccb69	Fix "Use current" snap not working ... Regressed with https://github.com/ppy/osu/pull/27249. I was suspicious of this specific operation at the time but didn't test properly.	2024-02-26 14:11:54 +08:00
Andrei Zavatski	c758640311	Reduce allocations in ComposerDistanceSnapProvider	2024-02-19 20:49:56 +03:00
Berkan Diler	6adf0ac01e	Use new LINQ Order() instead of OrderBy() when possible	2024-02-08 18:01:00 +01:00
Bartłomiej Dach	b7d74fda88	Revert "Keep editor in frame stable mode when possible"	2024-01-14 09:10:39 +01:00
Dean Herbert	65c29b4f09	Make editor remain frame stable during normal playback	2024-01-04 15:47:16 +09:00
Bartłomiej Dach	288ac930e4	Use new icons in editor ... Some that exist on figma are purposefully not used due to an editorial request from @peppy.	2023-12-27 17:42:18 +01:00
Dan Balasescu	41ba1dcfce	Merge branch 'master' into editor/checks/delayed-hitsounds	2023-12-13 14:01:06 +09:00
Bartłomiej Dach	b6215b2809	Rename and document SelectFromTimestamp	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	0e0ab66148	Simplify parsing code ... Less methods, less smeared around logic, saner data types.	2023-11-20 21:57:12 +09:00
ratinfx	fab6fc9adb	Updated comments, renamed method	2023-11-12 15:09:15 +01:00
ratinfx	c367697559	Changed TIME_REGEX to accept everything in the parentheses ... - changed osu-web link to the current value	2023-11-11 16:14:26 +01:00
ratinfx	4e1e19728c	Refactor HitObject selection in Composer	2023-11-11 14:02:42 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
Dean Herbert	a91b704d21	Fix some new nullable inspections	2023-10-30 15:10:10 +09:00
Bartłomiej Dach	79910df959	Fix catch distance snap provider not hiding slider properly ... Regressed in https://github.com/ppy/osu/pull/25171. The old code was kinda dependent on correct order of setting `Disabled`. `CatchHitObjectComposer` would disable distance spacing in its BDL, and then via the base `DistancedHitObjectComposer.LoadComplete()`, the slider would be faded out. The switch to composition broke that ordering. To fix, stop relying on ordering and just respond to changes as they come. That's what bindables are for.	2023-10-26 15:46:32 +02:00
Bartłomiej Dach	2c6bf9e346	Remove unused using directive	2023-10-19 20:45:47 +02:00
Dean Herbert	013b5fa916	Move beat snap grid implementation details to ScrollingHitObjectComposer	2023-10-19 23:54:34 +09:00
Dean Herbert	52c2eb93de	Merge branch 'master' into taiko-beat-snap-grid	2023-10-19 23:53:01 +09:00
Bartłomiej Dach	144ef5a87c	Remove DistancedHitObjectComposer	2023-10-19 11:46:30 +02:00
Bartłomiej Dach	dcfd6a0a8a	Remove DistancedHitObjectComposer inheritance from osu! composer	2023-10-19 11:46:30 +02:00
Bartłomiej Dach	3ab083b696	Split IPositionSnapProvider from IDistanceSnapProvider ... In preparation to remove `DistancedHitObjectComposer`, split off `IPositionSnapProvider` from `IDistanceSnapProvider`. `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s only interface member at all, it was just forwarding it for subclasses to override to their own leisure.	2023-10-19 11:45:24 +02:00
Bartłomiej Dach	7abd7fe658	Remove redundant explicit array type specification	2023-10-17 10:26:02 +02:00
Dean Herbert	4381169a3f	Combine selection and input handling logic for beat snap grids across all rulesets	2023-10-17 17:09:42 +09:00
Dean Herbert	d26d4b8b79	Cache IScrollingInfo at a HitObjectComposer level automatically	2023-10-17 16:42:22 +09:00
Dean Herbert	165cd07428	Persist the state of "show speed changes" between editor sessions ... Addresses https://github.com/ppy/osu/discussions/25149.	2023-10-17 16:01:02 +09:00
Dean Herbert	41a8239e49	Remvoe null default for mods which can't be null	2023-09-20 15:27:50 +09:00
Dean Herbert	c6cc858967	Change implementation of "show speed changes" to require explicit ruleset support	2023-09-20 15:27:30 +09:00
Dean Herbert	c5397bdbb3	Merge branch 'master' into mania-edit-disable-sv	2023-09-20 14:23:07 +09:00
Dean Herbert	12611a09f1	Merge branch 'master' into editor/checks/delayed-hitsounds	2023-09-20 14:18:41 +09:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
tsrk	a4e146ad9b	style: remove usage of HIT_FLOURISH ... Unaware clueless usage	2023-09-01 21:02:43 +02:00
tsrk	2e2dcd99a6	fix(AudioCheckUtils): use Path.GetExtension() ... To avoid filename escaping	2023-09-01 20:56:54 +02:00
tsrk	5f00d3e2a4	style: convert to using declaration for less nesting	2023-09-01 20:54:02 +02:00
Dean Herbert	37c2b330a2	Move toggle implementation to work on all scrolling rulesets automatically	2023-09-01 19:53:10 +09:00
tsrk	5ecd5142d8	fix(AudioCheckUtils): add license header	2023-08-29 23:27:15 +02:00
tsrk	b3d432b0d5	fix: issue template typo in CheckDelayedHitsounds	2023-08-29 20:15:33 +02:00
tsrk	c1a7ad09b4	style: move common audio utils to separate static class	2023-08-29 20:10:35 +02:00
tsrk	a7a64b57e9	fix: use using statement for waveform auto-disposal	2023-08-29 19:46:19 +02:00
tsrk	a04333c17b	style: use HitSampleInfo.All properties	2023-08-29 19:42:37 +02:00
tsrk	29a46f5b36	style(editor/checks): add issues for delays with no silence	2023-08-25 11:46:09 +02:00
tsrk	4c32e9a479	style: use more rigorous hitsound filtering	2023-08-25 00:37:45 +02:00
tsrk	50dbf564a5	revert: use old wording ... This makes more sense wrt to the complete silence thing. Refs: f7599c5b	2023-08-24 23:52:41 +02:00
tsrk	f7599c5bc4	style: reword	2023-08-24 23:41:56 +02:00
tsrk	273593a0ee	style: typo	2023-08-24 23:25:42 +02:00
tsrk	208e94e9be	style(editor/checks): add type nullability for Stream	2023-08-24 21:33:54 +02:00
tsrk	df55a2f683	style(editor/checks): fix inconsistent argument names	2023-08-24 21:31:28 +02:00
tsrk	a885bf6ebf	feat(editor/checks): check for delayed hitsounds ... I really just borrowed the implementation from MapsetVerifier	2023-08-24 21:05:40 +02:00
Bartłomiej Dach	caad931a16	Move comment to more fitting place	2023-07-28 22:10:10 +02:00
Bartłomiej Dach	6d018c08af	Rename Apply{Vertical -> Horizontal}Centering to match common understanding	2023-07-28 22:09:28 +02:00
Dean Herbert	c9155f85ab	Fix playfield not taking up full width correclty when not vertically centered	2023-07-28 16:40:14 +09:00