63525 Commits

This Branch

This Branch

All Branches

• Merge pull request #25023 from bdach/skinning-max-size-update

  Adjust gameplay element maximum size limits for backwards compatibility

  Dean Herbert · 2023-10-06 14:37:15 +09:00
  cc6210035f
• Apply feedback regarding maximum osu! element sizings

  - `default-N` number sprites maximum size increased by 1.25x to a total
    of 320x320 to counteract the 0.8x factor applied onto them when
    displayed on a hitcircle.
  
  - `sliderb` and parts' maximum size increased to 384x384, to match
    `sliderfollowcircle`, as the two are apparently sometimes used
    interchangeably by skinners to achieve different visual effects.

  Bartłomiej Dach · 2023-10-05 22:33:49 +02:00
  96bb8ed150
• Adjust gameplay element maximum size limits for backwards compatibility

  The new limits were chosen by sampling across over 4000 skins. The
  methodology for doing so is described in the following gist:
  
  	https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3

  Bartłomiej Dach · 2023-10-05 20:37:10 +02:00
  0ae4a0f11f
• Merge pull request #25016 from peppy/fix-waveform-comparison-crash

  Fix `WaveformComparisonDisplay` potentially crashing on invalid track length

  Bartłomiej Dach · 2023-10-05 20:02:44 +02:00
  4d315cb718
• Merge pull request #25013 from smoogipoo/new-diffcalc-workflow

  Add new GitHub Actions diffcalc spreadsheet generator workflow

  Dean Herbert · 2023-10-05 23:57:20 +09:00
  9649cc865d
• Merge pull request #25010 from bdach/swell-cheesing

  Allow judging at most one swell tick per frame

  Dean Herbert · 2023-10-05 23:50:38 +09:00
  d034a3c45d
• Merge branch 'master' into swell-cheesing
  Dean Herbert · 2023-10-05 23:08:21 +09:00
  c66423279c
• Ensure there's no chance of a press being ignored during rewind flow
  Dean Herbert · 2023-10-05 23:02:45 +09:00
  d660395850
• Ensure regenerateDisplay is eventually performed if originally called before load
  Dean Herbert · 2023-10-05 22:55:23 +09:00
  61fd4186af
• Merge pull request #24975 from frenzibyte/crop-gameplay-textures

  Crop oversized gameplay textures instead of downscaling them

  Bartłomiej Dach · 2023-10-05 10:41:40 +02:00
  b0176dcbf7
• Merge branch 'master' into crop-gameplay-textures
  Bartłomiej Dach · 2023-10-05 09:35:58 +02:00
  c195fbe76f
• Merge pull request #25015 from peppy/fix-intermittent-test-failure

  Fix `TestReplayExport` intermittent failure

  Bartłomiej Dach · 2023-10-05 08:17:42 +02:00
  0f7093cb22
• Fix WaveformComparisonDisplay potentially crashing on invalid track length

  As seen at https://github.com/ppy/osu/runs/17415814918#r0s2.

  Dean Herbert · 2023-10-05 14:58:55 +09:00
  76cc2f9f22
• Fix TestReplayExport intermittent failure

  The previous fix was not working as it was checking the path for the
  prefix `_`, not the filename.
  
  See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows
  this.

  Dean Herbert · 2023-10-05 14:30:06 +09:00
  5a0faaa0b1
• Remove duplicated usage instructions
  Dan Balasescu · 2023-10-05 14:09:58 +09:00
  2e0ca45773
• Add description
  Dan Balasescu · 2023-10-05 13:32:20 +09:00
  bca257eeda
• Fix double interpolation being applied when applyOffsets=false
  Dean Herbert · 2023-10-05 13:20:52 +09:00
  f8455af0d0
• Add new difficulty calculation github action
  Dan Balasescu · 2023-10-05 13:20:07 +09:00
  9f350ce13c
• Allow judging at most one swell tick per frame
  Bartłomiej Dach · 2023-10-04 19:08:03 +02:00
  a1368df62f
• Add failing test covering counting multiple swell hits per frame
  Bartłomiej Dach · 2023-10-04 19:08:02 +02:00
  2ae1a24355
• Update framework
  Dean Herbert · 2023-10-04 23:55:38 +09:00
  20342d430d
• Merge branch 'master' into health-animates-in-intro
  Bartłomiej Dach · 2023-10-04 13:53:42 +02:00
  bd71403309
• Merge pull request #25006 from smoogipoo/fix-spinner-precision

  Fix spinner requirements being susceptible to FP precision

  Bartłomiej Dach · 2023-10-04 10:03:49 +02:00
  66824ce8ca
• Update framework
  Dean Herbert · 2023-10-04 16:57:54 +09:00
  a186d97edf
• Merge branch 'master' into clock-fix-attempt-2
  Dean Herbert · 2023-10-04 16:57:49 +09:00
  5a17a86d1d
• Fix regression in Tracking state handling

  It turns out multiple components depend on `Tracking` eventually
  becoming `false` at the end of a slider. With my previous changes, this
  was no longer the case (as could be seen by the legacy cursor particles
  test failure, and heard by slider slide taking too long to stop).

  Dean Herbert · 2023-10-04 16:11:40 +09:00
  658b6a166f
• Rename OnlinePlayScreen.LoungeSubScreen to Lounge
  Marvin Schürz · 2023-10-04 08:37:22 +02:00
  6d97f89399
• Make resolved multiplayerClient field nullable
  Marvin Schürz · 2023-10-04 08:35:45 +02:00
  6bd51b32b4
• Fix formatting
  Marvin Schürz · 2023-10-04 08:32:18 +02:00
  0726ccb988
• Rename loadRoom to lookupRoom
  Marvin Schürz · 2023-10-04 08:31:50 +02:00
  74ed3bc4ff
• Fix formatting
  Marvin Schürz · 2023-10-04 08:30:48 +02:00
  bfeafd6f70
• Add test coverage of very fast slider
  Dean Herbert · 2023-10-04 14:58:05 +09:00
  d14d885d19
• Fix spinner requirements being susceptible to FP precision
  Dan Balasescu · 2023-10-04 13:53:33 +09:00
  48209872bf
• Add better commenting around legacy last tick edge case
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  cfb18e18c0
• Add note about early return in DrawableSliderBall.Update
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  9361b1879c
• Merge branch 'master' into legacy-tick-test-coverage
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  425fc9d61f
• Fix difficulty calculation not correct handling slider leniency anymore
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  8d91991214
• Merge pull request #24965 from peppy/legacy-tick-not-so-legacy-after-all

  Tidy up `LegacyLastTickOffset` usages and stop passing everywhere

  Dean Herbert · 2023-10-04 11:42:32 +09:00
  2023.1004.0 72cbc3b9cf
• Merge branch 'master' into legacy-tick-not-so-legacy-after-all
  Dan Balasescu · 2023-10-04 10:52:13 +09:00
  854b797ab5
• Remove unused import
  Marvin Schürz · 2023-10-04 00:50:48 +02:00
  fe5177fa4f
• Add missing parameter description to docs.
  Marvin Schürz · 2023-10-04 00:28:01 +02:00
  5469d134cb
• Reduce silliness of notification test case
  Marvin Schürz · 2023-10-04 00:20:38 +02:00
  5678d90461
• Make UserAvatarNotification.user readonly
  Marvin Schürz · 2023-10-04 00:20:07 +02:00
  32f69cd0ba
• Handle cases when player cannot be invited.
  Marvin Schürz · 2023-10-03 22:08:14 +02:00
  267d1ee7d4
• Merge branch 'master' into fix-legacy-score-multipliers-2
  Dan Balasescu · 2023-10-04 01:19:33 +09:00
  a120ea8464
• Merge branch 'master' into legacy-tick-test-coverage
  Dean Herbert · 2023-10-03 19:37:32 +09:00
  69ae370e82
• Fix one case of difficulty calculation no longer accounting for leniency
  Dean Herbert · 2023-10-03 19:37:13 +09:00
  c4992d3479
• Rename weird diffcalc parameter name
  Dean Herbert · 2023-10-03 19:20:39 +09:00
  70ec4b060a
• Fix potential out-of-order tail and ticks
  Dean Herbert · 2023-10-03 18:52:20 +09:00
  9e1fec0213
• Add extra test coverage to TestSceneOsuModAutoplay to cover fail case

  Basically the slider needs to be slightly longer for this test to
  correctly fail in headless tests, in conjunction with the new slider
  tail leniency.
  
  This is due to headless tests running at a fixed frame interval, and
  these timings being *tight*.

  Dean Herbert · 2023-10-03 18:52:20 +09:00
  941f26d462