811 Commits

Author	SHA1	Message	Date
Dean Herbert	0557b9ab79	Allow placement deletion with middle mouse ... This is in addition to Shift + Right-click. I thik middle mouse feels more natural and is a good permanent solution to this issue. Note that this also *allows triggering the context menu from placement mode*. Until now it's done nothing. This may be annoying to users with muscle memory but I want to make the change and harvest feedback. I think showing the context menu is more correct behaviour (although arguably it should return to placement mode on dismiss?).	2024-08-05 14:25:09 +09:00
Shreyas Kadambi	dec6b190f2	Add optional 'suffix' to timestamp	2024-07-28 11:31:36 -04:00
Bartłomiej Dach	57fa502786	Fix editor UI dimming when hovering over expanded part of toolboxes ... Closes https://github.com/ppy/osu/issues/28969.	2024-07-22 11:57:46 +02:00
Dean Herbert	6cdcd6136d	Fix editor toolboxes being incorrectly chopped	2024-07-15 21:02:54 +09:00
Dean Herbert	fe421edd8f	Fix editor UI transparency being incorrectly opaque when hovering slider control points ... As mentioned at https://github.com/ppy/osu/pull/28787#issuecomment-2221150025.	2024-07-11 16:41:21 +09:00
Dean Herbert	aadcc5384d	Adjust editor transparent tweens to be less "flashy" ... Touched on in https://github.com/ppy/osu/discussions/28581. After a bit more usage of the editor I do agree with this and think that making the fades a bit more gentle helps a lot.	2024-07-09 16:16:19 +09:00
Bartłomiej Dach	6907d3d3b5	Merge branch 'master' into nodesample-inherit	2024-07-05 08:12:47 +02:00
Bartłomiej Dach	c524c23db6	Merge branch 'master' into inherit-addition	2024-07-04 15:24:59 +02:00
Bartłomiej Dach	ea9dd841c0	Merge pull request #28728 from OliBomby/inherit-volume ... Always inherit the volume from the previous hit object on placement	2024-07-04 15:24:34 +02:00
Bartłomiej Dach	652d2e9633	Adjust code style	2024-07-04 15:19:36 +02:00
Bartłomiej Dach	8b4155fc0a	Merge branch 'inherit-addition' into nodesample-inherit	2024-07-04 15:13:20 +02:00
Bartłomiej Dach	faedf268ec	Merge branch 'inherit-volume' into inherit-addition	2024-07-04 14:52:05 +02:00
Bartłomiej Dach	72492a79cd	Reduce duplication in new logic	2024-07-04 14:45:46 +02:00
Dean Herbert	3f138489a1	Merge pull request #28509 from bdach/slider-anchor-type-switching ... Add ability to cycle slider control point types via keyboard	2024-07-04 16:11:37 +09:00
Salman Ahmed	899c8d39fe	Merge branch 'master' into verify-title-markers	2024-07-04 07:07:59 +03:00
OliBomby	e754668daa	Always inherit the volume from the previous hit object	2024-07-04 01:09:06 +02:00
OliBomby	8f3a30b0b9	inherit addition bank from last hitobject	2024-07-04 00:56:53 +02:00
OliBomby	8dd04b6e9a	update nodesamples on placement	2024-07-04 00:39:12 +02:00
Bartłomiej Dach	00a0058fc7	Fix typo	2024-07-03 16:13:47 +02:00
Bartłomiej Dach	bcb479d4f7	Use one less regex	2024-07-03 16:13:30 +02:00
Bartłomiej Dach	5696e85b68	Adjust conditionals ... The fact that checking the unicode title was gated behind a `hasRomanisedTitle` guard was breaking my brain.	2024-07-03 15:52:05 +02:00
Bartłomiej Dach	32b3d3d7df	Compile regexes for speed	2024-07-03 15:49:21 +02:00
Bartłomiej Dach	901fec65ef	Address code quality issues	2024-07-03 15:49:17 +02:00
Dean Herbert	88375694a3	Merge branch 'master' into slider-anchor-type-switching	2024-07-03 22:36:57 +09:00
Dean Herbert	5f56ed6872	Merge branch 'master' into navigate-to-timestamp	2024-07-03 20:42:32 +09:00
Arthur Araujo	7143ff523f	Make MarkerChecks and MarkerCheck class private	2024-07-02 21:09:49 -03:00
Arthur Araujo	7cdad20119	Fix explicit array type specification in MarkerChecks	2024-07-02 20:55:52 -03:00
Arthur Araujo	7cb3d7445c	Add verify checks for title markers	2024-07-02 17:20:00 -03:00
Dean Herbert	5350945340	Update HasFlag usages	2024-07-03 00:19:04 +09:00
Dean Herbert	fd6b77ea92	Fix distance snap control being removed	2024-06-27 23:59:38 +09:00
Dean Herbert	57774ae767	Merge branch 'master' into slider-anchor-type-switching	2024-06-20 19:01:22 +09:00
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Dean Herbert	0eb533f2fd	Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads ... Reload scrolling hitobject composer on control point changes	2024-06-20 15:15:26 +09:00
Bartłomiej Dach	4022a8b06c	Implement automatic break period generation	2024-06-19 10:22:06 +02:00
Bartłomiej Dach	f764ec24cd	Correct xmldoc	2024-06-18 18:32:24 +02:00
Bartłomiej Dach	7ee29667db	Parse plain numbers as millisecond count when parsing timestamp	2024-06-18 16:48:04 +02:00
Bartłomiej Dach	44b9a06639	Allow more lenient parsing of incoming timestamps	2024-06-18 13:13:50 +02:00
Bartłomiej Dach	2421751419	Fix code quality inspections	2024-06-18 08:33:02 +02:00
Bartłomiej Dach	310265c43f	Add slider placement binding description in tooltip	2024-06-18 08:16:25 +02:00
Bartłomiej Dach	7cfe8d8df2	Reduce editor opacity of several editor components when hovering over composer ... Addresses https://github.com/ppy/osu/discussions/24384.	2024-06-17 12:14:28 +02:00
Bartłomiej Dach	bdeea37a44	Commit active placement when starting drag selection via timeline ... This was reported in https://github.com/ppy/osu/pull/28474, albeit the code changes proposed there did not fix the issue at all. See 8b6385f7d0 for demonstration of the crash scenario. Basically what is happening there is: - The starting premise is that there is a spinner placement active. - At this time, a drag selection is started via the timeline. - Once the drag selection finds at least one suitable object to select, it mutates `SelectedItems`. - When selection changes for any reason, the `HitObjectComposer` decides to switch to the "select" tool, regardless of why the selection changed. - Changing the active tool causes the current placement - if any - to be committed, which mutates the beatmap. - Back at the drag box selection code, this causes a "collection modified when enumerating" exception. The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.	2024-06-14 09:32:40 +02:00
Bartłomiej Dach	922837dd3a	Reload scrolling composer on control point changes	2024-06-11 12:01:35 +02:00
Bartłomiej Dach	14658824e7	Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust	2024-05-02 14:11:44 +02:00
Bartłomiej Dach	70a5288a68	Do not attempt to pass files that don't look like audio to BASS	2024-04-22 10:45:09 +02:00
Bartłomiej Dach	ceeb9b0819	Use explicit reference equality check	2024-04-22 10:27:30 +02:00
Bartłomiej Dach	1bcf835d22	Remove redundant array type specification	2024-04-22 10:25:46 +02:00
Arthur Araujo	49563f4e5b	Use bitwise to check hitsound formats	2024-04-22 04:44:38 -03:00
Arthur Araujo	92b85beff6	Remove ChannelType from messages	2024-04-19 08:01:23 -03:00
Arthur Araujo	68e86b5105	Remove unsued import and add a blankline before yield break;	2024-04-19 07:39:31 -03:00
Arthur Araujo	eac9dededf	Use periods instead of semicolons ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-04-19 07:20:59 -03:00