674 Commits

• Update tests in line with thread safety check
  Dean Herbert · 2021-07-04 17:59:39 +09:00
  3ec7dc3bb9
• Fix thread safety of realm Refresh operation

  Due to the lack of locking, there was a chance the the update thread
  `context` was retrieved just before the `flushContexts` call, followed
  by `.Refresh()` being run while the blocking behaviour was invoked.
  
  This can be seen in test failures such as
  https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests.
  
  As an aside, I tried multiple different methods to avoid `lock()` on the
  update thread but they felt flaky. The overhead of lock when there's no
  contention is reportedly around 30-50ns, so likely not of concern. We
  can address it at a later point if it becomes one.

  Dean Herbert · 2021-07-04 16:24:43 +09:00
  567e9f33a9
• Also add logging of realm block/flush operations
  Dean Herbert · 2021-06-29 20:23:25 +09:00
  2f1203085b
• Merge pull request #13673 from peppy/import-early-checksum-abort

  Shortcut import process to speed up duplicate imports

  Dan Balasescu · 2021-06-28 19:55:09 +09:00
  a9084db665
• Merge branch 'master' into import-early-checksum-abort
  Dan Balasescu · 2021-06-28 19:29:08 +09:00
  92fcf90768
• Simplify disposal exceptions
  Dean Herbert · 2021-06-28 16:17:09 +09:00
  d4ea73d727
• Reorder methods and add xmldoc for BlockAllOperations
  Dean Herbert · 2021-06-28 16:16:40 +09:00
  f78cedd0e1
• Add safety against double disposal
  Dean Herbert · 2021-06-28 16:12:21 +09:00
  90f0bc87f5
• Remove no longer necessary exception
  Dean Herbert · 2021-06-28 16:11:55 +09:00
  842f033522
• Merge branch 'master' into fix-realm-state-change-crashes
  Dean Herbert · 2021-06-28 16:03:58 +09:00
  0d2bc4fc5f
• Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock
  Dean Herbert · 2021-06-28 15:04:14 +09:00
  c281e43cd8
• Fix typo in newly added xmldoc

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2021-06-28 14:07:21 +09:00
  a3946a1265
• Remove redundant string interpolation (and mark all local logging strings as verbatim)
  Dean Herbert · 2021-06-28 12:16:15 +09:00
  4d6002ab88
• Add logging to help understand existing case skips better
  Dean Herbert · 2021-06-28 10:42:42 +09:00
  4a557e73a7
• Add back unidirectional online id check
  Dean Herbert · 2021-06-28 10:11:27 +09:00
  90b87cbb9e
• Revert "Remove comparison of online beatmap IDs during dedupe checks"

  This reverts commit 15af28d2a0.

  Dean Herbert · 2021-06-28 09:54:18 +09:00
  9a96cd4a1d
• Add log method for new flow
  Dean Herbert · 2021-06-27 20:37:12 +09:00
  e755dcc34d
• Move private method down in class
  Dean Herbert · 2021-06-27 20:36:01 +09:00
  f470b7095d
• Fix missing undelete call on using existing
  Dean Herbert · 2021-06-27 20:22:48 +09:00
  f216404952
• Add comments mentioning shortcomings and avoid potential double check
  Dean Herbert · 2021-06-27 19:07:35 +09:00
  9120321731
• Bypass optimised existing check in SkinManager (due to custom hashing function)
  Dean Herbert · 2021-06-27 16:35:13 +09:00
  44f875b802
• Add optimised existing check earlier in import process
  Dean Herbert · 2021-06-27 16:34:40 +09:00
  e493685c14
• Remove comparison of online beatmap IDs during dedupe checks
  Dean Herbert · 2021-06-27 14:48:57 +09:00
  15af28d2a0
• Make Populate abstract to avoid unnecessary base call async complexity
  Dean Herbert · 2021-06-27 14:29:02 +09:00
  d1f852d102
• Fix potential deadlocking behaviour (and convert ResetEvent to Semaphore)
  Dean Herbert · 2021-06-24 14:37:26 +09:00
  63ab40ec24
• Merge branch 'master' into realm-key-binding-store
  Dean Herbert · 2021-05-25 13:41:48 +09:00
  df703b68ec
• Fix "folder missing" message showing incorrectly for beatmaps folder
  Dean Herbert · 2021-05-20 13:56:18 +09:00
  8f5b28d264
• Use bitshifts for enum values instead of literal values.
  Lucas A · 2021-05-17 21:02:45 +02:00
  8530b31e39
• Fix backwards stable install resolution logic.
  Lucas A · 2021-05-17 18:39:04 +02:00
  97952bc3f0
• Simplify import ordering logic by making beatmapImportTask non-nullable.
  Lucas A · 2021-05-17 16:30:13 +02:00
  6110a847aa
• Remove now unreachable code paths.
  Lucas A · 2021-05-17 12:55:59 +02:00
  41fafdf643
• Fix code inspections and remove now unused code.
  Lucas A · 2021-05-17 12:55:58 +02:00
  dabe8bd4c7
• Reword ImportFromStablePopup and display the popup regardless of whether a stable install is detected.
  Lucas A · 2021-05-17 12:55:58 +02:00
  a7b740fd1d
• Bring back injected dependency incorrectly marked as unused.
  Lucas A · 2021-05-17 12:55:58 +02:00
  8ba50b1854
• Add StableDirectoryLocationDialog
  Lucas A · 2021-05-17 12:55:57 +02:00
  481b0a0125
• Order imports depending on beatmap imports if any is running.
  Lucas A · 2021-05-17 12:55:57 +02:00
  325a689d65
• Hook up StableImportManager.
  Lucas A · 2021-05-17 12:55:57 +02:00
  851e33fd15
• Add StableImportManager
  Lucas A · 2021-05-17 12:55:56 +02:00
  5d5b1e1f0e
• Fix incorrect xmldoc for DeleteFile
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  1742ee89e0
• Fix import cancellation not correctly being forwarded to import notification
  Dean Herbert · 2021-04-28 16:09:50 +09:00
  05e3a73a7d
• Fix exported replays being wrapped in zip packages
  smoogipoo · 2021-04-26 20:46:44 +09:00
  6560dc2d1f
• Remove public keywords from interface implementations
  Dean Herbert · 2021-04-24 02:13:31 +09:00
  b9ee63ff89
• Add missing active usage counter increment
  Dean Herbert · 2021-03-31 15:16:01 +09:00
  ecde6137e0
• Remove unused automapper setup for the time being
  Dean Herbert · 2021-03-31 15:10:05 +09:00
  37bf79e8a4
• Merge branch 'master' into realm-migration-operation-blocking
  Dean Herbert · 2021-03-26 17:07:31 +09:00
  f8cea5cae3
• Revert EF Core to version 2.2

  This reverts commit f3faad74d5, reversing
  changes made to 712e7bc7bf.
  
  Several issues arose after migrating to 5.0, including, but possibly not
  limited to, performance regressions in song select, as well as failures
  when attempting to save beatmaps after metadata changes in the editor.

  Bartłomiej Dach · 2021-03-21 11:05:15 +01:00
  a16c0641b2
• Merge branch 'master' into realm-migration-operation-blocking
  Dean Herbert · 2021-03-19 21:33:26 +09:00
  03592fa696
• Fix seemingly innocent logic change causing breakage in score imports
  Dean Herbert · 2021-03-15 14:20:59 +09:00
  1e519f0d31
• Add comments marking workarounds required for EFcore 5
  Dean Herbert · 2021-03-15 13:29:26 +09:00
  fce21f23d6
• Share file lookup workaround in ArchiveModelManager with workaround extensions class
  Dean Herbert · 2021-03-15 13:26:14 +09:00
  2904f479c6