41184 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	b0cfea4916	Fix standardised score conversion failing for some taiko scores due to overestimating accuracy portion ... Standardised score conversion would return a negative total score for https://osu.ppy.sh/scores/taiko/182230346. The underlying reason for this is that the estimation of the accuracy portion for a score can be above the actual accuracy portion in the taiko ruleset. When calculating the maximum accuracy portion achievable, `TaikoLegacyScoreSimulator` will include the extra 300 points from a double hit on a strong hit, per strong hit. However, this double hit is not factored into accuracy. Both of the aforementioned facts mean that in taiko maximumLegacyAccuracyScore * score.Accuracy - which normally in other rulesets can be used pretty reliably as the exact number of points gained from the accuracy portion - is an estimate in the case of taiko, and an _upper_ estimate at that, because it implicitly assumes that the user has also hit `score.Accuracy` percent of all double hits possible in the beatmap. If this assumption is not upheld, then the user will have earned _less_ points than that from the accuracy portion, which means that the combo proportion estimate will go below zero. It is possible that this has happened on other scores before, but did not result in the total score going negative as the accuracy portion gained would have counteracted the effect of that due to being larger in magnitude than the score loss incurred from the negative combo portion. In the case of the score in question this was not the case due to very low accuracy _and_ very low max combo.	2024-01-02 10:11:49 +01:00
Dean Herbert	94531807e4	Make slider ends show on results screen again	2024-01-02 17:01:32 +09:00
iilwy	fbedcb29e4	Merge branch 'master' into fix-precision	2024-01-01 10:42:15 -06:00
CaffeeLake	ad4b5f6ded	Fix: floating point errors ... Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>	2024-01-01 08:32:21 +09:00
Salman Ahmed	34acb435b8	Merge branch 'master' into multiplier1x	2023-12-31 16:48:00 +03:00
Dean Herbert	e10733834b	Merge pull request #26201 from iminlikewithyou/menu-button-tweaks ... Adjust menu buttons	2023-12-31 16:58:55 +09:00
Dean Herbert	68b1455257	Merge pull request #26267 from frenzibyte/fix-audio-offset-adjust-control ... Fix suggested value in audio offset adjust control being opposite in signs	2023-12-31 16:32:13 +09:00
iminlikewithyou	5ae5d7f92d	change floor to round	2023-12-30 23:59:47 -06:00
Salman Ahmed	4dc11c4c48	Update existing code to use helper method	2023-12-31 05:18:07 +03:00
Salman Ahmed	7cfb786b1a	Add helper method for properly formatting score multiplier in ModUtils	2023-12-31 05:17:34 +03:00
Gabriel Del Nero	922b6ccb83	Use FontAwesome solid heart icon instead of OsuIcon's	2023-12-31 00:36:55 +01:00
iminlikewithyou	45f6c78314	Merge branch 'master' of https://github.com/ppy/osu into menu-button-tweaks	2023-12-30 12:58:10 -06:00
iminlikewithyou	452f201f06	use margins isntead of moving the position of the sprite	2023-12-30 12:56:38 -06:00
Salman Ahmed	e6fe631625	Fix suggested value in audio offset adjust control being opposite in signs	2023-12-30 21:34:37 +03:00
Salman Ahmed	cc89390ea8	Expose SuggestedOffset bindable for testing purposes	2023-12-30 21:33:03 +03:00
CaffeeLake	bca0600482	Use 0.99x or 1.01x ... Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>	2023-12-31 00:47:09 +09:00
Dan Balasescu	807443b648	Add HitResult.SliderTailHit	2023-12-30 10:38:47 +09:00
Dean Herbert	0fa4cd5dfe	Merge pull request #26225 from peppy/new-menu-tips ... Add some new menu tips (and reword some others)	2023-12-29 22:27:47 +09:00
Dean Herbert	61c46b78bd	Update MenuTip.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2023-12-29 22:24:16 +09:00
Dean Herbert	9f0fe6c6ca	Fix common typos ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-12-29 22:20:29 +09:00
Dean Herbert	d00b7c9cdf	Add some new menu tips (and reword some others)	2023-12-29 22:14:51 +09:00
Bartłomiej Dach	f80f6a8c5b	Merge pull request #26207 from frenzibyte/fix-dropdown-colour ... Fix dropdown colour not updating correctly on enabled state changes	2023-12-29 14:07:09 +01:00
Bartłomiej Dach	17753b8235	Remove opaque background from toolbar user button ... Would close https://github.com/ppy/osu/issues/26223, and generally seems more consistent with the rest of toolbar anyhow?	2023-12-29 13:49:11 +01:00
Dean Herbert	490c584982	Merge pull request #26222 from bdach/i-cannot-into-offsets ... Fix global audio offset suggestion feature not taking previous offset value into account	2023-12-29 21:14:52 +09:00
Dean Herbert	2b81f4f557	Merge pull request #26221 from bdach/system-title-only-on-top-level-menu ... Do not display system title in inital menu state	2023-12-29 21:13:40 +09:00
Bartłomiej Dach	cdcb3ef4aa	Fix global audio offset suggestion feature not taking previous offset value into account ... See https://osu.ppy.sh/comments/2989193 etc.	2023-12-29 12:20:58 +01:00
Dan Balasescu	9548818a1b	Merge pull request #26220 from bdach/no-version-manager-on-deployed-builds ... Do not show main menu version display on deployed builds	2023-12-29 19:54:30 +09:00
Bartłomiej Dach	db78d73fa5	Do not display system title in inital menu state ... Addresses https://github.com/ppy/osu/discussions/26199.	2023-12-29 11:50:30 +01:00
Bartłomiej Dach	25fa76a1b2	Do not show main menu version display on deployed builds ... See https://discord.com/channels/188630481301012481/188630652340404224/1190028102525530202.	2023-12-29 11:14:28 +01:00
Bartłomiej Dach	99cddb6317	Use alternative workaround	2023-12-29 11:07:45 +01:00
Bartłomiej Dach	cd1f6b46c4	Fix crash after changing audio track in editor ... Closes https://github.com/ppy/osu/issues/26213. Reproduction scenario: switch audio track in editor after timeline loads. Happens because `beatmap.Value.Track.Length` is 0 immediately after a track switch, until BASS computes the actual track length on the audio thread. Yes this is a hack. No I have no better immediate ideas how to address this otherwise.	2023-12-29 10:37:36 +01:00
Dan Balasescu	a6313c4ee8	Expose Mod.UsesDefaultConfiguration	2023-12-29 17:16:16 +09:00
Salman Ahmed	c147ec0a98	Update dropdown disabled state to match with other components	2023-12-29 05:31:13 +03:00
Salman Ahmed	150bf67064	Fix dropdown colour not updating correctly on enabled state changes	2023-12-29 05:30:50 +03:00
Nitrous	c68a850325	Make menu tip about mod select more up to date.	2023-12-29 08:51:54 +08:00
iminlikewithyou	51d26d2d71	make the hover scale bigger ... as a consequence, the rotation needs to be tweaked to be lower	2023-12-28 17:20:44 -06:00
iminlikewithyou	f1f1221e0e	move text left to be visually centered in the skewed rectangle	2023-12-28 17:18:41 -06:00
iminlikewithyou	4760c6aaee	move icon upwards to be visually centered	2023-12-28 17:17:24 -06:00
iminlikewithyou	637119f7d4	increase the base size of button icons	2023-12-28 17:15:23 -06:00
Bartłomiej Dach	7a10e132ea	Fix crash when retrieval of system title image fails ... Closes https://github.com/ppy/osu/issues/26194.	2023-12-28 20:39:13 +01:00
Dean Herbert	8e3fe090f3	Merge pull request #26169 from bdach/universal-offset-from-session-plays ... Implement automatic suggestion of global audio offset based on last plays	2023-12-28 22:57:30 +09:00
Dean Herbert	1de3e3771f	Merge pull request #26187 from peppy/dialog-overlay-design-update ... Update popup dialog design	2023-12-28 22:39:42 +09:00
Bartłomiej Dach	93c7ebdae3	Remove unused using	2023-12-28 14:30:11 +01:00
Bartłomiej Dach	6d124513e7	Fix test failures due to player bailing early after failing to load beatmap	2023-12-28 14:15:15 +01:00
Bartłomiej Dach	619b0cc69b	Fix code quality inspection	2023-12-28 14:12:28 +01:00
Bartłomiej Dach	6718de01ec	Suggest audio adjust after one play	2023-12-28 14:11:08 +01:00
Bartłomiej Dach	e6f1d7db44	Move SessionAverageHitErrorTracker to more general namespace	2023-12-28 14:10:03 +01:00
Bartłomiej Dach	24a80da83f	Merge branch 'master' into universal-offset-from-session-plays	2023-12-28 14:07:46 +01:00
Bartłomiej Dach	e0279920b6	Merge pull request #26189 from peppy/fix-escape-key-spectator-fail ... Fix using "Back" binding at spectator fail screen not working	2023-12-28 13:23:38 +01:00
Dean Herbert	f8347288c1	Add padding around text in dialogs	2023-12-28 20:29:56 +09:00
Bartłomiej Dach	a9c7131d47	Merge pull request #26184 from peppy/spectate-from-context-menu ... Allow entering spectator mode from context menu on user panels	2023-12-28 12:24:29 +01:00
Dean Herbert	e1a376c0a7	Fix using "Back" binding at spectator fail screen not working	2023-12-28 20:14:18 +09:00
Bartłomiej Dach	0fc86a07cb	Merge pull request #26177 from peppy/fix-leaderboard-tab-ordering ... Fix song select leaderboard tab ordering not matching stable	2023-12-28 12:02:46 +01:00
Dean Herbert	91af94086c	Remove offset wizard button for now	2023-12-28 20:02:08 +09:00
Dean Herbert	b7f3c83514	Expose the ability to update global offset from the player loader screen	2023-12-28 20:01:34 +09:00
Dean Herbert	28e220ca50	Update popup dialog design ... Had to be done. I hated the old ones so much. As usual, disclaimer that this is an iterative design and will probably be replaced in the future.	2023-12-28 19:04:35 +09:00
Dean Herbert	22eced3300	Show local user in online users	2023-12-28 17:40:07 +09:00
Dean Herbert	2ec9343868	Add the ability to spectate a user by right clicking their user panel	2023-12-28 17:35:10 +09:00
Dean Herbert	bd0e2b4dde	Remove disclaimer screen completely	2023-12-28 17:21:29 +09:00
Dean Herbert	7dc50b9baf	Don't dismiss on hover, and allow dismissing via click	2023-12-28 17:20:01 +09:00
Dean Herbert	1f2339244e	Add supporter display to main menu	2023-12-28 17:20:01 +09:00
Dean Herbert	b19f72481b	Fade out quickly on game exit sequence	2023-12-28 17:19:41 +09:00
Dean Herbert	0ad6ac8b2a	Remove unused variable	2023-12-28 16:48:17 +09:00
Dean Herbert	932d03a4f8	Make toggle more immediately hide/show tips	2023-12-28 16:21:19 +09:00
Dean Herbert	222459d921	Add background and improve layout	2023-12-28 16:16:27 +09:00
Dean Herbert	a1867afbb4	Move menu tips to main menu ... In preparation for removing the disclaimer screen.	2023-12-28 16:06:08 +09:00
Dean Herbert	be3fc45da5	Merge branch 'master' into system-title-basic	2023-12-28 15:19:33 +09:00
Dean Herbert	6684987289	Reduce refresh interval slightly	2023-12-28 15:19:09 +09:00
Dean Herbert	0ea62d0c5d	Add initial additive blending on fade in	2023-12-28 15:16:42 +09:00
Dean Herbert	972234b1e5	Move re-schedule inside continuation	2023-12-28 15:12:44 +09:00
Dean Herbert	481a251786	Use HandleLink to allow potentially opening wiki or otherwise	2023-12-28 15:11:02 +09:00
Dean Herbert	289e0f00f9	Add flash on click	2023-12-28 15:10:47 +09:00
Dean Herbert	c70e7d340d	Adjust animation and add delay to URL open	2023-12-28 15:10:47 +09:00
Dean Herbert	93a8afe96e	Add very simple cache-busting (30 minutes)	2023-12-28 14:40:10 +09:00
Dean Herbert	ffc8778d67	Fix song select leaderboard tab ordering not matching stable	2023-12-28 14:13:35 +09:00
Dean Herbert	f8d6b8e347	Adjust toolbar animations / layering to feel better	2023-12-28 14:10:52 +09:00
Bartłomiej Dach	ef39759813	More code quality inspections	2023-12-28 00:18:20 +01:00
Bartłomiej Dach	10106e20c7	Merge pull request #26162 from Gabixel/alternate-daycore-with-classic-hotkey ... Cycle between Daycore and Half Time mod when using classic hotkeys style	2023-12-28 00:16:51 +01:00
Bartłomiej Dach	ac449131ed	CodeFileSanity does not like records in standalone files	2023-12-27 23:47:37 +01:00
Bartłomiej Dach	a3f720bc62	Retrieve system title from online source	2023-12-27 23:37:39 +01:00
Bartłomiej Dach	d9299a8a55	Implement visual appearance of "system title" message in main menu	2023-12-27 23:07:17 +01:00
Bartłomiej Dach	160342ceed	Implement automatic suggestion of audio offset based on last plays	2023-12-27 21:14:37 +01:00
Bartłomiej Dach	f51b5f5487	Add components to track average hit errors across session	2023-12-27 20:44:59 +01:00
Dean Herbert	cf5e3e8863	Breathe some colour and life into the toolbar	2023-12-28 04:12:55 +09:00
Dean Herbert	92c4c20a51	Adjust paddings and fills of toolbar buttons	2023-12-28 03:43:38 +09:00
Dean Herbert	70aa067eb1	Adjust gradient visibility and transition	2023-12-28 03:23:04 +09:00
Bartłomiej Dach	1b7af989ec	Migrate BeatmapOffsetControl to use session static directly	2023-12-27 19:19:27 +01:00
Bartłomiej Dach	d4423d4933	Store last set score to a SessionStatic	2023-12-27 19:13:42 +01:00
Dean Herbert	1f55ef211e	Rearrange buttons	2023-12-28 03:11:27 +09:00
Dean Herbert	5f7f1f771d	Reword tooltip text for dashboard	2023-12-28 03:09:20 +09:00
Dean Herbert	655528a537	Update resources	2023-12-28 03:04:13 +09:00
Bartłomiej Dach	89e2b6358a	Remove hexacons	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	53766285ce	Remove remaining hexacons usages	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	288ac930e4	Use new icons in editor ... Some that exist on figma are purposefully not used due to an editorial request from @peppy.	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	2857322a8b	Use new icons in settings	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	c45477bd1f	Use new icons in main menu wherever feasible	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	28d9145a4c	Add more spacing to toolbar icons	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	69baabee62	Replace hexacons in toolbar with new icons	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	45143a6c17	Implement new icon store	2023-12-27 17:42:17 +01:00
Gabriel	28a552f7b9	Merge branch 'ppy:master' into alternate-daycore-with-classic-hotkey	2023-12-27 15:12:13 +01:00