49996 Commits

This Branch

This Branch

All Branches

• Merge pull request #17444 from peppy/fix-countdown-counting

  Update multiplayer countdown button text more often

  Dan Balasescu · 2022-03-25 19:40:04 +09:00
  3986dfd160
• Merge pull request #17421 from peppy/skin-nullable

  Apply `nullable` to skin classes

  Dean Herbert · 2022-03-25 19:39:04 +09:00
  ed239d7016
• Merge pull request #17285 from bdach/mod-overlay/settings-area

  Implement mod settings area component

  Dean Herbert · 2022-03-25 18:27:18 +09:00
  4d91f403d8
• Merge branch 'master' into mod-overlay/settings-area
  Dean Herbert · 2022-03-25 17:37:39 +09:00
  1acfbf490b
• Merge pull request #17314 from frenzibyte/pin-multiplayer-host

  Pin multiplayer host participant panel to the top of the list

  Dean Herbert · 2022-03-25 17:36:52 +09:00
  6bb2d044cf
• Merge branch 'master' into pin-multiplayer-host
  Dean Herbert · 2022-03-25 16:49:35 +09:00
  aa9e642e40
• Remove conditional access on known non-null
  Dean Herbert · 2022-03-25 16:42:35 +09:00
  6b22e5774f
• Update multiplayer countdown button text more often

  At once a second, it regularly skips whole seconds (because scheduler
  isn't guaranteed to run exactly as often as specified). 10 updates a
  second seems amicable and less noticeable to my eye.

  Dean Herbert · 2022-03-25 16:25:20 +09:00
  4a30b6ef56
• Merge pull request #17443 from peppy/fix-unexpected-immediate-exit

  Fix game unexpectedly exiting without outro sequence occasionally on macOS

  Dan Balasescu · 2022-03-25 15:57:57 +09:00
  8553adc401
• Apply notnull constraint
  Dan Balasescu · 2022-03-25 15:54:01 +09:00
  23c4f9910e
• Merge branch 'master' into skin-nullable
  Dan Balasescu · 2022-03-25 15:36:21 +09:00
  2d8d177807
• Merge pull request #17416 from peppy/skin-fuck

  Refactor skin construction

  Dan Balasescu · 2022-03-25 15:36:06 +09:00
  478174dd58
• Fix main menu buttons handling keys when super (cmd) is held
  Dean Herbert · 2022-03-25 15:13:22 +09:00
  416b57ea69
• Rename Button to MainMenuButton to differentiate better
  Dean Herbert · 2022-03-25 15:12:39 +09:00
  816fcae3a1
• Merge pull request #17432 from peppy/realm-subscription-any-thread

  Allow realm subscriptions to be initiated from any thread

  Dan Balasescu · 2022-03-25 14:05:03 +09:00
  c6182c2b09
• Update resources
  Dean Herbert · 2022-03-25 13:18:49 +09:00
  09c5325b08
• Update framework
  Dean Herbert · 2022-03-25 13:07:21 +09:00
  b4c0155b3d
• Merge pull request #17431 from peppy/fix-participants-panel-null-ref

  Guard against potential null `CurrentItem` in `ParticipantPanel`

  Dan Balasescu · 2022-03-25 11:47:43 +09:00
  def2ce243f
• Merge pull request #17429 from peppy/fix-old-legacy-replays

  Fix replays set on old beatmaps having incorrect timing

  Bartłomiej Dach · 2022-03-24 23:45:42 +01:00
  e58b742728
• Merge branch 'master' into fix-old-legacy-replays
  Bartłomiej Dach · 2022-03-24 23:21:50 +01:00
  5f730c0cd4
• Merge pull request #17425 from peppy/fix-realm-import-test-assert-failure

  Fix realm potentially not being refreshed in time for test asserts in `BeatmapImporterTests`

  Bartłomiej Dach · 2022-03-24 22:16:25 +01:00
  959f200638
• Remove assertion to fix "expression always true" inspection
  Bartłomiej Dach · 2022-03-24 21:51:10 +01:00
  878e8d21a3
• Merge branch 'master' into fix-realm-import-test-assert-failure
  Bartłomiej Dach · 2022-03-24 21:48:10 +01:00
  b76cd2beae
• Allow realm subscriptions to be initiated from a non-update thread
  Dean Herbert · 2022-03-24 23:41:07 +09:00
  b04ca111c6
• Update PresentExternally usages in line with framework changes
  Dean Herbert · 2022-03-24 23:41:07 +09:00
  2938f44e6c
• Guard against potential null CurrentItem in ParticipantPanel
  Dean Herbert · 2022-03-24 17:54:21 +09:00
  2d58feebb1
• Add asserts of playlist being non-empty after client operations
  Dean Herbert · 2022-03-24 17:52:20 +09:00
  e889d93441
• Merge pull request #17326 from smoogipoo/multiplayer-countdown-timers-2

  Implement multiplayer countdown timers

  Dean Herbert · 2022-03-24 17:50:53 +09:00
  d7faff15c0
• Merge branch 'master' into multiplayer-countdown-timers-2
  Dean Herbert · 2022-03-24 17:24:00 +09:00
  0275e974e5
• Revert Availability to private
  Dean Herbert · 2022-03-24 17:15:17 +09:00
  e3f8bc0588
• Fix incorrect event binding
  Dan Balasescu · 2022-03-24 17:11:08 +09:00
  528ffea38d
• Split out shared code for encode-decode cycle (and remove unrelated culture set)
  Dean Herbert · 2022-03-24 17:00:49 +09:00
  d6fc53579e
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Add test coverage of decode specifically
  Dean Herbert · 2022-03-24 16:39:56 +09:00
  2efae031c9
• Add test coverage ensuring offsets are correct before and after legacy replay encode
  Dean Herbert · 2022-03-24 16:34:21 +09:00
  59a7eb5322
• Refactor cancellation logic
  Dan Balasescu · 2022-03-24 16:29:59 +09:00
  dfa076c169
• Apply beatmap offsets to legacy replay frame handling
  Dean Herbert · 2022-03-24 16:16:40 +09:00
  a7d5f2281c
• Asserate code is running on update thread
  Dan Balasescu · 2022-03-24 15:51:30 +09:00
  4c0d76573c
• Rename FinishCountdown() -> SkipToEndOfCountdown()
  Dan Balasescu · 2022-03-24 15:21:46 +09:00
  f0d132b16e
• Revert unnecessary async change
  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  d2ecc100e5
• Add explanation for try-catch
  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  8f3a4df70a
• Dispose token manually

  Cover more branches with cancellation source disposal

  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  d36944ac95
• Rename Multiplayer prefix to button classes
  Dan Balasescu · 2022-03-24 14:28:38 +09:00
  96a447f68b
• Re-remove PopoverButton class with better test fix
  Dan Balasescu · 2022-03-24 14:26:31 +09:00
  90c7945bca
• Fix realm potentially not being refreshed in time for test asserts in BeatmapImporterTests

  As seen at https://github.com/ppy/osu/runs/5659368512?check_suite_focus=true
  
  Went through every usage of `.Import` and added either an
  `EnsureLoaded`, or where that provides too many checks, an explicit
  `realm.Refresh()`.

  Dean Herbert · 2022-03-24 12:59:17 +09:00
  4d0b4c2541
• Reword storage param xmldoc to use stronger and better defined langauge
  Dean Herbert · 2022-03-24 12:45:11 +09:00
  e243a7c55d
• Fix typo in xmldocs
  Dean Herbert · 2022-03-24 12:39:47 +09:00
  0cd29a73b9
• Fix incorrect HUD component fallback

  Legacy skins should now always show the legacy hud components. The
  conditional here is no longer valid as fallback lookups happen at a
  *skin*-fallback level rather than internal *source*-fallback.
  
  Put another way, `LegacyDefaultSkin` (with user customisations) should
  still display the classic HUD components even if a font is not provided,
  as that font will be available via the skin lookup hierarchy.
  
  The TODO removed in this commit has been already resolved so this code
  is no longer required.

  Dean Herbert · 2022-03-24 12:36:20 +09:00
  a4d17a915f
• Merge pull request #17419 from peppy/fix-hitsound-regresssssssion

  Fix hitsounds not always playing when they should

  Dan Balasescu · 2022-03-24 11:53:18 +09:00
  3b97de04b7
• Revert "Remove PopoverButton class"

  This reverts commit 6b712be97d.

  Dan Balasescu · 2022-03-24 11:15:51 +09:00
  547418e47e