64434 Commits

This Branch

This Branch

All Branches

• Refactor usage of object counts for mania key count lookup to be a bit safer

  Protects against non-initialised values and also div-by-zero.

  Dean Herbert · 2023-12-19 18:28:04 +09:00
  372f930f8b
• Change default values of new object counts to -1 to identify non-processed values
  Dean Herbert · 2023-12-19 18:20:02 +09:00
  f09c6b8c1b
• Fix arrow pointing to wrong place
  Dean Herbert · 2023-12-19 13:35:02 +09:00
  469a659938
• Update bug-issue.yml with new workflow for exporting logs
  Dean Herbert · 2023-12-19 13:33:45 +09:00
  ee8a5d5a30
• Merge pull request #25871 from Susko3/fix-logfile-notification

  Fix opening log files from notification not presenting the correct file

  Dan Balasescu · 2023-12-19 10:21:18 +09:00
  b6ed792a41
• Fix opening log files from notification not presenting the correct file
  Susko3 · 2023-12-18 21:11:00 +01:00
  cc800a18b2
• Merge pull request #25832 from peppy/more-background-processing-progress-notifications

  Show more comprehensive background processing progress notifications

  Bartłomiej Dach · 2023-12-18 20:05:47 +01:00
  8e8d9b2cd9
• Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc

  Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Bartłomiej Dach · 2023-12-18 19:54:17 +01:00
  b8bcf7a097
• Update framework
  Dean Herbert · 2023-12-19 03:22:22 +09:00
  9594ae7802
• Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Closes https://github.com/ppy/osu/issues/25854.

  Dean Herbert · 2023-12-19 01:07:33 +09:00
  374425ea75
• Merge pull request #25821 from bdach/fix-collection-dropdown-crash

  Fix collections dropdown crashing during storage migration

  Dean Herbert · 2023-12-19 01:01:23 +09:00
  c466775f78
• Merge pull request #25848 from 65-7a/dropdown-search-padding

  Fix padding on dropdown search bar

  Dean Herbert · 2023-12-19 00:36:14 +09:00
  c88c25e77f
• Merge pull request #25839 from bdach/collection-name-clashes-crashes

  Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Dean Herbert · 2023-12-19 00:32:18 +09:00
  da658bbf25
• Don't show progress notifications when there are too few items to be worthwhile
  Dean Herbert · 2023-12-19 00:01:09 +09:00
  9aaaa12809
• Fix padding on dropdown search bar
  65-7a · 2023-12-19 00:28:23 +11:00
  17f1f8bb43
• Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Closes https://github.com/ppy/osu/issues/25834
  
  The name fallback that was there previously since
  https://github.com/ppy/osu/pull/11892 was half broken. This way should
  be a lot less prone to failure.

  Bartłomiej Dach · 2023-12-18 12:52:39 +01:00
  eeeb5aa3d4
• Add failing test for adding collection w/ name colliding w/\ default items
  Bartłomiej Dach · 2023-12-18 12:47:42 +01:00
  be16e0e538
• Merge pull request #25833 from peppy/fix-song-select-position-reset

  Fix song select's carousel scroll position getting reset on background processing

  Bartłomiej Dach · 2023-12-18 12:27:48 +01:00
  41f5a6e292
• Remove some excessive logging
  Dean Herbert · 2023-12-18 19:20:57 +09:00
  03ac2c3094
• Fix song select's carousel scroll position getting reset on background processing

  This only happened for users using absolute right-click scroll.

  Dean Herbert · 2023-12-18 19:17:59 +09:00
  62444c3d04
• Fix progress notifications queueing up infinite text changes when not visible
  Dean Herbert · 2023-12-18 19:00:44 +09:00
  e3251b40b3
• Add logging of progress every so often
  Dean Herbert · 2023-12-18 18:45:49 +09:00
  5ab3815123
• Also populate ObjectCounts when running a full beatmap process

  Saves running things twice on an old install

  Dean Herbert · 2023-12-18 18:41:41 +09:00
  bfa90e9dcb
• Add progress notifications for background tasks which don't already have them
  Dean Herbert · 2023-12-18 18:41:41 +09:00
  e7d1cf7868
• Add helper method to handle progress notifications for background jobs
  Dean Herbert · 2023-12-18 18:41:41 +09:00
  7462a9f4ab
• Merge pull request #25823 from cl8n/taiko-random-mod-legacy-conversion

  Don't convert TaikoModRandom to/from legacy mods

  Dan Balasescu · 2023-12-18 18:27:35 +09:00
  27ae7d77f4
• Fix collections dropdown crashing during storage migration

  Closes https://github.com/ppy/osu/issues/25815.
  
  `CollectionDropdown.collectionsChanged()` was assuming that if it
  received `null` changes, then it must mean that the change subscription
  is being initialised and the `filters` list will not contain any items.
  
  However, that is not the only circumstance wherein a realm subscription
  can fire with `null` changes; that can also happen after the main realm
  instance gets recycled via the notification registration flow:
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L545-L549
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L1228-L1251
  
  Therefore, to fix the crash, just ensure that the list is cleared every
  time.

  Bartłomiej Dach · 2023-12-18 09:11:00 +01:00
  ef230884a8
• Don't convert TaikoModRandom to/from legacy mods
  clayton · 2023-12-17 23:47:50 -08:00
  f84c181573
• Merge pull request #25776 from smoogipoo/slider-late-hit-lenience

  Add slider head circle late hit lenience

  Dean Herbert · 2023-12-18 13:05:31 +09:00
  2023.1218.0 2f28a92f0a
• Merge pull request #25808 from smoogipoo/fix-scoring-attribs-maxcombo

  Populate MaxCombo scoring attrib for non-osu rulesets

  Dean Herbert · 2023-12-18 12:25:06 +09:00
  92c33f2057
• Populate MaxCombo scoring attrib for non-osu rulesets
  Dan Balasescu · 2023-12-18 12:01:51 +09:00
  30116512ca
• Merge pull request #25797 from smoogipoo/osu-ruleset-lazer-hp

  Make osu! ruleset once again use the lazer default HP drain

  Dean Herbert · 2023-12-17 22:22:43 +09:00
  deef7dae1d
• Fix assertions
  Dan Balasescu · 2023-12-17 21:52:21 +09:00
  04d542105f
• Require slider head to be judged before ticks
  Dan Balasescu · 2023-12-17 21:26:48 +09:00
  2b33aec124
• Fix 1-frame issues due to referencing external value
  Dan Balasescu · 2023-12-17 20:19:25 +09:00
  fddfa33e49
• Only track if in slider ball after any ticks missed
  Dan Balasescu · 2023-12-17 20:12:02 +09:00
  9b02bd712b
• Fix tail being missed too early
  Dan Balasescu · 2023-12-17 20:11:15 +09:00
  fbe48d7be8
• Only hit passed-through ticks if none were missed
  Dan Balasescu · 2023-12-17 19:57:48 +09:00
  f77884b62f
• Rename test scene
  Dan Balasescu · 2023-12-17 19:33:38 +09:00
  10610d3387
• Change osu ruleset to use new HP algorithm by default
  Dan Balasescu · 2023-12-17 19:33:04 +09:00
  4b9aefa6f2
• Add IApplicableHealthProcessor
  Dan Balasescu · 2023-12-17 19:27:03 +09:00
  d7aca2f641
• Merge branch 'master' into slider-late-hit-lenience
  Dean Herbert · 2023-12-17 13:00:01 +09:00
  c0e96927aa
• Merge pull request #25775 from peppy/more-import-lenience

  Allow new common cases when a user is locating a stable osu! install directory for import

  Dean Herbert · 2023-12-17 12:12:06 +09:00
  7573e316bf
• Merge pull request #25787 from cl8n/fix-mania-column-color

  Fix fallback column colors for legacy split stage mania skins

  Dean Herbert · 2023-12-16 20:19:02 +09:00
  b0814400c2
• Fix fallback column colors for legacy split stage mania skins
  clayton · 2023-12-15 22:41:55 -08:00
  f07771f59b
• Merge pull request #25777 from peppy/fix-tablet-mania-column-sizing

  Fix column sizing exceeding screen width on tablets

  Bartłomiej Dach · 2023-12-15 21:28:23 +01:00
  7caca905e3
• Merge branch 'master' into fix-tablet-mania-column-sizing
  Bartłomiej Dach · 2023-12-15 20:58:34 +01:00
  df887abae9
• Explain magic constants better
  Bartłomiej Dach · 2023-12-15 20:43:18 +01:00
  432ce275c4
• Merge branch 'master' into more-import-lenience
  Bartłomiej Dach · 2023-12-15 16:02:44 +01:00
  285284eb34
• Fix first run locator stable locator directory desyncing between display & popover
  Bartłomiej Dach · 2023-12-15 16:00:34 +01:00
  91f4123aa7