48225 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	ee4f5c0e79	Rename button classes to make more sense	2022-01-04 17:52:40 +09:00
Dean Herbert	db58f5de8e	Clean up unnecessary complexity	2022-01-04 17:51:37 +09:00
Dean Herbert	5736b7d978	Fix cursors sent to osu-web being potentially string formatted in incorrect culture ... Fixed as per solution at https://github.com/JamesNK/Newtonsoft.Json/issues/874. Note that due to the use of `JsonExtensionDataAttribute` it's not feasible to change the actual specification to `JValue` in the `Dictionary`. In discussion with the osu-web team, it may be worthwhile to change the cursor to a string format where parsing is not required at our end. We could already do this in fact, but there are tests that rely on it being a `JToken` so the switch to `JValue` seems like the easier path right now.	2022-01-04 17:20:46 +09:00
Dean Herbert	1c899e4402	Fix post-merge issues	2022-01-04 16:46:42 +09:00
Dean Herbert	69e7ee0f48	Merge branch 'master' into page-selector	2022-01-04 16:44:22 +09:00
Dean Herbert	39650ce7e9	Merge pull request #16307 from peppy/beatmap-listing-bottom-padding ... Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds	2022-01-04 14:14:42 +09:00
Dean Herbert	374dac57f2	Change expanded card content height to 200	2022-01-04 13:22:00 +09:00
Dean Herbert	2b258e786a	Merge pull request #16313 from bdach/fix-listing-terminal-breakage ... Fix beatmap listing overlay not expiring content from previous searches	2022-01-04 12:22:47 +09:00
Dean Herbert	f9713b8895	Replace usage of TimeoutAttribute to fix beatmap conversion test failures	2022-01-04 11:51:41 +09:00
Dean Herbert	f3e889d0f6	Fix incorrect nested result retrieval in ImportBeatmapTest	2022-01-04 11:51:41 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Dean Herbert	031a40af6a	Replace usages of Wait with WaitSafely	2022-01-04 11:51:41 +09:00
Dean Herbert	f6b1405fa0	Merge branch 'master' into fix-listing-terminal-breakage	2022-01-04 11:49:02 +09:00
Dean Herbert	17d56d117e	Merge pull request #16314 from bdach/submission-on-exit-test-coverage ... Add test coverage of score submission if player is exited during import	2022-01-04 11:46:22 +09:00
Bartłomiej Dach	7cdba2f7c3	Add test coverage of score submission if player is exited during import	2022-01-03 22:00:47 +01:00
Bartłomiej Dach	8f335c333c	Merge pull request #16278 from peppy/fix-skin-editor-overlay-show-thread-safetyu ... Fix calling `SkinEditorOverlay.Show` before the overlay is loaded causing an exception	2022-01-03 20:41:48 +01:00
Bartłomiej Dach	87fbac15fd	Merge branch 'master' into fix-skin-editor-overlay-show-thread-safetyu	2022-01-03 20:12:18 +01:00
Bartłomiej Dach	de33b420ab	Add safety against performing operation on non-alive foundContent	2022-01-03 20:02:46 +01:00
Bartłomiej Dach	586f158920	Remove initial foundContent value ... It always is replaced on the first search anyway, and just remains forever in the overlay otherwise.	2022-01-03 19:52:42 +01:00
Bartłomiej Dach	6650a468e0	Fix and simplify very broken beatmap listing content swap-out logic ... The beatmap listing content swap-out logic was already a source of several problems, and several attempts of fixing it were made. But as it turns out it was terminally broken in several aspects. * The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't really look much different than an instant fade. Therefore, all fade durations and manipulations of `BypassAutoSizeAxes` are removed. * The transform sequence juggling the `BypassAutoSizeAxes` manipulations was enqueued on the content which is being in the process of fading out. That was partially fixed in 25e38560, but as it turns out, that only works if `lastContent` is one of the two placeholder drawables (results not found / supporter required to use filter). It would not work if `lastContent` is a `ReverseChildIDFillFlowContainer` with cards from a previous search in it.	2022-01-03 19:51:46 +01:00
Bartłomiej Dach	ef9f56e585	Fix bad check if content is placeholder ... The `lastContent == foundContent` check, last touched in a49a4329, is terminally broken, as it would always be false. `foundContent` is mutated when a new card load task is started in `onSearchFinished()`, which is *before* the aforementioned check. The code prior to a49a4329 was checking against the two static reused placeholder drawables which was the correct check to apply, and this commit reverts to using a variant of that check.	2022-01-03 19:51:20 +01:00
Bartłomiej Dach	97439c3df1	Rename method to reflect what it actually does	2022-01-03 19:30:17 +01:00
Bartłomiej Dach	2660f41339	Add failing test case for old cards not expiring correctly	2022-01-03 19:28:14 +01:00
Bartłomiej Dach	7c246670b4	Add padding to bottom of spotlights ranking view to avoid hovered panels exceeding visible bounds	2022-01-03 18:43:20 +01:00
Bartłomiej Dach	0ad555e9f7	Remove surplus blank line	2022-01-03 18:33:32 +01:00
Dean Herbert	d4ea57c660	Merge pull request #15844 from mk56-spn/positional-sounds-strength-adjustment ... Positional sounds strength adjustment slider implementation	2022-01-03 14:30:25 +09:00
Dean Herbert	b9851b278d	Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds ... Closes https://github.com/ppy/osu/issues/16120.	2022-01-03 13:18:28 +09:00
Dean Herbert	6356180b6a	Remove unnecessary code and fix double nesting causing filtering to not work	2022-01-03 12:53:58 +09:00
Dean Herbert	623d6d6d2d	Add migration of positional hitsounds setting to new level based setting	2022-01-03 12:46:20 +09:00
Dean Herbert	5dd024aab7	Remove outdated settings migration	2022-01-03 12:46:02 +09:00
Dean Herbert	bb54f438aa	Merge branch 'master' into positional-sounds-strength-adjustment	2022-01-03 12:40:56 +09:00
Dean Herbert	cf864e58f7	Merge pull request #16253 from peppy/reduce-chat-overhead ... Reduce overhead from chat polling when game is not active	2022-01-01 23:42:31 +09:00
Bartłomiej Dach	e7d7587ea5	Merge branch 'master' into reduce-chat-overhead	2022-01-01 15:02:55 +01:00
Bartłomiej Dach	2bdf470d83	Merge pull request #16292 from peppy/storyboard-outro-test-reliability ... Improve reliability of `TestStoryboardSkipOutro`	2022-01-01 14:10:17 +01:00
Dean Herbert	04d8fd3a58	Improve reliability of TestStoryboardSkipOutro ... Aims to resolve failures as seen at https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true. Have run quite a lot locally with no failures (while removing the skip step 100% fails).	2022-01-01 15:32:39 +09:00
Dean Herbert	675bdd3213	Fix MultiplayerMatchSubScreen mutating mods outside of bindable lease ... As seen at https://github.com/peppy/osu/runs/4674501626?check_suite_focus=true.	2022-01-01 12:13:59 +09:00
Dean Herbert	1262e76a58	Fix test failure due to missing DI cached IdleTracker	2021-12-31 23:18:03 +09:00
Dean Herbert	f656e7d2d2	Merge pull request #16284 from peppy/archive-reader-synchronous-flow ... Avoid potential deadlocks in `ArchiveReader` synchronous implementation	2021-12-31 12:46:13 +09:00
Bartłomiej Dach	cbb62fab26	Merge pull request #16282 from peppy/fix-kiai-drawable-nullref ... Fix null reference causing crash in `KiaiFlashingDrawable`	2021-12-30 23:43:58 +01:00
Bartłomiej Dach	42b93283ca	Merge branch 'master' into fix-kiai-drawable-nullref	2021-12-30 23:15:42 +01:00
Bartłomiej Dach	d68c47e710	Merge pull request #16283 from peppy/fix-leaderboard-test ... Fix `TestSceneMultiSpectatorLeaderboard` not waiting for user population	2021-12-30 23:00:24 +01:00
Dean Herbert	670a30b64b	Remove usage of .Result in ArchiveReader	2021-12-31 01:52:01 +09:00
Dean Herbert	e38e1bb1d7	Enable a couple of missing async related inspections	2021-12-31 01:52:01 +09:00
Dean Herbert	f53a675ca3	Fix TestSceneMultiSpectatorLeaderboard not waiting for user population	2021-12-31 00:48:31 +09:00
Dean Herbert	408e8d5710	Fix null reference causing crash in KiaiFlashingDrawable ... Can occur if there is no fallback graphics available. Previously would work as it was only setting the `Texture`. As reported in https://github.com/ppy/osu/discussions/16281.	2021-12-30 22:21:39 +09:00
Dean Herbert	089b756f93	Invert logic to make reading easier	2021-12-30 16:03:16 +09:00
Dean Herbert	ef49f2ed0e	Add extra extra safety against attempting to load a previously expired editor	2021-12-30 16:02:31 +09:00
Joseph Madamba	cdc148f78e	Increase scope of identifier typo disables on special cases	2021-12-29 14:07:36 -08:00
Dean Herbert	b1a444180f	Fix Show then Reset potentially resulting in incorrect load target	2021-12-29 21:46:34 +09:00
Dean Herbert	2fd4647e6e	Merge pull request #16272 from bdach/animated-hit-circle-overlay ... Add support for animated hit circle overlay	2021-12-29 21:39:27 +09:00