58147 Commits

This Branch

This Branch

All Branches

• Fix CircularDistanceSnapGrid returning an incorrect time value when distance spacing is not 1.0
  Dean Herbert · 2022-05-05 17:09:14 +09:00
  4c884aea5d
• Expose DistanceSpacingMultiplier to distance
  Dean Herbert · 2022-05-05 17:08:53 +09:00
  786c7f14d3
• Rename misleading DistanceSpacing variable
  Dean Herbert · 2022-05-05 17:08:09 +09:00
  de9b3d33eb
• Reword weird xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-05-05 17:07:05 +09:00
  c3d2648f85
• Merge branch 'cache-at-interface'
  Dean Herbert · 2022-05-05 16:52:03 +09:00
  4226583afd
• Merge branch 'snapping-tidy-distance'
  Dean Herbert · 2022-05-05 16:51:32 +09:00
  19cf9dc20b
• Merge branch 'snapping-tidy'
  Dean Herbert · 2022-05-05 16:51:31 +09:00
  225fc65068
• Remove unnecessary type specification in HitObjectComposer's caching
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  5a1ac71d90
• Move snap provider caching to interfaces
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  1c6a233cc0
• Move IPlacementHandler caching to interface
  Dean Herbert · 2022-05-05 16:43:02 +09:00
  b411b59006
• Add xmldoc for IDistanceSnapProvider and related properties
  Dean Herbert · 2022-05-05 16:25:45 +09:00
  977e6d8a80
• Add comprehensive documentation of BeatmapInfo.DistanceSpacing
  Dean Herbert · 2022-05-05 16:25:45 +09:00
  6227e3f876
• Add workaround for item scrolling issue
  Salman Ahmed · 2022-05-05 10:16:16 +03:00
  ac6342ff8d
• Reword slightly, to allow better conformity with IDistanceSnapProvider
  Dean Herbert · 2022-05-05 16:04:34 +09:00
  1fce0da331
• Merge pull request #18098 from peppy/strict-tracking-description

  Remove weird strict tracking icon and reword description to explain what the mod does

  Bartłomiej Dach · 2022-05-05 09:02:59 +02:00
  0c2d280443
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Merge branch 'master' into strict-tracking-description
  Bartłomiej Dach · 2022-05-05 08:41:27 +02:00
  79ecf5dd5d
• Merge pull request #18097 from Supersonicboss1/fix-alternate-mod-display

  Fix Autoplay and Cinema not showing incompatibility with Alternate on hover, and made Alternate incompatible with Relax

  Bartłomiej Dach · 2022-05-05 08:37:48 +02:00
  93deb3cf20
• Remove weird strict tracking icon and reword description to explain what the mod does
  Dean Herbert · 2022-05-05 15:16:01 +09:00
  cbc58c67bf
• Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)
  Dean Herbert · 2022-05-05 15:02:23 +09:00
  f6a6a11391
• Fix CurrentDialog being updated twice, unsafe variable access
  Dean Herbert · 2022-05-05 14:55:05 +09:00
  326ff3b6e9
• Add test coverage for multiplayer mod validity methods
  Salman Ahmed · 2022-05-05 08:13:29 +03:00
  86aa2125fe
• Improve validity methods to include system, non-implemented, and multi mods
  Salman Ahmed · 2022-05-05 08:13:06 +03:00
  e3c7c5d0b9
• Add missing Test prefix
  Salman Ahmed · 2022-05-05 06:12:24 +03:00
  a26793cd65
• Handle against playlists which disallow selection

  `SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).

  Salman Ahmed · 2022-05-05 05:48:35 +03:00
  f28978b856
• Rename local correctly
  Salman Ahmed · 2022-05-05 05:42:20 +03:00
  464b3af5f3
• fixed autoplay not showing compat, + relax compat
  Supersonicboss1 · 2022-05-04 22:25:34 +01:00
  81b4622620
• Fix failing tests due to CurrentDialog being unexpectedly not set after Push
  Dean Herbert · 2022-05-05 01:52:39 +09:00
  a27fcda9f1
• Inline CheckCompatibleSet method to avoid ugly boolean flag
  Salman Ahmed · 2022-05-04 18:56:30 +03:00
  d0df9e8051
• Renew obsoletion date
  Salman Ahmed · 2022-05-04 17:22:11 +03:00
  8488a29e9e
• Bring back behaviour of checking incompatibility on gameplay validity
  Salman Ahmed · 2022-05-04 17:21:19 +03:00
  8f04db5df5
• Apply proposed naming changes
  Salman Ahmed · 2022-05-04 17:12:17 +03:00
  20e277d2e5
• Merge branch 'master' into multiplayer-disable-adaptive-speed
  Salman Ahmed · 2022-05-04 17:12:03 +03:00
  e9ecf26b6a
• Merge branch 'master' into beatmap-selection-keybinding
  Salman Ahmed · 2022-05-04 16:48:49 +03:00
  e294069e2f
• Globalise beatmap selection key bindings as "group" selection
  Salman Ahmed · 2022-05-04 16:46:32 +03:00
  9416346c94
• Ensure focus is directed to ChatTextBox from ChatOverlay and add tests
  Jai Sharma · 2022-05-04 14:43:40 +01:00
  1a85e1267b
• Tidy up state variables
  Dean Herbert · 2022-05-04 21:00:11 +09:00
  ddab3c6d80
• Reimplement sliderticks
  apollo-dw · 2022-05-04 12:55:22 +01:00
  81ce0e6565
• Fix test failures due to selection/item collection desyncs
  Bartłomiej Dach · 2022-05-04 13:51:47 +02:00
  e6fdef2d7a
• Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity

  Port test coverage from old mod select overlay to new design

  Dean Herbert · 2022-05-04 20:24:50 +09:00
  e920bbd497
• Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms

  As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.

  Dean Herbert · 2022-05-04 20:23:36 +09:00
  383245f43a
• Add test coverage of cross-thread transforms if a dialog is pushed too early
  Dean Herbert · 2022-05-04 20:23:36 +09:00
  cf220f171b
• Ensure selected playlist item is always scrolled into view
  Bartłomiej Dach · 2022-05-04 13:15:26 +02:00
  0405c1c34a
• Add test coverage for keyboard selection
  Bartłomiej Dach · 2022-05-04 13:15:10 +02:00
  ec27fa8e85
• Merge pull request #18088 from peppy/fix-editor-toolbox-click-through

  Fix clicks and drags around editor toolboxes resulting in unexpected interactions

  Dean Herbert · 2022-05-04 19:42:32 +09:00
  e4ac714c6d
• Merge branch 'master' into mod-overlay/test-coverage-parity
  Dean Herbert · 2022-05-04 19:40:56 +09:00
  5f11ff564b
• Rename FlushAnimation to FlushPendingSelections to better match purpose
  Dean Herbert · 2022-05-04 19:40:08 +09:00
  3eead5a6a3
• Fix self-reference in region name
  Bartłomiej Dach · 2022-05-04 12:36:43 +02:00
  3b04daddaa
• Add support for traversing playlist items using next/previous bindings

  Addresses https://github.com/ppy/osu/discussions/18061.

  Dean Herbert · 2022-05-04 19:09:44 +09:00
  df1f4aecdc
• Change ChatTextBox to not handle up/down arrows
  Dean Herbert · 2022-05-04 19:09:22 +09:00
  2f12c7d9e1