3275 Commits

Author	SHA1	Message	Date
Joseph Madamba	3035e8435d	Apply NRT to incoming changed files	2024-12-12 15:22:58 -08:00
Bartłomiej Dach	89e3c551ff	Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files ... Allow choosing different background/audio files for individual difficulties	2024-12-11 14:12:58 +09:00
Dean Herbert	48bf2fa001	Merge pull request #30960 from bdach/bookmarks ... Implement basic bookmark support in editor	2024-12-09 23:42:04 -08:00
Dean Herbert	92dfcae6eb	Adjust bad grammar	2024-12-10 14:35:09 +09:00
Dan Balasescu	1b8d9370aa	Merge pull request #30973 from frenzibyte/copy-effect-points ... Preserve effect point specifications when creating blank difficulties	2024-12-09 16:13:52 +09:00
Salman Alshamrani	5cb6b86b1c	Fix reference effect point getting mutated	2024-12-06 05:47:41 -05:00
Salman Alshamrani	e3abbf1177	Copy effect points across on blank difficulty creation	2024-12-04 02:32:00 -05:00
Bartłomiej Dach	808934581f	Move bookmarks out of BeatmapInfo ... Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...	2024-12-03 14:17:14 +01:00
Dean Herbert	5b2558cec2	Merge pull request #28473 from bdach/beatmap-info-purge ... Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`	2024-12-02 16:19:12 +09:00
Bartłomiej Dach	110e4fbb30	Centralise supported file extensions to one helper class ... As proposed in https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.	2024-11-29 08:42:45 +01:00
Dean Herbert	5260a401d4	Use RealmLive in SaveFailedScoreButton ... This also optimises the manager classes to better support `Live` usage where the managed object is already in a good state (ie. doesn't require re-fetching).	2024-11-27 15:25:42 +09:00
Dean Herbert	573aaf6637	Merge pull request #27128 from frenzibyte/user-statistics-provider ... Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset	2024-11-27 13:13:47 +09:00
Bartłomiej Dach	46d1f00590	Fix Beatmap.Countdown not being copied on conversion	2024-11-26 11:39:03 +01:00
Bartłomiej Dach	cf905d0f5c	Merge branch 'master' into beatmap-info-purge	2024-11-26 10:21:16 +01:00
Dean Herbert	9ca17f9b6b	Merge pull request #30748 from stanriders/scale-profile-beatmaps ... Scale down beatmap cards	2024-11-25 22:53:51 +09:00
Dean Herbert	c590bef4c3	Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default	2024-11-22 19:05:29 +09:00
Dean Herbert	086a34f5c0	Merge branch 'master' into beatmap-info-purge	2024-11-22 18:47:32 +09:00
Dean Herbert	e33e0e16e8	Merge branch 'master' into scale-profile-beatmaps	2024-11-22 18:33:37 +09:00
Dean Herbert	a76b4418b9	Change some beatmap default settings to match stable ... - Countdown should [be off by default](9a07485638/osu!/GameplayElements/Beatmaps/Beatmap.cs#L372) - Samples match playback rate [also](9a07485638/osu!/GameplayElements/Beatmaps/Beatmap.cs#L210)	2024-11-22 16:55:37 +09:00
Dean Herbert	6fba6de4dc	Merge branch 'master' into multiplayer-remove-cmc-and-composite	2024-11-20 17:24:55 +09:00
Dan Balasescu	a5327aa562	Use properties instead of fields	2024-11-19 18:48:30 +09:00
Salman Alshamrani	74daf85e48	Replace bindable with an event	2024-11-18 06:47:22 -05:00
StanR	4066186b24	Scale beatmap cards down by ~0.8	2024-11-18 14:48:51 +05:00
Salman Alshamrani	b106833663	Fix more test / component breakage	2024-11-17 20:36:12 -05:00
Salman Alshamrani	caf56afba6	Fix various test failures	2024-11-17 19:13:29 -05:00
Salman Alshamrani	28f87407f6	Make DifficultyRecommender rely on the statistics provider	2024-11-17 18:32:17 -05:00
Shin Morisawa	7dff243e6a	use .ToFormattedDuration	2024-11-14 16:59:03 +09:00
Shin Morisawa	64e7e44f28	fix issue	2024-11-14 16:33:52 +09:00
Shin Morisawa	53fcb494ff	Merge branch 'ppy:master' into 1hour-song-multi	2024-11-14 16:32:24 +09:00
Dean Herbert	7f8eebc510	Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type ... Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`	2024-11-14 16:16:44 +09:00
Dean Herbert	d37c1bb6d0	Remove redundant null initialisation and apply nullability	2024-11-14 13:37:58 +09:00
Dean Herbert	7670a81181	Merge branch 'master' into bat-max-performance	2024-11-14 13:35:29 +09:00
Shin Morisawa	a3da10ff44	fixed said issue	2024-11-14 07:19:18 +09:00
Shin Morisawa	7e96ae6da4	change stuff. (idk what exactly)	2024-11-14 06:58:54 +09:00
Dan Balasescu	72564b5c98	Make CurrentPlaylistItem not a bindable	2024-11-12 18:17:24 +09:00
Dan Balasescu	7206e97b7b	Add IHasLegacyHitObjectType to ConvertHitObject	2024-11-11 16:10:15 +09:00
Dan Balasescu	e1d93a7d9c	Merge implementations of ConvertHitObjectParser ... Having these be separate implementations sounded awesome at the time, but it only ever led to confusion. There's no practical difference if, for example, catch sees hitobjects with `IHasPosition` instead of `IHasXPosition`.	2024-11-11 15:09:13 +09:00
Dean Herbert	c7d0a7dde2	Update xmldoc and make realm transactions more obvious	2024-11-07 18:31:06 +09:00
Dan Balasescu	bd630c189e	Fix tests not working by forgoing beatmap updates	2024-11-07 17:26:10 +09:00
Bartłomiej Dach	23f3890293	Fix effect point scroll speeds below 0.1x not being encoded properly ... Closes https://github.com/ppy/osu/issues/30472. Caused by mismatching bounds between 2bd12e14db/osu.Game/Beatmaps/ControlPoints/EffectControlPoint.cs (L22-L26) and 2bd12e14db/osu.Game/Beatmaps/ControlPoints/DifficultyControlPoint.cs (L21-L28)	2024-11-05 11:56:19 +01:00
Bartłomiej Dach	3dc2408965	Merge branch 'master' into bat-max-performance	2024-11-01 13:13:20 +01:00
Bartłomiej Dach	7e3564cb4a	Bring back matching by filename when performing online metadata lookups	2024-10-30 10:25:20 +01:00
Bartłomiej Dach	2b0fd3558f	Remove more no-longer-required checks ... The scenario that remaining guard was trying to protect against is obviated by and no longer possible after 776fabd77c.	2024-10-30 08:44:23 +01:00
Bartłomiej Dach	776fabd77c	Only use MD5 when performing metadata lookups ... Both online and offline using the cache. The rationale behind this change is that in the current state of affairs, `TestPartiallyMaliciousSet()` fails in a way that cannot be reconciled without this sort of change. The test exercises a scenario where the beatmap being imported has an online ID in the `.osu` file, but its hash does not match the online hash of the beatmap. This turns out to be a more frequent scenario than envisioned because of users doing stupid things with manual file editing rather than reporting issues properly. The scenario is realistic only because the behaviour of the endpoint responsible for looking up beatmaps is such that if multiple parameters are given (e.g. all three of beatmap MD5, online ID, and filename), it will try the three in succession: f6b341813b/app/Http/Controllers/BeatmapsController.php (L260-L266) and the local metadata cache implementation reflected this implementation. Because online ID and filename are inherently unreliable in this scenario due to being directly manipulable by clueless or malicious users, neither should not be used as a fallback.	2024-10-30 08:12:30 +01:00
Bartłomiej Dach	1a2e323c11	Remove problematic online ID check	2024-10-30 07:40:08 +01:00
Dean Herbert	5939c78760	Merge branch 'master' into auto-addition2	2024-10-23 15:53:07 +09:00
Dean Herbert	8193038986	Expose no-op constructors as protected	2024-10-18 13:30:29 +09:00
Dan Balasescu	bfcf6693ca	Simplify implementation	2024-10-17 20:00:17 +09:00
Dan Balasescu	d195a69447	Compute maximum performance along with difficulty	2024-10-17 19:26:19 +09:00
Dean Herbert	53671ad11e	Only update beatmaps which actually had offsets ... Without this every beatmap gets a write and it reloads the whole of song select, basically.	2024-10-14 00:35:18 +09:00