1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 05:22:54 +08:00
Commit Graph

44 Commits

Author SHA1 Message Date
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Dean Herbert
735e7b9c74 Pass fetch more action in via ctor to avoid potential nullref 2021-05-26 22:49:39 +09:00
Andrei Zavatski
1bde11a07e Refactor ArticleListing 2021-05-26 15:35:38 +03:00
Dean Herbert
d165a75823 Inline request flow to make it easier to understand 2021-05-26 14:37:52 +09:00
Dean Herbert
0f21510b8b Move code around 2021-05-26 14:29:46 +09:00
Dean Herbert
8ffa7f4a5a Tidy up code 2021-05-26 14:28:20 +09:00
Dean Herbert
7b09955d59 Remove redundant default bindable value 2021-05-26 14:17:40 +09:00
Andrei Zavatski
06fe0563d3 Move GetNewsRequest from ArticleListing to NewsOverlay 2021-05-24 08:26:44 +03:00
Dean Herbert
fbe4d7e03c Improve code quality around cursor and upwards passing of response data 2021-05-21 15:41:31 +09:00
Andrei Zavatski
40ca94cd7b Fix incorrect year being passed on first load 2021-05-20 16:04:51 +03:00
Dean Herbert
958d51141d Rename FrontPageDisplay to ArticleListing 2021-05-20 15:24:01 +09:00
Dean Herbert
d4530313aa Tidy event parameter naming 2021-05-20 15:15:46 +09:00
Dean Herbert
673ca4c2a1 Tidy up content container specification 2021-05-20 14:30:40 +09:00
Dean Herbert
ac8efdeabd Move private methods down 2021-05-20 14:12:34 +09:00
Dean Herbert
713f69ea55 Tidy up load process 2021-05-20 14:11:42 +09:00
Andrei Zavatski
e3ed9b8135 Implement sidebar metadata handling in NewsOverlay 2021-05-19 15:36:05 +03:00
Andrei Zavatski
6cc4ffadab Implement sticky container for sidebar in NewsOverlay 2021-05-19 15:28:12 +03:00
Dean Herbert
0bd1964d8e Add login placeholder logic to OnlineOverlay
A perfect implementation of this would probably leave the filter/header
content visible, but that requires some re-thinking and restructuring to
how the content is displayed in these overlays (ie. the header
component shouldn't be inside the `ScrollContainer` as it is fixed).

Supersedes and closes #10774.
Closes #933.
Addresses most pieces of #7417.
2021-02-18 18:07:24 +09:00
Andrei Zavatski
6e34ab5d15 Rename WebOverlay to OnlineOverlay 2021-01-18 11:13:38 +03:00
Andrei Zavatski
27ffc98445 Implement WebOverlay component 2021-01-18 10:48:12 +03:00
Dean Herbert
54982dcdd7 Refactor LoadingLayer to avoid applying effects to external drawables
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
Dean Herbert
7bcbac6f45 Move header setting to FullscreenOverlay 2020-09-03 16:34:58 +09:00
Dean Herbert
dceae21bbf Centralise fetching of overlay component titles and textures 2020-09-03 16:34:58 +09:00
Dean Herbert
3916d98e52 Add comment for clarity 2020-08-05 18:50:37 +09:00
Andrei Zavatski
af320e4a61 Fix NewsOverlay running request on startup 2020-08-03 10:03:42 +03:00
Andrei Zavatski
598e48678e Refactor NewsHeader 2020-07-12 15:45:48 +03:00
Andrei Zavatski
3ba8ec0fd7 Don't set null value to show front page 2020-07-09 03:40:14 +03:00
Andrei Zavatski
900f2d309b Classes naming adjustments 2020-07-09 01:26:56 +03:00
Andrei Zavatski
0b4213f330 Implement FrontPageDisplay 2020-07-08 20:07:29 +03:00
Andrei Zavatski
49d998c8db Refactor NewsOverlay to use displays logic 2020-07-08 18:24:13 +03:00
Andrei Zavatski
4c5d01a611 Remove unused usings 2020-04-13 12:34:51 +03:00
Andrei Zavatski
b741e359cd Use OverlayScrollContainer for overlays 2020-04-13 12:23:28 +03:00
Andrei Zavatski
fe078c244d Expose TabControlOverlayHeader.Current value 2020-02-04 00:43:04 +03:00
Andrei Zavatski
db4cd51d02 Implement OverlayColourProvider 2020-01-24 12:24:35 +03:00
Lucas A
0a278ef943 Apply review suggestions 2019-12-17 19:23:30 +01:00
Lucas A
88ec0c1486 Add missing async content loading logic to NewsOverlay 2019-12-08 18:49:58 +01:00
Lucas A
4d1b1a4022 Fix CI inspections 2019-08-14 21:52:36 +02:00
Lucas A
840d4741da Add NewsContent class and fix broken reference. 2019-08-14 21:19:59 +02:00
Lucas A
87811afade Add missing licence headers to added files. 2019-08-12 20:16:41 +02:00
Lucas A
b92e331730 Add tabcontrol logic to news overlay 2019-08-10 17:06:52 +02:00
Lucas A
b19c378fc8 Add NewsHeader class 2019-08-10 15:39:13 +02:00
Lucas A
4b0ac381b7 Add visual tests. 2019-08-10 15:39:13 +02:00
Lucas A
e3d52d8d71 Add NewsOverlay class 2019-08-10 15:39:13 +02:00