9218 Commits

• Merge pull request #29712 from bdach/editor/setup-screen-checkbox

  Implement "form" check box control

  Dean Herbert · 2024-09-14 02:26:59 +09:00
  5ea7061d5a
• Limit width of test scene controls

  To better reflect what the widths should be in actual usage.

  Bartłomiej Dach · 2024-09-13 14:54:10 +02:00
  f71ce8869e
• Attempt to address design concerns
  Bartłomiej Dach · 2024-09-13 09:59:20 +02:00
  652a590611
• Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)
  Bartłomiej Dach · 2024-09-11 11:44:59 +02:00
  0e663d1801
• Add failing test case
  Bartłomiej Dach · 2024-09-08 16:06:35 +02:00
  134bcc85b7
• Merge pull request #29714 from Crystallized21/total-participation-tooltip

  Add Total Participation stat to users profile Daily Challenge Tooltip

  Dean Herbert · 2024-09-08 22:42:02 +09:00
  4a6266efcf
• Fix incorrect tiers being used for tooltip total participation display

  Compare: https://github.com/ppy/osu-web/pull/11457/commits/95e4561a54353016f25c3fc859b176038b82088a

  Bartłomiej Dach · 2024-09-08 14:26:50 +02:00
  7f814d3106
• Add failing test case for difficulty splitting
  Dean Herbert · 2024-09-07 22:14:02 +09:00
  3e3ee3757c
• Add failing test coverage
  Bartłomiej Dach · 2024-09-06 13:15:21 +02:00
  7e53df5226
• Implement "form" check box control
  Bartłomiej Dach · 2024-09-06 11:45:13 +02:00
  2c19b7994c
• Merge pull request #29702 from peppy/fix-offset-control-wrong-order

  Fix beatmap offset control not working correctly when calibrating from quitting gameplay

  Bartłomiej Dach · 2024-09-06 09:39:14 +02:00
  925710d9b3
• Add test coverage of beatmap offset edge case failure
  Dean Herbert · 2024-09-05 19:04:52 +09:00
  791ce218fc
• Merge branch 'master' into editor/setup-screen-textbox
  Bartłomiej Dach · 2024-09-05 11:22:10 +02:00
  49b14ad579
• Implement "form" text box control
  Bartłomiej Dach · 2024-09-04 14:09:50 +02:00
  b7a56c8a45
• Merge pull request #29616 from peppy/break-overlay-animation

  Add beat-synced animation to break overlay

  Dean Herbert · 2024-09-04 19:39:35 +09:00
  ca09028b06
• Adjust tests further to match new UX
  Bartłomiej Dach · 2024-09-02 14:46:40 +02:00
  16c2c14037
• Merge branch 'master' into Fabep/master
  Bartłomiej Dach · 2024-09-02 14:35:44 +02:00
  d99b2312cd
• Modify existing test coverage to demonstrate failure with touch
  Bartłomiej Dach · 2024-09-02 11:33:37 +02:00
  10901075be
• Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session

  Show daily challenge intro screen once per session

  Dean Herbert · 2024-09-01 21:27:16 +09:00
  e79604cc13
• Merge pull request #29656 from peppy/provide-api-earlier

  Provide API context earlier to api requests in order to fix missing schedules

  Dean Herbert · 2024-08-30 23:15:28 +09:00
  a09c6e2a25
• Merge pull request #29639 from peppy/detached-beatmap-cache

  Improve song select load and reload with large beatmap databases

  Bartłomiej Dach · 2024-08-30 15:00:20 +02:00
  4811481483
• Fix chat overlay tests

  Not entirely sure why they were failing previously, but the most likely
  explanation is that by freak accident some mock requests would
  previously execute immediately rather than be scheduled on the API
  thread, which would change execution ordering and ensure that
  `ChannelManager.CurrentChannel` would become the joined channel, rather
  than remaining at the channel listing.

  Bartłomiej Dach · 2024-08-30 14:57:15 +02:00
  8b04455c29
• Merge branch 'master' into master
  Fabian Bech Persson · 2024-08-30 11:06:54 +02:00
  363fc0d5da
• Merge pull request #28737 from OliBomby/doubleclick

  Add more ways to seek to sample points

  Dean Herbert · 2024-08-30 16:22:50 +09:00
  a71bc3a24a
• Merge pull request #29440 from OliBomby/spacebar-resume

  Allow play/pause with spacebar while placing hitobjects

  Dean Herbert · 2024-08-30 12:58:41 +09:00
  60c1e0fa72
• fix test
  OliBomby · 2024-08-29 22:22:15 +02:00
  3a1afda2b3
• Merge remote-tracking branch 'upstream/master' into doubleclick
  OliBomby · 2024-08-29 19:34:18 +02:00
  ba0c4df2a9
• Merge branch 'master' into detached-beatmap-cache
  Dean Herbert · 2024-08-29 22:49:11 +09:00
  c013974790
• Merge pull request #29533 from bdach/fix-sample-bank-stuff-again

  Fix incorrect bank set / sample addition logic

  Dan Balasescu · 2024-08-29 21:36:26 +09:00
  fec8fa46fa
• Fix some tests not always waiting long enough for beatmap loading

  These used to work because there was a huge blocking load operation,
  which is now more asynchronous.
  
  Note that the change made in `SongSelect` is not required, but defensive
  (feels it should have been doing this the whole time).

  Dean Herbert · 2024-08-29 18:42:43 +09:00
  def1abaeca
• Add failing pinned comment replies state test
  Joseph Madamba · 2024-08-28 22:58:57 -07:00
  f0b2176c30
• Tidy up test beatmap loading
  Dean Herbert · 2024-08-28 23:28:44 +09:00
  e04b5bb3f2
• Reduce test filter count expectation by one due to initial filter being implicit
  Dean Herbert · 2024-08-28 23:28:44 +09:00
  853023dfba
• Fix multiple test failures
  Dean Herbert · 2024-08-28 23:28:43 +09:00
  9123d2cb7f
• Always debounce external Filter requests (except for tests)

  The only exception to the rule here was "when screen isn't active apply
  without debounce" but I'm not sure we want this. It would cause a
  stutter on returning to song select and I'm not even sure this is a
  common scenario.
  
  I'd rather remove it and see if someone finds an actual case where this
  is an issue.

  Dean Herbert · 2024-08-28 19:13:50 +09:00
  dd4a1104e4
• Allow running initial filter criteria asynchronously

  This reverts a portion of https://github.com/ppy/osu/pull/9539.
  
  The rearrangement in `SongSelect` is required to get the initial filter
  into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
  causing a delayed/scheduled filter application).

  Dean Herbert · 2024-08-28 19:13:50 +09:00
  336abadbd1
• Changed ModCustomisationPanelState names
  Fabep · 2024-08-28 10:09:47 +02:00
  6adaf6a41f
• Merge branch 'master' into break-overlay-animation
  Bartłomiej Dach · 2024-08-27 11:17:56 +02:00
  a3b0ff4808
• Merge pull request #29615 from peppy/break-overlay-improvements

  Add shadow around break overlay middle content to make sure it remains visible

  Bartłomiej Dach · 2024-08-27 11:16:08 +02:00
  321e509f11
• Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time

  Fix oversight in osu! pause input handling

  Bartłomiej Dach · 2024-08-27 10:04:47 +02:00
  7c0550d251
• Fix test and NRT failure
  Bartłomiej Dach · 2024-08-27 09:49:49 +02:00
  e59689f31a
• Add beat-synced animation to break overlay

  I've been meaning to make the progress bar synchronise with the beat
  rather than a continuous countdown, just to give the overlay a bit more
  of a rhythmic feel.
  
  Not completely happy with how this feels but I think it's a start?
  
  I had to refactor how the break overlay works in the process. It no
  longer creates transforms for all breaks ahead-of-time, which could be
  argued as a better way of doing things. It's more dynamically able to
  handle breaks now (maybe useful for the future, who knows).

  Dean Herbert · 2024-08-27 16:34:37 +09:00
  6f1664f0a6
• Fix TestSceneBreakTracker not removing old drawables

  Also adds a bright background for testing overlay display.

  Dean Herbert · 2024-08-27 14:33:36 +09:00
  c2c83fe73d
• Add DailyChallengeButton for intro played flag reset logic
  Salman Ahmed · 2024-08-24 22:19:17 +09:00
  b54487031a
• Fix Daily Challenge play count using a different colour than osu-web
  Jonas Brandstötter · 2024-08-24 11:21:28 +02:00
  89a4025c01
• Remove existing test asserts
  Salman Ahmed · 2024-08-24 06:40:30 +09:00
  f5e195a7ee
• Merge pull request #29564 from peppy/skinnable-components-what-2

  Remove requirement of `base` calls to ensure user skin container layouts are retrieved

  Dean Herbert · 2024-08-23 17:52:46 +09:00
  60271fb0f7
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Merge pull request #29512 from peppy/toolbar-pp-change-weird

  Fix toolbar PP change showing `+0` instead of `0`

  Bartłomiej Dach · 2024-08-22 12:08:12 +02:00
  a32a817305
• Rename Target lookup to Component
  Dean Herbert · 2024-08-22 19:00:28 +09:00
  b57b8168a6