74132 Commits

This Branch

This Branch

All Branches

• Move external skin edit overlay out of OsuGame
  Bartłomiej Dach · 2025-07-01 11:23:55 +02:00
  2c22158dbd
• Fix dodgy threading

  The fact that the stuff "just worked" previously due to one load-bearing
  detach in a random location is really scary because a lot of this was
  just not written the way it is supposed to be.

  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  2e0e7ff3c2
• Fix error code paths just completely falling apart

  You can't hide a drawable outside of update thread.

  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  5fb0449569
• Prevent hiding skin editor during external edit operation
  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  17cfa7fcf3
• Ensure pending changes are saved before initiating external edit operation
  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  f63dc2dcea
• Use better method of disallowing skin changes during external edit
  Bartłomiej Dach · 2025-06-30 14:17:27 +02:00
  b82bf228ab
• Eliminate weird parameter passing
  Bartłomiej Dach · 2025-06-30 12:59:37 +02:00
  bccdf42133
• Move external edit overlay to more proper namespace
  Bartłomiej Dach · 2025-06-30 12:54:16 +02:00
  a95987aadf
• Merge branch 'master' into skin-mounting
  Bartłomiej Dach · 2025-06-30 12:53:55 +02:00
  368850967b
• Merge pull request #33959 from frenzibyte/remove-unnecessary-tooltips

  Remove unnecessary skin settings descriptions

  Bartłomiej Dach · 2025-06-30 12:38:32 +02:00
  cc323bbeb7
• Merge pull request #33958 from peppy/fix-player-settings-stuck-oh-nooooooo

  Fix player settings no longer collapsing correctly

  Bartłomiej Dach · 2025-06-30 12:30:13 +02:00
  0877ca58c1
• Merge pull request #33957 from peppy/song-select-v2-fix-random-sample

  Improve random button sound effects

  Bartłomiej Dach · 2025-06-30 12:12:30 +02:00
  5b521f7097
• Fix typo
  Bartłomiej Dach · 2025-06-30 11:03:06 +02:00
  a8e3ce9af1
• Remove unnecessary skin settings descriptions
  Salman Alshamrani · 2025-06-30 12:00:21 +03:00
  2b92b59504
• Fix player settings no longer collapsing correctly

  Regressed with https://github.com/ppy/osu/pull/33621 for obvious
  reasons. Tachyon doing its job, caught this before hitting a proper
  release.

  Dean Herbert · 2025-06-30 16:57:51 +09:00
  d1c0d58f2e
• Refactor distance-between-panels implementation

  The new version wasn't really working as expected, because the Y
  position measurement only considered visible panels, while it was being
  divided over all panels (including non-expanded groups or sets).
  
  Rather than trying to divide across all panels, just choose a sane
  number for the "highest pitch" sound and work with that as a constant.

  Dean Herbert · 2025-06-30 16:21:41 +09:00
  d7b7640055
• Play error sound when random selection fails
  Dean Herbert · 2025-06-30 16:20:32 +09:00
  bf8b6754dc
• Fix random sound effect not playing correctly
  Dean Herbert · 2025-06-30 16:09:23 +09:00
  9155f566ec
• Merge pull request #33670 from bdach/ensure-replays-are-played-to-end

  Ensure partial failed replays are played to their end

  Dean Herbert · 2025-06-30 15:56:13 +09:00
  768d44596a
• Merge pull request #33908 from bdach/custom-sample-bank-buggery

  Fix beatmap skin sample lookups falling back to non-custom sample banks if the custom bank sample was not found

  Dean Herbert · 2025-06-30 14:32:21 +09:00
  95237ed531
• Fix flaky TestSceneGameplaySamplePlayback test

  See: https://github.com/ppy/osu/actions/runs/15924307907/job/44920278903
  
  Similar null-checks within `Update()` are present in the
  `PlayerTestScene` superclass.

  Dan Balasescu · 2025-06-29 00:24:12 +09:00
  5c89644d58
• Merge pull request #33909 from bdach/no-pp-for-fails

  Explicitly explain to users that failed plays do not give pp on results screen

  Dean Herbert · 2025-06-28 22:38:57 +09:00
  ac28cc30b4
• Merge pull request #33906 from smoogipoo/fix-intermittent-test
  Dean Herbert · 2025-06-28 17:50:10 +09:00
  1e217064ae
• Adjust tests to pass (and add test coverage of fail case)
  Bartłomiej Dach · 2025-06-27 14:07:00 +02:00
  edafac2aaa
• Explicitly explain to users that failed plays do not give pp on results screen

  Addresses https://osu.ppy.sh/community/forums/topics/2096912.

  Bartłomiej Dach · 2025-06-27 13:24:45 +02:00
  360ba548dc
• Fix beatmap skin sample lookups falling back to non-custom sample banks if the custom sample bank sample was not found

  Closes https://github.com/ppy/osu/issues/33900. I think. Stable's sample
  lookup logic is horrible.
  
  The user in the issue claimed they were hearing `drum-hitfinish2`, but
  they were really hearing `drum-hitfinish`, because they're the same
  `.wav` file in the beatmap. Now the reason *why* they were hearind
  `drum-hitfinish` is that the sample control point was specifying
  something like:
  
  	23946,-200,4,2,4,40,0,0
  
  To decipher, this is:
  - default sample bank of soft
  - custom sample bank of 4
  
  Taking one of the objects affected, namely 00:23:946 (2) - that's a
  slider with finish addition and drum addition bank on the slider head.
  The slider head is thus attempting to play `soft-hitnormal4` and
  `drum-hitfinish4`.
  
  Neither `soft-hitnormal4` or `soft-hitnormal` exist in the beatmap, so
  that plays fine via falling back to user skin's `soft-hitnormal`, but
  `drum-hitfinish4` ends up falling back to `drum-hitfinish` which *does*
  exist in the beatmap skin and thus plays wrongly from the beatmap skin
  rather than the user skin.
  
  I have no idea how to ensure this is correct across every beatmap and
  skin out there so my approach is to just spray and pray (and rely on
  issue reports I guess). I *think* this matches the stable logic which is
  nestled within
  https://github.com/peppy/osu-stable-reference/blob/a5e5fe6ef240505d13526cf32783cad261e9bd8b/osu!/Audio/AudioEngine.cs#L1136-L1230
  but honestly if you put a gun to my head I couldn't be sure if it
  matches completely in every possible circumstance or not.

  Bartłomiej Dach · 2025-06-27 13:00:50 +02:00
  c7cd3a9842
• Fix flaky tests due to async disposal
  Dan Balasescu · 2025-06-27 19:43:26 +09:00
  c53a7aa2fc
• Merge pull request #33904 from smoogipoo/fix-update-lag

  Fix lag when checking for update

  Dean Herbert · 2025-06-27 19:38:03 +09:00
  7cc20b2899
• Fix lag when checking for update
  Dan Balasescu · 2025-06-27 17:19:11 +09:00
  52fad81371
• Merge pull request #33888 from frenzibyte/font-weight

  Allow changing weight in `TextElement` and similar skin elements

  Dean Herbert · 2025-06-27 17:11:42 +09:00
  2161d911ea
• Remove pointless tooltip

  I agree that these are pointless and we should probably remove the
  others and stop wasting localiser's time on these.

  Dean Herbert · 2025-06-27 17:09:29 +09:00
  5485abd3a5
• Attempt to fix flaky test TestExitWithHoldDisabled

  See
  https://github.com/ppy/osu/actions/runs/15915618971/job/44892620536#step:5:203.
  
  Note that the `DialogOverlay` only finishes loading after the until step
  failure.

  Dean Herbert · 2025-06-27 14:32:58 +09:00
  e713a68c49
• Merge pull request #33898 from frenzibyte/fix-potential-nre

  Fix potential null reference in `RoomNameLine`

  Dean Herbert · 2025-06-27 14:08:49 +09:00
  b95c50369d
• Fix potential null reference in RoomNameLine
  Salman Alshamrani · 2025-06-27 03:52:09 +03:00
  3dbb1e15b6
• Remove font weight localisation
  Salman Alshamrani · 2025-06-27 00:58:10 +03:00
  cd354a0de8
• Merge pull request #33615 from bdach/slider-encode-decode-instability

  Fix lack of slider encode-decode stability due to truncating control point coordinates on decode

  Dan Balasescu · 2025-06-26 23:25:36 +09:00
  ae3100af11
• Merge pull request #33858 from frenzibyte/multiplayer-match-link

  Add external link button to multiplayer/playlists room panels

  Dan Balasescu · 2025-06-26 23:16:05 +09:00
  bc07aba692
• Merge pull request #33883 from smoogipoo/add-test

  Add test hitting next circle during tail window

  Dan Balasescu · 2025-06-26 23:04:56 +09:00
  548b442507
• Support changing weight in text-based elements
  Salman Alshamrani · 2025-06-26 07:36:11 +03:00
  fa508245a1
• Add test coverage
  Salman Alshamrani · 2025-06-26 03:03:22 +03:00
  3ac557907e
• Simplify code and fix link not updating on changes to room ID
  Salman Alshamrani · 2025-06-26 03:03:22 +03:00
  8b67747735
• Move room URL formatting to extension method
  Salman Alshamrani · 2025-06-26 02:56:43 +03:00
  75a3cdcfe2
• Simplify important frame management
  Dan Balasescu · 2025-06-25 21:50:04 +09:00
  5dc08d4351
• Add test hitting next circle during tail window
  Dan Balasescu · 2025-06-25 21:20:00 +09:00
  5d69af55f0
• Merge pull request #33880 from bdach/user-tag-reorders

  Fix user tags moving in the control after voting

  Dean Herbert · 2025-06-25 20:55:21 +09:00
  5a01b76c35
• Merge pull request #33881 from smoogipoo/remove-dead-code

  Remove no longer used method

  Dan Balasescu · 2025-06-25 19:21:17 +09:00
  c80a63f328
• Merge pull request #33879 from peppy/selection-debounce-refactor

  Rewrite and add commentary to selection debounce logic

  Bartłomiej Dach · 2025-06-25 11:42:39 +02:00
  5c00985fa9
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Merge pull request #33875 from bdach/hitwindow-refactor

  Refactor hit windows class structure to reduce rigidity

  Dan Balasescu · 2025-06-25 18:22:01 +09:00
  09e31b7b01
• Fix user tags moving in the control after voting

  Closes https://github.com/ppy/osu/issues/33877.
  
  Most likely regressed when the user tags were changed such that the
  loading spinner that shows on adding/removing a vote was introdiced to
  every individual tag separately. This in turn means that the
  `LoadingLayer` responsible for showing the spinner also briefly consumes
  all input when visible, which also means that the control briefly
  becomes unhovered, breaking the logic.
  
  This probably doesn't work on mobile because mobile input sucks. On iOS
  simulator it looks somewhat fine in that the tags don't move until you
  touch the screen anywhere else which seems okay if that's what actually
  what happens on device as well. And if it isn't I'm not sure I can do
  anything sane about it anyway.

  Bartłomiej Dach · 2025-06-25 11:16:18 +02:00
  7975120d5d