1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-21 21:00:42 +08:00

Fix error code paths just completely falling apart

You can't hide a drawable outside of update thread.
This commit is contained in:
Bartłomiej Dach
2025-06-30 13:47:13 +02:00
Unverified
parent 17cfa7fcf3
commit 5fb0449569
@@ -115,10 +115,9 @@ namespace osu.Game.Overlays.SkinEditor
catch (Exception ex)
{
Logger.Log($"Failed to initialize external edit operation: {ex}", LoggingTarget.Database, LogLevel.Error);
Schedule(() => showSpinner("Export failed!"));
await Task.Delay(1000).ConfigureAwait(true);
setGlobalSkinDisabled(false);
Hide();
Schedule(() => showSpinner("Export failed!"));
Scheduler.AddDelayed(Hide, 1000);
return Task.FromException(ex);
}
@@ -195,8 +194,7 @@ namespace osu.Game.Overlays.SkinEditor
{
Logger.Log($"Failed to finish external edit operation: {ex}", LoggingTarget.Database, LogLevel.Error);
showSpinner("Import failed!");
await Task.Delay(1000).ConfigureAwait(true);
Hide();
Scheduler.AddDelayed(Hide, 1000);
setGlobalSkinDisabled(false);
taskCompletionSource.SetException(ex);
taskCompletionSource = null;