38360 Commits

This Branch

This Branch

All Branches

• Add audio quality check tests
  Naxess · 2021-04-20 01:36:15 +02:00
  2bb079ea14
• Add audio quality check
  Naxess · 2021-04-20 01:36:03 +02:00
  c633f15565
• Add Track as a property to IWorkingBeatmap

  This is implemented by `WorkingBeatmap` already, and is much better to use than loading the track every time we need it.

  Naxess · 2021-04-20 01:35:41 +02:00
  f168247254
• Show 2 decimals for background filesize
  Naxess · 2021-04-20 01:34:05 +02:00
  40ae856dfc
• Use the playable beatmap for file presence checks
  Naxess · 2021-04-20 01:33:19 +02:00
  14c626ffcb
• Simplify background quality test names
  Naxess · 2021-04-20 01:32:22 +02:00
  be6a02a17e
• Add the playable beatmap as check argument

  This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
  
  So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
  
  This should be preferred over `workingBeatmap.Beatmap`.

  Naxess · 2021-04-20 01:31:51 +02:00
  8656176ab8
• Add audio presence check
  Naxess · 2021-04-18 02:07:57 +02:00
  9a69ca34a6
• Factor out general file presence checking

  This allows us to use the same method of checking for other files that should exist, for example the audio file.
  
  By using the same method, they all share test cases too.

  Naxess · 2021-04-18 02:07:33 +02:00
  010720de74
• Add background quality check tests
  Naxess · 2021-04-18 01:21:51 +02:00
  0502fbb429
• Take IWorkingBeatmap instead of WorkingBeatmap

  This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.

  Naxess · 2021-04-18 01:21:20 +02:00
  56bf49c85c
• Clean up check logic

  Makes use of the new `BeatmapSet.GetPathForFile` method and removes dependency on `WorkingBeatmap` specifically, allowing us to switch to `IWorkingBeatmap` later.

  Naxess · 2021-04-18 01:19:25 +02:00
  abf512532e
• Fix resolved fields
  Naxess · 2021-04-18 01:15:13 +02:00
  ef65c8910f
• Add GetStream to IWorkingBeatmap
  Naxess · 2021-04-18 01:13:57 +02:00
  bf8789528a
• Don't return low res and too low res at the same time
  Naxess · 2021-04-17 20:10:07 +02:00
  cb41c89935
• Add check for background resolution and filesize
  Naxess · 2021-04-17 18:01:04 +02:00
  62c54e00cb
• Add GetPathForFile to BeatmapSetInfo

  This is used in several places, and so should probably have a function rather than remaining as duplicated code.
  
  Also applies this together with the previous commit to `BeatmapManagerWorkingBeatmap`.

  Naxess · 2021-04-17 17:49:10 +02:00
  b36da2664c
• Add GetStream to IWorkingBeatmap

  This is necessary to obtain the filesize of the audio and background files.

  Naxess · 2021-04-17 17:47:13 +02:00
  400f8b3938
• Use WorkingBeatmap instead of IBeatmap

  This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
  
  Also improves the structure of the `CheckBackgroundTest` class in the process.

  Naxess · 2021-04-17 17:33:53 +02:00
  448574e7e6
• Merge pull request #12460 from bdach/fix-idle-tracker-assumption
  Bartłomiej Dach · 2021-04-17 15:31:54 +02:00
  1832f624e2
• Adjust tests to not rely on invalid assumption
  Bartłomiej Dach · 2021-04-17 14:23:32 +02:00
  f3ea51eeed
• Fix idle tracker assuming time starts at 0

  `IdleTracker` in its construction quietly assumed that the clock it
  receives from its parent starts ticking from 0 at the point at which it
  is passed down. This is not necessarily the case when headless
  executions are involved, which means that the initial state of the
  tracker could be computed as idle incorrectly.
  
  Resolve by explicitly reading the clock time at the point of
  `LoadComplete()`.

  Bartłomiej Dach · 2021-04-17 13:50:00 +02:00
  250c7403e8
• Merge pull request #12456 from frenzibyte/improve-br-tooltip

  Improve "barrel roll" mod settings description

  Dean Herbert · 2021-04-17 13:19:24 +09:00
  3eb2fb7e89
• Add space before the unit

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Salman Ahmed · 2021-04-17 06:28:07 +03:00
  c1082ddb9a
• Remove unnecessary comma
  Salman Ahmed · 2021-04-17 04:23:48 +03:00
  892a8a7cd2
• Remove unused using directive

  gotta git gud

  Salman Ahmed · 2021-04-17 03:52:08 +03:00
  78c8508784
• Improve "barrel roll" mod settings description
  Salman Ahmed · 2021-04-17 03:32:47 +03:00
  d5a1e00feb
• Empty commit
  Dean Herbert · 2021-04-17 00:56:53 +09:00
  2021.416.0 dc899515ec
• Merge pull request #12444 from peppy/fix-slider-zero-length

  Avoid all scenarios where sliders can become zero length

  Dan Balasescu · 2021-04-16 19:33:35 +09:00
  1f577ce566
• Merge pull request #12445 from peppy/show-selected-objects-in-timeline

  Add border showing selected blueprints in timeline

  Dan Balasescu · 2021-04-16 19:22:04 +09:00
  a1787d3819
• Fix test going offscreen in headless execution
  Dean Herbert · 2021-04-16 18:54:33 +09:00
  b413ffae3e
• Merge branch 'master' into fix-slider-zero-length
  Dean Herbert · 2021-04-16 18:47:22 +09:00
  f824105075
• Merge pull request #12440 from smoogipoo/apply-ibindable-interface-change

  Apply changes resulting from IBindable interface updates

  Dean Herbert · 2021-04-16 18:37:47 +09:00
  473ff7c020
• Add border showing selected blueprints in timeline
  Dean Herbert · 2021-04-16 18:16:22 +09:00
  d9d50f0e88
• Merge pull request #12443 from peppy/fix-slider-scale-crash

  Fix div-by-zero when scaling a 1-dimensional slider

  Dan Balasescu · 2021-04-16 17:31:42 +09:00
  7648d6f7fb
• Update framework
  Dean Herbert · 2021-04-16 17:30:39 +09:00
  fbf7d838da
• Merge branch 'master' into apply-ibindable-interface-change
  Dean Herbert · 2021-04-16 17:30:35 +09:00
  9b95cf227e
• Merge pull request #12442 from smoogipoo/fix-match-subscreen-test

  Attempt to fix match subscreen test failure

  Dean Herbert · 2021-04-16 17:29:58 +09:00
  0030b2dde6
• Merge pull request #12439 from ekrctb/further-refactor-framed-replay

  Further refactor FrameReplayInputHandler, simplify the template code

  Dan Balasescu · 2021-04-16 17:16:09 +09:00
  5ad2d0e759
• Merge pull request #12441 from peppy/fix-potential-deselection-crash

  Fix an occasional crash when deleting a HitObject via internal means

  Dan Balasescu · 2021-04-16 17:15:52 +09:00
  b8d5839baf
• Add test coverage of selection / scaling scenarios
  Dean Herbert · 2021-04-16 17:07:20 +09:00
  30e00cc4aa
• Merge branch 'fix-slider-scale-crash' into fix-slider-zero-length
  Dean Herbert · 2021-04-16 16:58:19 +09:00
  401bf368a7
• Fix div-by-zero when scaling a 1-dimensional slider
  Dean Herbert · 2021-04-16 16:55:26 +09:00
  8de68e0ebf
• Add failing test case due to div by zero
  Dean Herbert · 2021-04-16 16:55:17 +09:00
  ab1a1a1df4
• Merge branch 'master' into fix-potential-deselection-crash
  Dan Balasescu · 2021-04-16 16:27:47 +09:00
  3c8e2b8b32
• Merge pull request #12437 from peppy/fix-editor-placement-commit-false

  Fix placement blueprints not being correctly removed after a rolled back placement

  Dan Balasescu · 2021-04-16 16:25:05 +09:00
  d3acbcced7
• Attempt to fix match subscreen test failure
  smoogipoo · 2021-04-16 16:16:28 +09:00
  25f0f17766
• Fix an occasional crash when deleting a HitObject via internal means
  Dean Herbert · 2021-04-16 15:55:33 +09:00
  c59906e925
• Handle scaling a slider below minimum length
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  ff408b852e
• Handle control point deletion when the resulting slider would be too short to be useful
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  89373638be