Bartłomiej Dach
2aa4481f68
Fix toolbox items spontaneously contracting after briefly losing hover
...
Reproduction scenario:
1. Hover a toolbox item
2. Unhover the item, but do not hover any other item (can be done by
exiting the toolbox completely to the right)
3. Come back to the item hovered in step (1)
4. The item would spontaneously contract after a second
2023-02-17 22:54:11 +01:00
Dean Herbert
5ed038fbb3
Improve the feel of hovering toolbox component items
2023-02-17 19:26:03 +09:00
Bartłomiej Dach
9f9893d93a
Merge pull request #22338 from Pasi4K5/hide-resume-overlay
...
Hide `ResumeOverlay` when `OsuModAutopilot` is enabled
2023-02-16 22:22:19 +01:00
Bartłomiej Dach
66e9bb2581
Merge branch 'master' into hide-resume-overlay
2023-02-16 21:33:23 +01:00
Bartłomiej Dach
bba1722725
Merge pull request #22645 from peppy/adjust-song-select-background-dim
...
Adjust song select background dimming to be more evenly applied
2023-02-16 21:27:27 +01:00
Bartłomiej Dach
b8084a15eb
Revert ResumeOverlay
setter accessibility change
2023-02-16 21:26:01 +01:00
Bartłomiej Dach
0186062246
Merge branch 'master' into adjust-song-select-background-dim
2023-02-16 20:52:36 +01:00
Bartłomiej Dach
ad5132ed41
Remove redundant conditional access qualifier
...
It is impossible for the callback passed to `ApplyToBackground()` to
receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
background to call the callback on were `null`, then an
`InvalidOperationException` would be thrown instead.
2023-02-16 20:47:51 +01:00
Bartłomiej Dach
7d86f49fce
Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix
...
Refactor `GameplaySampleTriggerSource` test to not be realtime dependent
2023-02-16 19:39:18 +01:00
Bartłomiej Dach
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
Dean Herbert
394d368f16
Fix song select potentially updating background parameters when not the current screen
2023-02-16 18:45:22 +09:00
Dean Herbert
979c079f8b
Refactor GameplaySampleTriggerSource
test to not be realtime dependent
2023-02-16 17:58:44 +09:00
Dean Herbert
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource
tests
2023-02-16 17:58:44 +09:00
Dean Herbert
ce9ef3bc3c
Always create ResumeOverlay
, with UseResumeOverlay
flag only affecting whether it is displayed or not
2023-02-16 15:47:20 +09:00
Dean Herbert
7afdcb9383
Merge branch 'master' into hide-resume-overlay
2023-02-16 15:42:14 +09:00
Bartłomiej Dach
87901bc8b1
Merge pull request #22292 from ekrctb/maximum-judgement-offset-in-hit-object
...
Move MaximumJudgementOffset to HitObject
2023-02-16 00:52:35 +01:00
Bartłomiej Dach
c315113fde
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-16 00:15:51 +01:00
Bartłomiej Dach
1d5d34ba0e
Merge pull request #22647 from peppy/remove-target-component-container
...
Simplify and rename `SkinnableTargetComponentsContainer`
2023-02-15 21:25:49 +01:00
Bartłomiej Dach
455fb7789c
Merge pull request #22646 from peppy/fix-skin-export-matching-directory
...
Fix exports failing if a directory exists with the proposed filename
2023-02-15 19:04:15 +01:00
Dean Herbert
d9b4d932c9
Fix test container lookup failure
2023-02-15 17:47:34 +09:00
Dean Herbert
ca75f0ec77
Apply NRT to TestSceneBeatmapSkinFallbacks
2023-02-15 17:30:21 +09:00
Dean Herbert
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
Dean Herbert
e71dfd7555
Fix skin export failing if a directory exists with the proposed filename
2023-02-15 16:11:16 +09:00
Dean Herbert
da8ab7143b
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-15 14:48:15 +09:00
Dean Herbert
9ed068c1e6
Only apply dim changes when background blur is disabled
2023-02-15 14:16:34 +09:00
Dean Herbert
19e3c5d33c
Adjust song select background dimming to be more evenly applied
2023-02-15 13:59:24 +09:00
Bartłomiej Dach
24961d1ac0
Merge pull request #22599 from peppy/fix-mania-long-note-regression
...
Fix osu!mania long notes not displaying correctly since recent update
2023-02-14 22:14:08 +01:00
Bartłomiej Dach
99b78c63a0
Merge branch 'master' into fix-mania-long-note-regression
2023-02-14 21:25:31 +01:00
Dean Herbert
e6f0a1dec9
Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress
...
Fix beatmap card song preview progress sometimes showing past progress for one frame
2023-02-14 17:06:50 +09:00
Dean Herbert
215049a5f3
Merge pull request #22629 from Cootz/SkinSetOnNotificationClick
...
Select skin by clicking on an import notification
2023-02-14 17:06:35 +09:00
Dean Herbert
0217875f3f
Merge branch 'master' into SkinSetOnNotificationClick
2023-02-14 16:04:03 +09:00
Dean Herbert
0ad245e9e0
Rewrite implementation to match other implementations
2023-02-14 16:00:23 +09:00
Dean Herbert
21429e164f
Fix comment grammar
2023-02-14 15:55:32 +09:00
PC
ca2603324c
Change present from skin selection tab to SkinCollection.First()
2023-02-14 09:43:40 +03:00
Joseph Madamba
ea624b8ad0
Reset preview track when stopping instead
2023-02-13 22:39:34 -08:00
Dean Herbert
808d454939
Merge pull request #21491 from mk56-spn/footer_V2_implementation
...
New song select footer design implementation
2023-02-14 15:22:56 +09:00
Dean Herbert
63f3498762
Restructure UseResumeOverlay
to correctly handle a value change before BDL load
2023-02-14 15:11:33 +09:00
Dean Herbert
9e04a36d86
Move test to a mod test and add more resilient test logic
2023-02-14 15:07:45 +09:00
Dean Herbert
bd8c58dc62
Adjust applied body ratio to ROUGHLY match stable
2023-02-14 14:34:12 +09:00
PC
9064391226
Use ChildrenOfType
instead of linq
2023-02-14 08:24:03 +03:00
Dean Herbert
51d4ae5241
Merge branch 'master' into footer_V2_implementation
2023-02-14 14:00:53 +09:00
Dean Herbert
f0ebb920b9
Make Action
s nullable
2023-02-14 13:54:00 +09:00
Dean Herbert
4431f828f5
Merge pull request #22633 from Joehuu/fix-nested-element-sounds
...
Fix `OsuClickableContainer` sounds not being blocked by nested drawables
2023-02-14 13:40:19 +09:00
Joseph Madamba
24a5a1061f
Fix OsuClickableContainer
sounds not being blocked by nested drawables
2023-02-13 15:36:17 -08:00
PC
f8f485e4c8
Move PresentSkinsImport
to OsuGame
. Replace switch with if statement
2023-02-14 02:29:50 +03:00
MK56
5006dbe3db
Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-14 00:07:02 +01:00
Pasi4K5
a820c0c8eb
Add TestSceneInstantResume
2023-02-13 23:55:13 +01:00
Bartłomiej Dach
939144fb6c
Merge pull request #22628 from EVAST9919/letterbox-no-containers
...
Remove unnecessary containers in `LetterboxOverlay`
2023-02-13 23:54:48 +01:00
Pasi4K5
e4b84ebd0b
Add UseResumeOverlay
and use it for hiding the ResumeOverlay
2023-02-13 23:51:39 +01:00
Joseph Madamba
7f7e72705f
Fix beatmap card song preview progress sometimes showing past progress for one frame
2023-02-13 14:15:37 -08:00