Salman Ahmed
26839f6ad8
Consider OnlineIDs during ruleset equality if available
...
Required for `APIBeatmap`s, which provide `Ruleset` instances with `OnlineID` available only.
Also consistent with the comparer implementation.
2022-02-11 04:26:58 +03:00
Salman Ahmed
1b729e891d
Update pointless CompareTo implementation once again
2022-02-11 04:17:30 +03:00
Salman Ahmed
9574bc1382
Allow IRulesetInfos of same type to be comparable
...
At first I was planning on making `CompareTo` implemented at
`IRulesetInfo` itself and shared across classes, but turns out it only
implements it explicitly and not allow direct `IRulesetInfo.Equals`
calls.
It messed with my head enough that I decided to just let each class have
its own implementation and only allow same type.
2022-02-11 04:03:23 +03:00
Salman Ahmed
481003fe38
Merge pull request #16849 from peppy/update-resources
2022-02-10 20:34:44 +03:00
Dean Herbert
2939bc4644
Update resources
2022-02-11 01:49:52 +09:00
Dean Herbert
eda213e4de
Merge pull request #16827 from smoogipoo/spectator-state-rework
...
Add user state to SpectatorState, allowing multiplayer to continue to results
2022-02-11 01:48:47 +09:00
Dan Balasescu
015ec0b88a
Merge pull request #16844 from peppy/migration-delete-fail-gracefully
...
Allow game folder migration to fail gracefully when cleanup cannot completely succeed
2022-02-10 22:41:36 +09:00
Dean Herbert
19cb8cb03a
Update tests
2022-02-10 19:35:28 +09:00
Dean Herbert
44f2d8a448
Allow game folder migration to fail gracefully when cleanup cannot completely succeed
2022-02-10 19:30:26 +09:00
Dan Balasescu
7081c418dd
Merge pull request #16842 from peppy/migration-error-output
...
Fix migration errors not outputting the call stack to logs
2022-02-10 16:31:14 +09:00
Dean Herbert
88bb9d4237
Fix migration errors not outputting the call stack to logs
2022-02-10 15:50:03 +09:00
Dan Balasescu
4dab42362e
Merge pull request #16838 from peppy/update-fastlane-souyuz
...
Update fastlane to latest release
2022-02-10 15:01:30 +09:00
Dan Balasescu
ebd105422f
Remove unused using
2022-02-10 14:22:08 +09:00
Dan Balasescu
f7fb7825cc
Simplify disposal
2022-02-10 14:21:51 +09:00
Dan Balasescu
a3896a8ebd
Remove allowance of null dependency
2022-02-10 14:21:50 +09:00
Dean Herbert
f47748591a
Update fastlane to latest release
...
This pulls in the fix from souyuz to allow us to bring things up-to-date
again (see https://github.com/voydz/souyuz/pull/36#event-6033249116 ).
Have tested builds locally to work as expected.
2022-02-10 12:12:14 +09:00
Dean Herbert
b9655dd1d2
Merge pull request #16832 from hlysine/ruleset-templates-improvements
2022-02-10 01:38:08 +09:00
Henry Lin
036d17d9fd
Remove licence headers
2022-02-09 20:48:14 +08:00
Henry Lin
d06d584867
Change assembly titles
...
So that they match the source name specified in template.json and can get replaced
2022-02-09 19:56:32 +08:00
Henry Lin
f1c6fdb2af
Update .editorconfig, .gitignore and DotSettings
...
Basically just copied from root directory
2022-02-09 19:53:34 +08:00
Henry Lin
1b8ada087d
Set NoDefaultExcludes to true
...
This allows files such as .editorconfig and .gitignore to be included in the nupkg
2022-02-09 19:25:51 +08:00
Dan Balasescu
18251c9285
Clean up SpectatorScreen based on suggestions
2022-02-09 12:20:07 +09:00
Dan Balasescu
ffc4c64f7e
Unify namings across the board
2022-02-09 12:10:07 +09:00
Dan Balasescu
4966c4e974
Remove redundant parameter
2022-02-09 11:51:47 +09:00
Dan Balasescu
54b41181d6
Merge pull request #16830 from peppy/fix-playlist-selection-crash
...
Fix playlist overlay crash when pressing enter with no selection
2022-02-09 10:48:51 +09:00
Dean Herbert
c242a63b11
Fix playlist overlay null reference when attempting an empty selection
...
As reported at https://github.com/ppy/osu/discussions/16829 .
2022-02-09 10:16:45 +09:00
Dan Balasescu
886d1d2df6
Refactorings
2022-02-08 21:29:43 +09:00
Dean Herbert
2dcb726581
Merge pull request #16826 from smoogipoo/fix-beatmap-availability-check
...
Fix comparison leading to incorrect beatmap availabilities
2022-02-08 21:01:13 +09:00
Dean Herbert
79d1d54e33
Rename parameter to match other usages
2022-02-08 20:35:38 +09:00
Dan Balasescu
c1766d8a41
Add paused state
2022-02-08 20:29:53 +09:00
Dan Balasescu
4c76027178
Rename completed state to passed
2022-02-08 20:29:49 +09:00
Dan Balasescu
0d99017178
Add state tests
2022-02-08 20:27:08 +09:00
Dan Balasescu
45b3f472ab
Merge branch 'master' into spectator-state-rework
2022-02-08 19:51:50 +09:00
Dan Balasescu
b1a73996ba
Fix incorrect check for beatmap availability
2022-02-08 19:36:42 +09:00
Dan Balasescu
9c2d57d707
Add failing test
2022-02-08 19:36:16 +09:00
Dean Herbert
14c4e6fa66
Merge pull request #16483 from hlysine/display-performance-attributes
...
Display performance breakdown in a tooltip
2022-02-08 16:29:58 +09:00
Henry Lin
10bdb7240f
Pre-check for divisor zero and add explanation
2022-02-08 14:36:29 +08:00
Dean Herbert
8cca12da64
Merge branch 'master' into display-performance-attributes
2022-02-08 14:45:35 +09:00
Dean Herbert
076388f5b0
Merge pull request #16823 from smoogipoo/fix-multi-spectate-crash
...
Fix crash on disconnection during multi-spectate
2022-02-08 12:18:23 +09:00
Dan Balasescu
c2416c490e
Fix crash on disconnection during multi-spectate
2022-02-08 11:29:39 +09:00
Henry Lin
56c90a21ce
Add a todo
2022-02-06 11:22:12 +08:00
Henry Lin
f78c853bc7
Calculate max combo locally in PerformanceBreakdownCalculator
2022-02-06 10:59:53 +08:00
Henry Lin
b31c1513f6
Fix test failure
...
The cursor was clicking too far to the right.
2022-02-05 22:41:04 +08:00
Henry Lin
ee6d4b2583
Move performance breakdown to the top to prevent re-ordering after watching replay
2022-02-05 21:39:01 +08:00
Henry Lin
0b1fef38af
Use the playable beatmap provided in CreateStatisticsForScore
2022-02-05 21:36:34 +08:00
Henry Lin
440b674bb0
Add statistic item for mania & taiko
2022-02-05 21:30:35 +08:00
Henry Lin
c35ef917a1
Remove tooltip from performance statistic
2022-02-05 21:18:23 +08:00
Henry Lin
2e1a9f1379
Add performance breakdown as statistic item in extended statistics panel
2022-02-05 21:13:16 +08:00
Henry Lin
f29301cd1e
Merge branch 'master' into display-performance-attributes
2022-02-05 16:59:46 +08:00
Dan Balasescu
885a285d13
Merge pull request #16782 from peppy/revert-invalidation-reductions
...
Revert "Merge pull request #16716 from peppy/carousel-less-invalidations"
2022-02-05 16:38:17 +09:00
