Dean Herbert
be50abeb7e
Merge pull request #12806 from peppy/fix-deleting-skin-elements
2021-05-15 07:08:43 +09:00
Bartłomiej Dach
aaa7c7eb05
Handle null case explicitly in SpectatorState.Equals()
...
Uses the usual pattern of two `ReferenceEquals` checks against `this`
and `null` before proceeding to inspect field values. Doing this causes
the compiler to infer that at the point that field values are checked,
`other` can no longer viably be `null`.
2021-05-14 23:58:07 +02:00
Bartłomiej Dach
044770f1a2
Locally suppress warning in SerializationReader
...
`SerializationReader` is not written in a form that would support
turning nullability checking on for the entire class. The biggest
problem there is the inner `DynamicDeserializer` static class, whose
members are initialised via an `initialize()` method, which the compiler
knows nothing about.
For this reason, just opt to suppress the single inspection about
returning a `null` from a method with a return type of `string` (rider
expects `string?`). It would have been also viable to enable nullability
checking for this one method, but that's pretty much the same thing and
adds no safety anyways, so just disable the warning to minimise
surprise.
2021-05-14 23:29:34 +02:00
Bartłomiej Dach
94d80f091f
Merge branch 'master' into fix-deleting-skin-elements
2021-05-14 22:33:41 +02:00
Bartłomiej Dach
3d3c5028e6
Trim unnecessary array copy
2021-05-14 22:33:26 +02:00
Bartłomiej Dach
743b4fbff1
Pass correct member name to ArgumentExceptions
2021-05-14 22:16:37 +02:00
Bartłomiej Dach
876f53bf3b
Fix copy-paste oversights in xmldoc & exception messages
2021-05-14 22:15:43 +02:00
Bartłomiej Dach
1c92b3a8f5
De-duplicate star rating display creation in test
2021-05-14 22:03:44 +02:00
Bartłomiej Dach
8b4e6d2911
Remove no longer necessary FinishTransforms(true) call
...
As the component no longer has any transition transforms applied.
2021-05-14 22:03:35 +02:00
PercyDan54
a4c1b9a1a7
Rename startTime to fadeStartTime
2021-05-14 21:56:13 +08:00
PercyDan54
a86a4bab91
Remove empty override
2021-05-14 21:55:32 +08:00
PercyDan54
393ac4fdd1
Destruct declaration
2021-05-14 21:30:58 +08:00
PercyDan54
67dfeeb1b7
Cleanup code in ModHidden
2021-05-14 21:29:13 +08:00
Salman Ahmed
7c2fc9b412
Update usage due to nullability removal
2021-05-14 16:12:33 +03:00
Salman Ahmed
93007c1635
Merge branch 'current-star-rating' into player-loader-star-rating
2021-05-14 16:06:00 +03:00
Salman Ahmed
6cc678f497
Remove nullability and transition support from star rating display
2021-05-14 16:05:40 +03:00
Salman Ahmed
0dc3bfd0c1
Apply simple transforms to star rating display when ready if not
2021-05-14 15:55:26 +03:00
Salman Ahmed
db361efecf
Add test beatmap difficulty cache with calc. blocking support
2021-05-14 15:53:56 +03:00
Salman Ahmed
e0728a6e19
Make BeatmapDifficultyCache.GetDifficultyAsync virtual
2021-05-14 15:52:36 +03:00
Dan Balasescu
a1d63243a4
Merge pull request #12800 from frenzibyte/online-play-oversight
...
Fix online play subscreens not pushing player loaders when starting gameplay
2021-05-14 20:44:44 +09:00
Salman Ahmed
34aab11ff3
Add null star rating display test case
2021-05-14 14:25:46 +03:00
Salman Ahmed
0655825057
Separate changing star rating display to own test
2021-05-14 14:25:13 +03:00
Dean Herbert
f5dd18f266
Use existing LoadedBeatmapSuccessfully bool instead
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-05-14 16:53:51 +09:00
Dean Herbert
67a99c83a3
Tidy bindable changed code up
2021-05-14 16:24:52 +09:00
Dean Herbert
fcb226bd20
Add local variable for regular access to HitObjects
2021-05-14 16:23:45 +09:00
Dean Herbert
9069db0743
Fix case of hitObjects variables
2021-05-14 16:22:19 +09:00
Dean Herbert
d09da02673
Fix deleting skin elements not saving out to skin
...
Closes https://github.com/ppy/osu/issues/12786 .
2021-05-14 16:03:22 +09:00
Dean Herbert
32ff406289
Add database tracking of beatmap creator user_ids
2021-05-14 15:40:29 +09:00
Salman Ahmed
8338f702c3
Remove not required null conditional
2021-05-14 09:32:56 +03:00
Dean Herbert
dc576c19b4
Fix a potential nullref when starting Player with autoplay enabled and beatmap fails to load
2021-05-14 15:10:02 +09:00
Dean Herbert
48672f8afd
Add very basic test logic to ensure PlayerLoader is present for playlists
2021-05-14 15:02:36 +09:00
Dean Herbert
1d4bcbaa6e
Merge pull request #12796 from peppy/update-framework
...
Update framework
2021-05-14 14:43:54 +09:00
Dan Balasescu
475c7e4a45
Merge pull request #12802 from peppy/random-component-toolbox-plaaceholders
...
Randomise the values displayed in the skinning toolbox
2021-05-14 13:38:43 +09:00
Naxess
9860e482af
Use TestWorkingBeatmap instead of null in tests
...
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Dean Herbert
46e7d9e0ed
Randomise the values displayed in the skinning toolbox
...
To stop the spam of "WYSI" comments everywhere. I guess I underestimated
the negative effect this would have.
2021-05-14 12:15:58 +09:00
Dean Herbert
b36c991ba1
Fix single case of incorrect usage
2021-05-14 12:04:38 +09:00
Dean Herbert
447371478e
Switch null assignment to non-nullable warnings on
2021-05-14 12:03:06 +09:00
Naxess
a447f20095
Fix formatting of #nullable enable
2021-05-14 03:38:35 +02:00
Naxess
90e0b3374e
Add #nullable enable
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-14 03:34:50 +02:00
Salman Ahmed
9e8c0a7e70
Fix online play subscreens not pushing player loaders when starting gameplay
2021-05-14 04:25:29 +03:00
Dean Herbert
ddceafb1b0
Update framework
2021-05-14 09:38:25 +09:00
Lucas A
6f248db519
Merge conditional expression.
2021-05-13 19:31:10 +02:00
Lucas A
0caba57945
Make screen properties local to MigrationSelectScreen.
2021-05-13 19:28:23 +02:00
Dean Herbert
10f008ae62
Merge pull request #12780 from peppy/skin-blueprint-aspect-lock
...
Add aspect ratio locking and flip support to skin editor
2021-05-14 00:55:18 +09:00
Bartłomiej Dach
6a64a705b8
Merge branch 'master' into skin-blueprint-aspect-lock
2021-05-13 17:53:00 +02:00
Bartłomiej Dach
25b1443c50
Remove dead branch and mark implementation as temporary
...
The previous implementation was checking if the `x0` or `x2` anchors
were selected to decide on which way to transfer the drawable's scale,
but that check actually ends up being always true for corner anchors. To
visualise, this is how the corner anchors correspond to `Anchor` flags:
x0 x1 x2
| | |
y0 -O---O---O-
| | |
y1 -O---+---O-
| | |
y2 -O---O---O-
| | |
The Os indicate where the reference anchors are on a selection box.
The first conditional eliminates the middle ones, which makes sense.
But after excluding them from further deliberations (marking via X):
x0 x1 x2
| | |
y0 -O---X---O-
| | |
y1 -X---+---X-
| | |
y2 -O---X---O-
| | |
The remaining anchors always have `x0` or `x2` set. So to avoid
confusion, just always transfer one way for now. At some point this
should be torn out in favour of an actual implementation of the desired
behaviour.
2021-05-13 17:50:12 +02:00
Bartłomiej Dach
879ef46354
Merge pull request #12765 from peppy/skin-blueprint-anchor-origin
2021-05-13 17:24:37 +02:00
Dean Herbert
0fa90a80d4
Merge branch 'master' into skin-blueprint-aspect-lock
2021-05-13 23:38:53 +09:00
Dean Herbert
3ecbb9ec4b
Merge branch 'master' into skin-blueprint-anchor-origin
2021-05-13 23:38:04 +09:00
Dean Herbert
98830dadda
Merge pull request #12762 from peppy/skin-blueprint-visual-improvements
...
Improve the visual appearance of skin editor blueprints
2021-05-13 23:37:21 +09:00
