9126 Commits

• Add some more padding between footer and column scroll
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  0b95594f60
• Move footer button padding to a higher level
  Bartłomiej Dach · 2022-05-07 09:29:32 +02:00
  0c6de331f3
• Merge pull request #18065 from huoyaoyuan/code-style

  Enforce code style analysis shipped with .NET SDK

  Dean Herbert · 2022-05-07 14:58:19 +09:00
  dd63657dfb
• Code quality
  Jai Sharma · 2022-05-06 23:17:59 +01:00
  6fc808be22
• Update new chat overlay day separator colours and spacing

  Updates the `DaySeparator` component to have separately settable colours
  for the text and the lines.
  
  Updates existing overrides of the `DaySeparator` to use the new colour
  setter.
  
  Create new `ChatOverlayDrawableChannel` with adjusted spacing and new
  `DaySeparator` colours.

  Jai Sharma · 2022-05-06 23:06:18 +01:00
  9d62206176
• Fix sequence equality check not using reference comparison
  Bartłomiej Dach · 2022-05-06 21:47:04 +02:00
  8c73ed7207
• Do not modify selected mods through panel state change during external update
  Bartłomiej Dach · 2022-05-06 21:47:04 +02:00
  621f746789
• Simplify state management in ModColumn

  Bad sign when you can't follow your own code.
  
  All of the various state changing methods were flattened into one
  because it was too hard to follow what was calling what and why.

  Bartłomiej Dach · 2022-05-06 21:46:16 +02:00
  c199b8fcb6
• Merge branch 'master' into fix-toolbox-expansion
  Salman Ahmed · 2022-05-06 18:00:01 +03:00
  1409f8ca96
• Remove leftover border thickness spec in mod settings area

  Was never supposed to be there, it was a vestige of a previous design
  iteration that went by unnoticed.

  Bartłomiej Dach · 2022-05-06 15:34:49 +02:00
  c533c93ffd
• Merge branch 'master' into fix-toolbox-expansion
  Bartłomiej Dach · 2022-05-06 13:47:36 +02:00
  e527574ede
• Merge pull request #18119 from bdach/mod-overlay/broken-hover

  Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select

  Dean Herbert · 2022-05-06 20:42:33 +09:00
  98eab9668d
• Remove not-accessed field
  Bartłomiej Dach · 2022-05-06 13:09:37 +02:00
  e9d52aa954
• Remove unused using directive
  Bartłomiej Dach · 2022-05-06 13:08:54 +02:00
  a915b7333c
• Change colour denoting expanded state to be gray rather than yellow

  I always found the yellow colour very non-descript in this case. Gray
  seems to work better?

  Dean Herbert · 2022-05-06 19:45:17 +09:00
  88c190f3e3
• Tidy up ordering of SettingsToolboxGroup
  Dean Herbert · 2022-05-06 19:39:09 +09:00
  b432885e5f
• Remove unnecessary autosize workaround (was fixed long ago)
  Dean Herbert · 2022-05-06 19:39:00 +09:00
  59add66632
• Remove auto-expansion of individual toolbox groups when parent expanding container expands
  Dean Herbert · 2022-05-06 19:36:41 +09:00
  949e30c4b4
• Fix click-to-return container still handling hover when inactive
  Bartłomiej Dach · 2022-05-06 12:28:53 +02:00
  08fd0ea086
• Move dangerous hold specification to base class
  Dean Herbert · 2022-05-06 14:34:31 +09:00
  be960eb092
• Merge branch 'master' into exit-multiplayer-is-dangerous
  Dean Herbert · 2022-05-06 14:25:18 +09:00
  0d8e42b941
• Use BindableFloat for chat height
  Jai Sharma · 2022-05-05 23:13:32 +01:00
  0974de8fb0
• Clamp maximum and minimum height the chat overlay can be resized to
  Jai Sharma · 2022-05-05 21:40:37 +01:00
  16a6c11bc8
• Fix mod overlay not closing on toggle hotkey
  Bartłomiej Dach · 2022-05-05 22:16:56 +02:00
  34cf4c6a38
• Extract interface for overlay management
  Bartłomiej Dach · 2022-05-05 22:16:55 +02:00
  a56eab2c47
• Use plum colour scheme in multiplayer to match rest of multiplayer screens
  Bartłomiej Dach · 2022-05-05 22:16:54 +02:00
  ac08498f35
• Close customisation area on escape press before exiting
  Bartłomiej Dach · 2022-05-05 19:17:36 +02:00
  79e1b93b30
• Fix hidden issue with automatic customisation panel show logic

  Doesn't cause tests to fail headless, but they do fail in the test
  browser.

  Bartłomiej Dach · 2022-05-05 19:17:36 +02:00
  2cc56a4b19
• Merge branch 'master' into new-chat-overlay
  Dean Herbert · 2022-05-05 23:12:31 +09:00
  9d48bb41c9
• Ensure RelativePositionAxes is set in BDL for animations to work
  Jai Sharma · 2022-05-05 14:20:33 +01:00
  5ea6f62951
• Merge branch 'master' into dialog-overlay-thread-woes
  Dan Balasescu · 2022-05-05 20:57:51 +09:00
  e46f99bdba
• Tidy up initialisation
  Dean Herbert · 2022-05-05 19:24:18 +09:00
  97221d2ef1
• Adjust value change variables to avoid e usage
  Dean Herbert · 2022-05-05 19:22:20 +09:00
  e54f5e2d92
• Remove ! usage (also seems to fix height saving/loading)
  Dean Herbert · 2022-05-05 19:22:12 +09:00
  74505ba166
• Replace HandlePositionalInput override with simple hover effect
  Dean Herbert · 2022-05-05 19:13:48 +09:00
  25ea660b0b
• Merge branch 'master' into new-chat-overlay
  Dean Herbert · 2022-05-05 18:57:00 +09:00
  4efaa41670
• Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)
  Dean Herbert · 2022-05-05 15:02:23 +09:00
  f6a6a11391
• Fix CurrentDialog being updated twice, unsafe variable access
  Dean Herbert · 2022-05-05 14:55:05 +09:00
  326ff3b6e9
• Fix failing tests due to CurrentDialog being unexpectedly not set after Push
  Dean Herbert · 2022-05-05 01:52:39 +09:00
  a27fcda9f1
• Merge branch 'master' into beatmap-selection-keybinding
  Salman Ahmed · 2022-05-04 16:48:49 +03:00
  e294069e2f
• Globalise beatmap selection key bindings as "group" selection
  Salman Ahmed · 2022-05-04 16:46:32 +03:00
  9416346c94
• Ensure focus is directed to ChatTextBox from ChatOverlay and add tests
  Jai Sharma · 2022-05-04 14:43:40 +01:00
  1a85e1267b
• Tidy up state variables
  Dean Herbert · 2022-05-04 21:00:11 +09:00
  ddab3c6d80
• Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms

  As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.

  Dean Herbert · 2022-05-04 20:23:36 +09:00
  383245f43a
• Rename FlushAnimation to FlushPendingSelections to better match purpose
  Dean Herbert · 2022-05-04 19:40:08 +09:00
  3eead5a6a3
• Ensure ChatTextBox takes/leaves focus on chat overlay pop in/out
  Jai Sharma · 2022-05-03 22:33:36 +01:00
  60999e83e0
• Add padding to text in ChatTextBar to separate it from the textbox
  Jai Sharma · 2022-05-03 22:32:51 +01:00
  c17edb2848
• Ensure ChannelListSelector text also turns white when selected
  Jai Sharma · 2022-05-03 22:32:01 +01:00
  50aee8b665
• Rewrite mod instance management again to pass tests
  Bartłomiej Dach · 2022-05-03 22:31:34 +02:00
  f5fa41356e
• Fix setting items not creating if mods initially not empty
  Bartłomiej Dach · 2022-05-03 21:45:40 +02:00
  970361676b