534 Commits

• Fix a few incorrectly updated arguments
  Dean Herbert · 2021-11-24 18:14:18 +09:00
  7603f7eb36
• Combine all test data BeatmapSetInfo creation into a single method
  Dean Herbert · 2021-11-24 18:07:32 +09:00
  0c819b9cfb
• Merge pull request #15778 from peppy/ruleset-info-id-usage

  Update usages of `RulesetInfo.ID` to use `OnlineID` instead

  Dan Balasescu · 2021-11-24 16:55:28 +09:00
  74b6c33fab
• Update mock RulesetInfo usage to set OnlineID instead of ID
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  f283770f34
• Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests
  Dean Herbert · 2021-11-24 14:52:08 +09:00
  44c34ca7b2
• Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
  Dean Herbert · 2021-11-24 13:27:37 +09:00
  8c60f37508
• Use Equals in carousel tests for better realm compatibility
  Dean Herbert · 2021-11-22 17:20:21 +09:00
  001f7c36f3
• Change difficulty cache storage type to nullable

  The recent changes related to adding support for working beatmap load
  cancellation exposed a flaw in the beatmap difficulty cache. With the
  way the difficulty computation logic was written, any error in the
  calculation process (including beatmap load timeout, or cancellation)
  would result in a 0.00 star rating being permanently cached in memory
  for the given beatmap.
  
  To resolve, change the difficulty cache's return type to nullable.
  In failure scenarios, `null` is returned, rather than
  `default(StarDifficulty)` as done previously.

  Bartłomiej Dach · 2021-11-20 17:00:50 +01:00
  15feb17da8
• Update some remaining test usage of database ID
  Dean Herbert · 2021-11-17 20:56:57 +09:00
  a4953b5658
• Update all simple cases of switching to IWorkingBeatmap
  Dean Herbert · 2021-11-17 20:56:57 +09:00
  7c2e79f911
• Use new helper method
  Dean Herbert · 2021-11-15 19:19:53 +09:00
  4856180912
• Fix TestSceneBeatmapRecommendations testing with an online ID of 0
  Dean Herbert · 2021-11-15 19:19:53 +09:00
  86b8fd3720
• Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:52:44 +09:00
  692e846acd
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface
  Dean Herbert · 2021-11-11 17:19:46 +09:00
  ebe58cee11
• Update all existing usages of AuthorString/AuthorId

  Unfortunately the getters need to be left in place else EF breaks.

  Dean Herbert · 2021-11-04 18:59:37 +09:00
  ed07ee8c61
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-04 18:21:31 +09:00
  b9983add15
• Remove BeatmapSetInfo.OnlineInfo and all usages
  Dean Herbert · 2021-11-04 15:23:04 +09:00
  9c926e5514
• Mark test usages of Ruleset.CreateInstance() as returning non-null
  Bartłomiej Dach · 2021-11-01 12:12:21 +01:00
  0d65493b56
• Fix null ruleset in another place
  Dean Herbert · 2021-10-29 20:12:12 +09:00
  bb9769aa17
• Fix more null rulesets
  Dean Herbert · 2021-10-29 19:05:42 +09:00
  22c2f48e4d
• Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet
  Dean Herbert · 2021-10-29 18:50:55 +09:00
  a16c8f1ebc
• Fix one more missed case
  Dean Herbert · 2021-10-29 18:35:15 +09:00
  04acc7601c
• Fix test scene and remove "impossible" nullable coalesce
  Dean Herbert · 2021-10-29 18:22:23 +09:00
  07e3ced315
• Fix test implementing old version of class
  Dean Herbert · 2021-10-29 17:04:56 +09:00
  3598adb344
• Rename BeatmapMetrics to APIFailTimes
  Dean Herbert · 2021-10-25 15:34:41 +09:00
  2c308f3008
• Move online metrics out of BeatmapInfo model
  Dean Herbert · 2021-10-25 15:32:18 +09:00
  20baae9094
• Move online metrics out of BeatmapSetInfo model
  Dean Herbert · 2021-10-25 15:12:39 +09:00
  045dd94a6e
• Fix test failure due to retyped class
  Dean Herbert · 2021-10-14 14:11:12 +09:00
  3964e5c448
• Fix intermittent TestScenePlaySongSelect test failures
  smoogipoo · 2021-10-12 22:07:57 +09:00
  91c286b1ad
• Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load
  Dean Herbert · 2021-10-05 18:06:24 +09:00
  94153e8bba
• Merge pull request #14903 from peppy/importer-returns-live

  Add `ILive<T>` and use as return type of `Import` methods

  Dan Balasescu · 2021-10-04 20:16:32 +09:00
  4bd1083388
• Merge branch 'master' into importer-returns-live
  smoogipoo · 2021-10-04 19:42:36 +09:00
  4871db2f86
• Rename last remaining BeatmapInfo Beatmap usage
  Dean Herbert · 2021-10-04 17:35:53 +09:00
  853cf6feaa
• Rename all remaining cases
  Dean Herbert · 2021-10-03 00:55:29 +09:00
  ec61c3c5ee
• Rename BeatmapInfo variables which were named beatmap for clarity
  Dean Herbert · 2021-10-02 12:45:34 +09:00
  973c31132b
• Initial push to use ILive in import process
  Dean Herbert · 2021-09-30 22:55:25 +09:00
  a2e61883e3
• Replace many more calls to CreateAllMods with more specific calls
  Dean Herbert · 2021-09-10 12:04:55 +09:00
  9cf79a80c2
• Refactor exposed mod retrieval methods for better safety
  Dean Herbert · 2021-09-10 11:09:13 +09:00
  cf633973a9
• Fix bindable implementation being synchronous
  smoogipoo · 2021-09-01 20:56:23 +09:00
  df7480e68c
• Add failing test case
  Bartłomiej Dach · 2021-08-22 19:16:43 +02:00
  e4a8f72167
• Merge branch 'master' into temporary-directory-test-storage
  Dean Herbert · 2021-08-20 11:54:33 +09:00
  7021133029
• Fix TestSettingsMigration's usage of RecycleLocalStorage
  Dean Herbert · 2021-08-18 16:39:10 +09:00
  2758a83d55
• Add visual test slider for changing star difficulty in beatmap wedge
  Salman Ahmed · 2021-08-17 05:46:14 +03:00
  eb6c6830bc
• Add a few cases of missing ConfigureAwait calls in tests project
  Dean Herbert · 2021-07-30 15:27:24 +09:00
  665bd3690a
• Change to alternative formatting
  Dean Herbert · 2021-07-12 18:08:19 +09:00
  78c74e97d1
• Fix one new incorrect formatting inspection from EAP6
  Dean Herbert · 2021-07-12 12:35:40 +09:00
  3642febbb6
• Remove some mentions of "lazer"

  I am aware there are more throughout the codebase but intentionally left
  the remaining mentioned for one reason or another. The intention here is
  to mainly change user-facing versioning to change the positioning of the
  "lazer" term (to be where we would expect "cuttingedge" or "beta" to
  be).

  Dean Herbert · 2021-07-04 12:41:27 +09:00
  ec71deec51
• Add test coverage
  Dean Herbert · 2021-06-14 15:06:33 +09:00
  fcb0b8d825