1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 22:07:28 +08:00
Commit Graph

34416 Commits

Author SHA1 Message Date
Dean Herbert
f177792915
Merge pull request #10873 from smoogipoo/remove-parent-dho-pooling
Remove ability to pool DHOs in parent playfields
2020-11-17 01:55:13 +09:00
smoogipoo
f5e12b9d7c Adjust TestScenePlayerLoader for safety 2020-11-16 23:53:54 +09:00
smoogipoo
e8dbc190f1 Remove ability to pool DHOs in parent playfields 2020-11-16 23:30:24 +09:00
smoogipoo
84b42f207d Fix triangles disappearing after a while 2020-11-16 23:14:20 +09:00
smoogipoo
4cf6aca873 Fix slider ball tint not working 2020-11-16 22:40:25 +09:00
smoogipoo
cead67d512 Add back removed InitialLifetimeOffset removal 2020-11-16 21:49:29 +09:00
smoogipoo
85b0f71467 Handle duplicate user IDs within the same batch 2020-11-16 21:17:43 +09:00
smoogipoo
87bf168718 Use queue instead of list 2020-11-16 20:52:51 +09:00
smoogipoo
1b1f4c9c09 Refactor user request to fix threadsafety issues 2020-11-16 20:35:22 +09:00
Dean Herbert
163f5cafb9
Merge pull request #10865 from ekrctb/tasks-json-restore 2020-11-16 20:08:09 +09:00
PercyDan54
99ee5e3ad7
Correct inheritance 2020-11-16 18:28:50 +08:00
ekrctb
16d25c5022 Adjast readme for the removed VSCode restore task 2020-11-16 19:25:36 +09:00
PercyDan54
017a6b7153
Fix checks 2020-11-16 18:22:17 +08:00
ekrctb
a53b5ef8b9 Remove --no-restore from VSCode build tasks 2020-11-16 19:22:08 +09:00
PercyDan54
f2ef7bee5d
Fix checks 2020-11-16 18:17:50 +08:00
PercyDan54
d7acfd5413
Remove retires from ModEasy 2020-11-16 18:15:15 +08:00
Dan Balasescu
08a127eedc
Merge pull request #10862 from peppy/fix-currentskininfo-thread-safety
Move skin deletion logic to OsuGameBase to promote thread safety
2020-11-16 18:41:46 +09:00
Dan Balasescu
a98327f0c5
Merge branch 'master' into fix-currentskininfo-thread-safety 2020-11-16 17:55:22 +09:00
Dean Herbert
dc38aeac43 Remove unnecessary local definition of colour logic from taiko judgement 2020-11-16 17:23:02 +09:00
Dan Balasescu
09298139e1
Merge pull request #10844 from bdach/spinner-rotation-tracker-state
Fix rotation tracker state not being reset on drawable spinner re-use
2020-11-16 17:10:40 +09:00
Dean Herbert
709370c69b Move schedule call outwards 2020-11-16 16:49:31 +09:00
Dean Herbert
9a7fdb2b7e Move skin deletion logic to OsuGameBase to promote thread safety
`CurrentSkinInfo` is used in multiple places expecting thread safety,
while ItemRemoved events are explicitly mentioning they are not thread
safe. As SkinManager itself doesn't have the ability to schedule to the
update thread, I've just moved the logic to `OsuGameBase`. We may want
to move the current skin bindable out of the manager class in the
future to match things like `BeatmapManager`.

Closes https://github.com/ppy/osu/issues/10837.
2020-11-16 16:43:19 +09:00
Dean Herbert
d8c9db860a
Merge pull request #10860 from ekrctb/dotnet-tool-inspectcode
Use `dotnet tool` for InspectCode build script
2020-11-16 16:25:01 +09:00
Dean Herbert
86ef73c587
Merge pull request #10830 from Joehuu/consistent-tournament-strings
Make tournament strings more consistent
2020-11-16 16:20:49 +09:00
Dean Herbert
6706840b54
Merge pull request #10853 from bdach/add-to-legacy-conversion-tests 2020-11-16 15:22:04 +09:00
ekrctb
b20898a1ac Use dotnet tool for InspectCode build script 2020-11-16 14:57:52 +09:00
Dean Herbert
a4c17906b4 Make comment a bit more explicit 2020-11-16 14:52:18 +09:00
Dean Herbert
baed1573dc
Merge pull request #10838 from nbvdkamp/fix-quick-delete-crash 2020-11-16 14:42:52 +09:00
Dan Balasescu
3dbd7d5654
Merge pull request #10856 from bdach/reset-transforms-on-return-to-pool
Clear DrawableHitObject transforms on return to pool
2020-11-16 14:40:38 +09:00
Dean Herbert
7169dc9173 Add extra step checking slider deletion on second click 2020-11-16 14:06:37 +09:00
Dean Herbert
7b79b9b9c1
Merge branch 'master' into fix-quick-delete-crash 2020-11-16 13:54:54 +09:00
Dean Herbert
0ea75450d4
Merge pull request #10850 from nbvdkamp/clamp-editor-movement
Clamp selection movement instead of refusing to move on playfield borders
2020-11-16 12:46:48 +09:00
Bartłomiej Dach
399a1a16a0 Refactor beginClickSelection in a slightly different way 2020-11-15 21:06:47 +01:00
Bartłomiej Dach
337311c323 Remove redundant type specification 2020-11-15 20:52:58 +01:00
Bartłomiej Dach
1f0945d4de Simplify accesses via ChildrenOfType() 2020-11-15 20:52:33 +01:00
Bartłomiej Dach
4e77800b98 Rename & simplify property 2020-11-15 20:51:35 +01:00
Bartłomiej Dach
9c0a0031d6 Clear existing transforms on DHO return to pool 2020-11-15 19:50:22 +01:00
Bartłomiej Dach
42de4437cc Add failing test case 2020-11-15 19:43:42 +01:00
kamp
c77ec3e905 Fix slider control point quickdelete test 2020-11-15 17:42:52 +01:00
Dean Herbert
67db278864
Merge pull request #10841 from bdach/fix-spectator-preview-crash
Add support for previewing tracks on spectator screen
2020-11-16 01:09:37 +09:00
kamp
1db303b159 Revert beginClickSelection logic 2020-11-15 16:54:48 +01:00
Bartłomiej Dach
6b38bb9d76 Add test coverage for new ownerless behaviour 2020-11-15 16:38:25 +01:00
kamp
83727a2e85 Add quick-delete tests 2020-11-15 16:06:29 +01:00
Bartłomiej Dach
7736d1ae85 Fix taiko-specific missing cases 2020-11-15 15:41:58 +01:00
Bartłomiej Dach
a17990f2ee Fix osu!-specific missing cases 2020-11-15 15:40:31 +01:00
Bartłomiej Dach
e5d9cca9de Fix mania-specific missing cases 2020-11-15 15:38:12 +01:00
Bartłomiej Dach
5d44286d38 Add missing generic mappings to legacy mods 2020-11-15 15:35:06 +01:00
Bartłomiej Dach
5ace7abaa8 Add abstract non-generic ModNightcore to pattern-match over 2020-11-15 15:32:02 +01:00
Bartłomiej Dach
e9b5f54128 Cover mapping fully for taiko mods 2020-11-15 15:32:02 +01:00
Bartłomiej Dach
9f27d4a9f4 Cover mapping fully for osu! mods 2020-11-15 15:32:02 +01:00