2508 Commits

• Fix legacy skin hold note bodies not appearing when scrolling upwards

  - Closes https://github.com/ppy/osu/issues/28567.
  - Regressed in https://github.com/ppy/osu/pull/28466.
  
  Bit of a facepalm moment innit...

  Bartłomiej Dach · 2024-06-25 10:35:36 +02:00
  1eac0c622a
• Fix nullability insepction
  Dean Herbert · 2024-06-18 15:13:52 +08:00
  e6187ebec0
• Adjust calls to DrawableExtensions.With<T>()
  Bartłomiej Dach · 2024-06-18 07:41:20 +02:00
  366ba26cb6
• Merge pull request #28466 from smoogipoo/fix-long-hold-length

  Fix missing texture on extremely long hold notes

  Bartłomiej Dach · 2024-06-13 09:13:03 +02:00
  fdb63bd7cd
• Fix missing texture on extremely long hold notes
  Dan Balasescu · 2024-06-13 15:19:41 +09:00
  1ff20cc13d
• Allow modifying hold note start/end time via mania composer playfield
  Bartłomiej Dach · 2024-06-12 15:30:27 +02:00
  feadf7a56e
• Fix failing tests due to missing DI pieces
  Dean Herbert · 2024-06-12 11:23:56 +08:00
  2a8bd8d968
• Attempt full editor reload on key count change
  Bartłomiej Dach · 2024-06-11 11:31:49 +02:00
  da53a11d3c
• Split mania difficulty section implementation off completely from base

  - "Circle size" / key count needs completely different handling.
  - Approach rate does not exist in mania.

  Bartłomiej Dach · 2024-06-11 11:30:20 +02:00
  10af642342
• Implement flip operations in mania editor
  Bartłomiej Dach · 2024-06-07 09:01:41 +02:00
  629e7652c0
• Fix legacy mania note body animation not resetting sometimes

  Hopefully closes https://github.com/ppy/osu/issues/28284.
  
  As far as I can tell this is a somewhat difficult one to reproduce
  because it relies on a specific set of circumstances (at least the
  reproduction case that I found does). The reset to frame 0 would
  previously be called explicitly when `isHitting` changed:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs#L144
  
  However, it can be the case that `bodyAnimation` is not loaded at the
  point of this call. This is significant because
  `SkinnableTextureAnimation` contains this logic:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game/Skinning/LegacySkinExtensions.cs#L192-L211
  
  which cannot be moved any earlier (because any earlier the `Clock` may
  no longer be correct), and also causes the animation to be seeked
  forward while it is stopped.
  
  I can't figure out a decent way to layer this otherwise (by scheduling
  or whatever), so this commit is just applying the nuclear option of just
  seeking back to frame 0 on every update frame in which the body piece is
  not being hit.

  Bartłomiej Dach · 2024-05-28 15:29:15 +02:00
  bf0040447c
• Do not change mania column width on mobile platforms

  - Closes https://github.com/ppy/osu/issues/25852
  - Reverts https://github.com/ppy/osu/pull/25336 /
    https://github.com/ppy/osu/pull/25777
  
  With the columns not being directly touchable anymore after
  https://github.com/ppy/osu/pull/28173 I see very little point to this
  continuing to exist.

  Bartłomiej Dach · 2024-05-16 08:21:52 +02:00
  97de73b99c
• Remove redundant cast
  Bartłomiej Dach · 2024-05-14 18:41:15 +02:00
  3d190f7e88
• Remove touch mod addition to mania

  Feels a bit pointless? I dunno.

  Dean Herbert · 2024-05-14 22:38:31 +08:00
  f781dc3300
• Tidy class and change to be a VisibilityContainer similar to taiko implementation
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  5c9a90cb40
• Rename touch area class to match existing usage (see taiko)
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  390557634a
• Move out of playfield so touch overlay is not affected by playfield position
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  12e98fe55d
• Hook up touch device mod
  Dan Balasescu · 2024-05-14 19:14:58 +08:00
  a761a7bced
• Add opacity setting
  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  e3f2e1ba08
• Hook up input manager
  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  39337f5189
• Add mania touch overlay

  Adjust default anchor/origin

  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  ef40197713
• Remove existing per-column touch input
  Dan Balasescu · 2024-05-14 19:10:14 +08:00
  4f6777a0a1
• Remove unused members from GameplaySkinComponentLookup
  Dan Balasescu · 2024-04-19 18:03:13 +09:00
  362a7b2c77
• Don't re-filter unless mods may change the filter
  Dan Balasescu · 2024-04-15 21:07:36 +09:00
  343b3ba0e6
• Fully qualify LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-04-01 17:02:32 +09:00
  8e0ca11d1c
• Add mods to FilterCriteria, pass to ruleset method
  Dan Balasescu · 2024-03-28 23:03:26 +09:00
  9fd6449fd8
• Refactor score simulator to use GetColumnCount()
  Dan Balasescu · 2024-03-28 22:58:39 +09:00
  c08a4898b2
• Remove unused OriginalTargetColumns
  Dan Balasescu · 2024-03-28 22:51:13 +09:00
  ce21235db4
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Refactor pattern generation to not require ManiaBeatmap
  Dan Balasescu · 2024-03-28 22:32:27 +09:00
  64399e9dd9
• Merge branch 'master' into verify-abnormal-difficulty-settings
  Bartłomiej Dach · 2024-03-26 11:13:16 +01:00
  b74f8dba41
• Refactor abstract check to reduce duplication
  Bartłomiej Dach · 2024-03-26 11:13:03 +01:00
  1866b4b6b1
• Make check ruleset specific
  Arthur Araujo · 2024-03-22 14:48:22 -03:00
  6fa663c8ca
• Remove warning for 10K+
  Arthur Araujo · 2024-03-20 16:51:27 -03:00
  2d6a3b8e2b
• Add mania keycount check
  Arthur Araujo · 2024-03-20 15:52:16 -03:00
  c605e463a4
• Merge branch 'master' into tcm-resume
  Dan Balasescu · 2024-03-14 12:22:46 +09:00
  0beaa8e8c5
• Fix missing event unbinds
  Dan Balasescu · 2024-03-07 21:10:11 +09:00
  ca92a31cf9
• Clamp only on horizontal sides
  Salman Ahmed · 2024-03-06 18:40:20 +03:00
  672f645cba
• Add comments
  Salman Ahmed · 2024-03-01 22:57:13 +03:00
  f1b66da469
• Fix osu!mania key images potentially showing gaps between columns
  Salman Ahmed · 2024-03-01 22:49:12 +03:00
  e0c73eb362
• Reduce allocations in ManiaSelectionBlueprint
  Andrei Zavatski · 2024-02-20 20:47:41 +03:00
  b92cff9a8e
• Reduce allocations in ManiaPlayfield.TotalColumns
  Andrei Zavatski · 2024-02-20 19:10:03 +03:00
  e9aca9226a
• Merge branch 'master' into legacy-body-piece-crash
  Salman Ahmed · 2024-02-16 00:30:36 +03:00
  3108842a1c
• Merge pull request #27068 from smoogipoo/mania-hd-fi-progression

  Add progressive coverage for mania's Hidden and FadeIn mods

  Dean Herbert · 2024-02-16 01:00:53 +08:00
  c1d9f53ab4
• Make dropdown text nicer
  Bartłomiej Dach · 2024-02-15 16:40:58 +01:00
  4b2197039c
• Add break support
  Dan Balasescu · 2024-02-15 22:05:25 +09:00
  878fb2d10d
• Adjust tests
  Dan Balasescu · 2024-02-15 21:25:40 +09:00
  d1a51b474c
• Fix resolution scaling
  Dan Balasescu · 2024-02-15 20:07:55 +09:00
  755bc7c050
• Fix selected legacy skins crashing on zero-length hold notes

  Closes https://github.com/ppy/osu/issues/27134.

  Bartłomiej Dach · 2024-02-12 08:33:08 +01:00
  36005a5449
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e