64779 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Lena	17656e9b9c	update the current activity when the multiplayer room updates	2024-01-02 18:38:25 +01:00
Dean Herbert	16c7c14602	Merge pull request #26332 from bdach/more-score-conversion-fail ... Fix standardised score conversion failing for some taiko scores due to overestimating accuracy portion	2024-01-03 01:48:28 +09:00
Dean Herbert	05d9aeefbc	Merge pull request #26248 from smoogipoo/slider-tail-judgement ... Increase slider tails' worth to 150 points (up from 30)	2024-01-02 20:50:34 +09:00
Bartłomiej Dach	b0cfea4916	Fix standardised score conversion failing for some taiko scores due to overestimating accuracy portion ... Standardised score conversion would return a negative total score for https://osu.ppy.sh/scores/taiko/182230346. The underlying reason for this is that the estimation of the accuracy portion for a score can be above the actual accuracy portion in the taiko ruleset. When calculating the maximum accuracy portion achievable, `TaikoLegacyScoreSimulator` will include the extra 300 points from a double hit on a strong hit, per strong hit. However, this double hit is not factored into accuracy. Both of the aforementioned facts mean that in taiko maximumLegacyAccuracyScore * score.Accuracy - which normally in other rulesets can be used pretty reliably as the exact number of points gained from the accuracy portion - is an estimate in the case of taiko, and an _upper_ estimate at that, because it implicitly assumes that the user has also hit `score.Accuracy` percent of all double hits possible in the beatmap. If this assumption is not upheld, then the user will have earned _less_ points than that from the accuracy portion, which means that the combo proportion estimate will go below zero. It is possible that this has happened on other scores before, but did not result in the total score going negative as the accuracy portion gained would have counteracted the effect of that due to being larger in magnitude than the score loss incurred from the negative combo portion. In the case of the score in question this was not the case due to very low accuracy _and_ very low max combo.	2024-01-02 10:11:49 +01:00
Dean Herbert	94531807e4	Make slider ends show on results screen again	2024-01-02 17:01:32 +09:00
Dean Herbert	5b8e9a5bd8	Merge pull request #26281 from iminlikewithyou/fix-precision ... Fix beats being counted incorrectly in the timing editor	2024-01-02 11:44:20 +09:00
iilwy	fbedcb29e4	Merge branch 'master' into fix-precision	2024-01-01 10:42:15 -06:00
Dean Herbert	e10733834b	Merge pull request #26201 from iminlikewithyou/menu-button-tweaks ... Adjust menu buttons	2023-12-31 16:58:55 +09:00
Dean Herbert	68b1455257	Merge pull request #26267 from frenzibyte/fix-audio-offset-adjust-control ... Fix suggested value in audio offset adjust control being opposite in signs	2023-12-31 16:32:13 +09:00
Dean Herbert	0834f0b2f5	Merge pull request #26276 from Gabixel/update-user-profile-interests-icon ... Fix interests icon no longer visible in user profile	2023-12-31 16:31:27 +09:00
iminlikewithyou	5ae5d7f92d	change floor to round	2023-12-30 23:59:47 -06:00
Dan Balasescu	8a40fa51f0	Merge pull request #26235 from frenzibyte/fix-argon-miss-judgement-mania ... Fix argon miss judgement on mania placed on a different position	2023-12-31 11:14:21 +09:00
Gabriel Del Nero	922b6ccb83	Use FontAwesome solid heart icon instead of OsuIcon's	2023-12-31 00:36:55 +01:00
Bartłomiej Dach	58ea8f9920	Merge pull request #26271 from Joehuu/remove-main-menu-version-reference ... Remove outdated main menu version reference on issue template	2023-12-30 20:49:57 +01:00
Joseph Madamba	535177ab97	Remove outdated main menu version reference on issue template	2023-12-30 11:44:11 -08:00
iminlikewithyou	45f6c78314	Merge branch 'master' of https://github.com/ppy/osu into menu-button-tweaks	2023-12-30 12:58:10 -06:00
iminlikewithyou	452f201f06	use margins isntead of moving the position of the sprite	2023-12-30 12:56:38 -06:00
Salman Ahmed	e6fe631625	Fix suggested value in audio offset adjust control being opposite in signs	2023-12-30 21:34:37 +03:00
Salman Ahmed	68dd103c89	Add failing test cases	2023-12-30 21:33:22 +03:00
Salman Ahmed	cc89390ea8	Expose SuggestedOffset bindable for testing purposes	2023-12-30 21:33:03 +03:00
Dan Balasescu	17a531209c	Use SliderTailHit result for slider tails (non-classic-mod)	2023-12-30 10:38:47 +09:00
Dan Balasescu	807443b648	Add HitResult.SliderTailHit	2023-12-30 10:38:47 +09:00
Salman Ahmed	08d88ec2fa	Add back initial position transform to ensure correctness	2023-12-29 20:47:18 +03:00
Salman Ahmed	8df9a1ee1f	Fix argon miss judgement on mania placed on a different position	2023-12-29 20:43:03 +03:00
Dean Herbert	0fa4cd5dfe	Merge pull request #26225 from peppy/new-menu-tips ... Add some new menu tips (and reword some others)	2023-12-29 22:27:47 +09:00
Dean Herbert	61c46b78bd	Update MenuTip.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2023-12-29 22:24:16 +09:00
Dean Herbert	9f0fe6c6ca	Fix common typos ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-12-29 22:20:29 +09:00
Dean Herbert	d00b7c9cdf	Add some new menu tips (and reword some others)	2023-12-29 22:14:51 +09:00
Bartłomiej Dach	f80f6a8c5b	Merge pull request #26207 from frenzibyte/fix-dropdown-colour ... Fix dropdown colour not updating correctly on enabled state changes	2023-12-29 14:07:09 +01:00
Dean Herbert	4437e2198a	Merge pull request #26224 from bdach/delete-toolbar-user-button-background ... Remove opaque background from toolbar user button	2023-12-29 22:01:45 +09:00
Bartłomiej Dach	17753b8235	Remove opaque background from toolbar user button ... Would close https://github.com/ppy/osu/issues/26223, and generally seems more consistent with the rest of toolbar anyhow?	2023-12-29 13:49:11 +01:00
Dean Herbert	490c584982	Merge pull request #26222 from bdach/i-cannot-into-offsets ... Fix global audio offset suggestion feature not taking previous offset value into account	2023-12-29 21:14:52 +09:00
Dean Herbert	2b81f4f557	Merge pull request #26221 from bdach/system-title-only-on-top-level-menu ... Do not display system title in inital menu state	2023-12-29 21:13:40 +09:00
Bartłomiej Dach	cdcb3ef4aa	Fix global audio offset suggestion feature not taking previous offset value into account ... See https://osu.ppy.sh/comments/2989193 etc.	2023-12-29 12:20:58 +01:00
Dan Balasescu	9548818a1b	Merge pull request #26220 from bdach/no-version-manager-on-deployed-builds ... Do not show main menu version display on deployed builds	2023-12-29 19:54:30 +09:00
Bartłomiej Dach	db78d73fa5	Do not display system title in inital menu state ... Addresses https://github.com/ppy/osu/discussions/26199.	2023-12-29 11:50:30 +01:00
Bartłomiej Dach	a9cf909937	Merge pull request #26219 from bdach/editor-timeline-crash ... Fix crash after changing audio track in editor	2023-12-29 11:41:45 +01:00
Bartłomiej Dach	25fa76a1b2	Do not show main menu version display on deployed builds ... See https://discord.com/channels/188630481301012481/188630652340404224/1190028102525530202.	2023-12-29 11:14:28 +01:00
Bartłomiej Dach	99cddb6317	Use alternative workaround	2023-12-29 11:07:45 +01:00
Bartłomiej Dach	cd1f6b46c4	Fix crash after changing audio track in editor ... Closes https://github.com/ppy/osu/issues/26213. Reproduction scenario: switch audio track in editor after timeline loads. Happens because `beatmap.Value.Track.Length` is 0 immediately after a track switch, until BASS computes the actual track length on the audio thread. Yes this is a hack. No I have no better immediate ideas how to address this otherwise.	2023-12-29 10:37:36 +01:00
Bartłomiej Dach	9bb0663b3b	Add test coverage of failure case	2023-12-29 10:36:53 +01:00
Dean Herbert	f7a4a2b098	Merge pull request #26216 from smoogipoo/expose-mod-property ... Expose `Mod.UsesDefaultConfiguration`	2023-12-29 18:03:25 +09:00
Dan Balasescu	a6313c4ee8	Expose Mod.UsesDefaultConfiguration	2023-12-29 17:16:16 +09:00
Dean Herbert	b163df42c2	Merge pull request #26203 from LeNitrous/fix/menu-tip-mod-select ... Make the menu tip about mod select's fun mods more up to date.	2023-12-29 13:41:58 +09:00
Salman Ahmed	c147ec0a98	Update dropdown disabled state to match with other components	2023-12-29 05:31:13 +03:00
Salman Ahmed	150bf67064	Fix dropdown colour not updating correctly on enabled state changes	2023-12-29 05:30:50 +03:00
Nitrous	c68a850325	Make menu tip about mod select more up to date.	2023-12-29 08:51:54 +08:00
iminlikewithyou	51d26d2d71	make the hover scale bigger ... as a consequence, the rotation needs to be tweaked to be lower	2023-12-28 17:20:44 -06:00
iminlikewithyou	f1f1221e0e	move text left to be visually centered in the skewed rectangle	2023-12-28 17:18:41 -06:00
iminlikewithyou	4760c6aaee	move icon upwards to be visually centered	2023-12-28 17:17:24 -06:00