49618 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Salman Ahmed	5e0882df8d	Simplify message highlighting transforms	2022-03-08 04:00:11 +03:00
Salman Ahmed	d74064b94b	Use Equals instead of reference equality operator	2022-03-08 03:56:27 +03:00
Salman Ahmed	f645869958	Update ChannelManager.CurrentChannel directly to handle non-loaded chat scenario ... `currentChannel` gets instantiated once the chat overlay is open, while `HighlightMessage` could be called while the chat overlay has never been open. This will all be rewritten with the new chat overlay design anyways, so should be fine for now.	2022-03-08 03:42:18 +03:00
Salman Ahmed	f8e5570e41	Fix Message equality not passing on equal references	2022-03-08 03:20:20 +03:00
Salman Ahmed	7f47be4680	Refactor message highlighting logic to rely on a Channel data bindable	2022-03-08 03:19:37 +03:00
Salman Ahmed	5764c53c17	OpenChannelNotification -> HighlightMessageNotification	2022-03-08 03:16:07 +03:00
Salman Ahmed	22a2ef42c5	Check channel ID on message highlight using currentDrawableChannel	2022-03-08 01:22:47 +03:00
Bartłomiej Dach	643f68e844	Better annotate initial rolling counter value set	2022-03-07 23:11:20 +01:00
Bartłomiej Dach	019f4d965d	Show two decimal digits on mod multiplier rather than one	2022-03-07 22:55:55 +01:00
Bartłomiej Dach	c25d7a1c75	Use rolling counter for multiplier display	2022-03-07 22:50:51 +01:00
Bartłomiej Dach	78a3b5961e	Implement basic difficulty multiplier display	2022-03-07 22:50:51 +01:00
Siim Pender	a02adfdbd4	Fix crash on super high bpm kiai sections	2022-03-07 20:36:09 +02:00
Dan Balasescu	e0d2c8ca5e	Merge pull request #17046 from peppy/clowd-squirrel ... Replace squirrel fork with `Clowd.Squirrel`	2022-03-07 16:25:40 +09:00
Dan Balasescu	51f6eb4028	Merge pull request #17075 from peppy/realm-property-watching ... Add ability to watch properties via a `RealmAccess` helper method	2022-03-07 14:38:23 +09:00
Dean Herbert	31d6c75f40	Merge branch 'master' into realm-property-watching	2022-03-07 13:53:17 +09:00
Dan Balasescu	b90a5864b1	Merge pull request #17138 from peppy/disallow-icon-interaction ... Disallow interaction with carousel set difficulty icons unless selected	2022-03-07 13:00:18 +09:00
Dean Herbert	da29947ecd	Disallow interaction with carousel set difficulty icons unless selected ... I kinda liked this flow, but from multiple reports from users it definitely seems in the way. We can revisit after the new design is applied to song select. Note that this means the tooltips also don't display. If it is preferred that they should (arguable from a UX perspective, since I'd expect to be able to click at that point) then the issue can be addressed using a slightly different path (a few more lines - nothing too complex).	2022-03-07 11:34:08 +09:00
Dean Herbert	bd1adaf245	Merge pull request #17115 from frenzibyte/manual-channel-scroll ... Refactor channel scrolling container to handle non-user scrolls	2022-03-07 11:26:23 +09:00
Salman Ahmed	32d242dd62	Hook up message notifications to chat message highlighting logic	2022-03-07 05:10:49 +03:00
Salman Ahmed	741702549b	Add test coverage for chat overlay message highlighting	2022-03-07 05:10:49 +03:00
Salman Ahmed	f4fa80c1e3	Add support to highlight messages in chat overlay	2022-03-07 05:10:49 +03:00
Salman Ahmed	cb2133944d	Add test coverage for channel message highlighting	2022-03-07 05:10:49 +03:00
Salman Ahmed	30b38345aa	Add ability to highlight chat lines	2022-03-07 05:08:36 +03:00
Dan Balasescu	ba83db0229	Merge pull request #17134 from bdach/mod-overlay/popup-screen-title ... Implement popup screen title component	2022-03-07 11:03:38 +09:00
Dean Herbert	3e73b8c78a	Merge pull request #17059 from frenzibyte/fix-storyboard-sample-rate ... Fix storyboard samples rate not adjusted from actual gameplay mods	2022-03-07 09:41:06 +09:00
Salman Ahmed	e5a6564034	Merge branch 'master' into fix-storyboard-sample-rate	2022-03-07 03:12:40 +03:00
Salman Ahmed	d9be65ea39	Remove no longer necessary CancelUserScroll method	2022-03-06 23:58:06 +03:00
Salman Ahmed	60334046e4	Revert UserTrackingScrollContainer changes	2022-03-06 23:57:51 +03:00
Salman Ahmed	a13a087f5d	Add xmldoc to trackNewContent to explain its purpose	2022-03-06 23:51:27 +03:00
Salman Ahmed	9ec0e74813	Move scrolling to UpdateAfterChildren to avoid scheduling ... At least that's what I believe "let FillFlow update to new size" means.	2022-03-06 23:50:58 +03:00
Salman Ahmed	9bc1f3f014	Further refactor and simplify ChannelScrollContainer	2022-03-06 23:34:12 +03:00
Bartłomiej Dach	54275813b5	Use text flow container in popup screen title	2022-03-06 20:41:31 +01:00
Bartłomiej Dach	df0617f34c	Implement popup screen title component	2022-03-06 16:09:18 +01:00
Dean Herbert	e322eb578a	Merge pull request #17116 from bdach/sample-popover-tabbing ... Allow tabbing between textboxes in sample point popover	2022-03-06 11:45:16 +09:00
Bartłomiej Dach	e1eeb9c6bb	Allow tabbing between textboxes in sample point popover	2022-03-06 01:43:56 +01:00
Salman Ahmed	634821e49f	Use the term "programmatically" instead	2022-03-06 00:01:45 +03:00
Salman Ahmed	5b3ffb12b7	Refactor channel scrolling container to handle manual scrolls resiliently	2022-03-05 23:27:07 +03:00
Dean Herbert	4de66bb1c6	Merge pull request #17093 from peppy/offset-ui-improvements ... Show beatmap offset adjustments in a more visual way	2022-03-06 02:17:36 +09:00
Dean Herbert	0e8ad4b143	Switch step to Until steps due to AddOnce firing logic	2022-03-06 01:50:25 +09:00
Dean Herbert	06512e8bd9	Use const for minimum height specification in final usage location ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-03-06 01:01:22 +09:00
Dean Herbert	f8ef352306	Don't consider judgements beneath the minimum height as being applicable ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-03-06 01:00:47 +09:00
Bartłomiej Dach	08b3bc222d	Revert "Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available" ... This reverts commit 8115a4bb8f. Commit was cherrypicked out to a separate pull on a different merge base, then reverted in that pull, so it should be reverted here too.	2022-03-05 16:42:51 +01:00
Bartłomiej Dach	e4b4c3c5c4	Merge branch 'master' into offset-ui-improvements	2022-03-05 16:10:18 +01:00
Dean Herbert	6264dd266d	Merge pull request #17087 from peppy/combine-time-slider-implementation ... Centralise implementation of slider bars which display millisecond time values	2022-03-05 23:48:26 +09:00
Dean Herbert	faddc20dca	Merge pull request #17073 from peppy/add-offset-adjust-tooltip-text ... Add tooltip text for offset adjustment slider	2022-03-05 23:28:24 +09:00
Bartłomiej Dach	cdd7e0b741	Merge pull request #17047 from peppy/add-display-choice-dropdown ... Add ability to select which display the game runs on	2022-03-05 15:12:06 +01:00
Bartłomiej Dach	346cec3577	Merge branch 'add-offset-adjust-tooltip-text' into combine-time-slider-implementation	2022-03-05 14:58:56 +01:00
Henry Lin	8b8b54b58f	Scale rate adjustments based on hit timing consistency and tweak some related numbers	2022-03-05 21:48:57 +08:00
Dean Herbert	ce51ce49cf	Revert changes to GetTooltipText and use TooltipText override directly	2022-03-05 22:46:13 +09:00
Bartłomiej Dach	38abfbf4d1	Merge branch 'master' into add-display-choice-dropdown	2022-03-05 14:39:59 +01:00