66657 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	1344ca4e19	Merge pull request #27780 from mafarrica/27105-fix-mod-search-box-focus-changes ... Fix mod search box not tracking external changes to focus state	2024-04-19 17:00:06 +02:00
Dean Herbert	6e08fd7f27	Merge pull request #27931 from smoogipoo/remove-unused-lookup-members ... Remove unused members from GameplaySkinComponentLookup	2024-04-19 20:51:09 +08:00
Dean Herbert	fd89195304	Merge pull request #27934 from smoogipoo/remove-unused-method ... Remove unused method	2024-04-19 20:50:34 +08:00
Dan Balasescu	ddc1b90ee1	Remove unused method	2024-04-19 20:36:24 +09:00
Bartłomiej Dach	509862490e	Revert unnecessary changes	2024-04-19 11:11:18 +02:00
Bartłomiej Dach	2dcbb823ef	Use textbox focus state directly rather than trying to track it independently	2024-04-19 11:08:34 +02:00
Bartłomiej Dach	9d04b44a88	Add failing test case	2024-04-19 11:04:05 +02:00
Dan Balasescu	362a7b2c77	Remove unused members from GameplaySkinComponentLookup	2024-04-19 18:03:13 +09:00
Bartłomiej Dach	6f84467190	Merge pull request #27908 from smoogipoo/silence-flatpak-exception ... Globally silence Discord RPC registration failures	2024-04-19 08:27:40 +02:00
Dean Herbert	78fbc288cf	Merge pull request #27909 from frenzibyte/add-sound-to-tab-selection-change-2 ... Add sound feedback to all tab controls with keyboard interaction	2024-04-19 13:20:42 +08:00
Dean Herbert	fe30c9ec2a	Merge branch 'master' into add-sound-to-tab-selection-change-2	2024-04-19 12:40:22 +08:00
Dean Herbert	863da8b200	Merge pull request #27815 from Susko3/upgrade-to-SDL3 ... Upgrade to SDL3	2024-04-19 12:16:34 +08:00
Dean Herbert	c39eb5c5aa	Merge branch 'master' into upgrade-to-SDL3	2024-04-18 22:23:55 +08:00
Dean Herbert	46e2cfdba5	Update framework	2024-04-18 18:33:30 +08:00
Salman Ahmed	a7e043bdbe	Fix beatmap rulest selector playing sound for initial ruleset selection	2024-04-17 11:20:17 +03:00
Salman Ahmed	24e8b88320	Add inline comment to the custom implementation of multiple-selection tab items	2024-04-17 11:20:17 +03:00
Salman Ahmed	9e69268676	Change editor screen selection logic to use SelectItem for sound feedback	2024-04-17 11:20:17 +03:00
Salman Ahmed	42892acc1a	Fix multiple selection filter tab items no longer playing sounds ... These tab items are not managed by a `TabControl`, activation events are manually served by the class itself toggling `Active` when clicked.	2024-04-17 11:20:17 +03:00
Salman Ahmed	50a21fb727	Change ToolbarRulesetSelector to use SelectItem to trigger new sound feedback path	2024-04-17 11:20:17 +03:00
Salman Ahmed	2a3ae6bce1	Update all TabItem implementations to play select sample on OnActivatedByUser	2024-04-17 11:20:17 +03:00
Dan Balasescu	03e13ddc30	Globally silence Discord RPC registration failures	2024-04-17 17:10:19 +09:00
Dean Herbert	15d286e57d	Merge pull request #27898 from bdach/preview-tracks-playing-after-hide ... Fix preview tracks playing after their owning overlay has hidden	2024-04-16 23:54:54 +08:00
Bartłomiej Dach	6c943681b0	Fix preview tracks playing after their owning overlay has hidden ... RFC. Closes https://github.com/ppy/osu/issues/27883. The idea here is that `PopOut()` is called _when the hide is requested_, so once an overlay trigger would hide, the overlay would `StopAnyPlaying()`, but because of async load things, the actual track would start playing after that but before the overlay has fully hidden. (That last part is significant because after the overlay has fully hidden, schedules save the day.) Due to the loose coupling between `PreviewTrackManager` and `IPreviewTrackOwner` there's really no easy way to handle this locally to the usages of the preview tracks. Heck, `PreviewTrackManager` doesn't really know which preview track owner is to be considered _present_ at any time, it just kinda works on vibes based on DI until the owner tells all of its preview tracks to stop. This solution causes the preview tracks to stop a little bit later but maybe that's fine? Just trying to not overthink the issue is all. No tests because this is going to suck to test automatically while it is pretty easy to test manually (got it in a few tries on master). The issue also mentions that the track can sometimes resume playing after the overlay is pulled up again, but I don't see that as a problem necessarily, and even if it was, it's not going to be that easy to address due to the aforementioned loose coupling - to fix that, play buttons would have to know who is the current preview track owner and cancel schedules upon determining that their preview track owner has gone away.	2024-04-16 16:19:26 +02:00
Dan Balasescu	3bd2bb0ed6	Merge pull request #27896 from bdach/fix-pause-overlay-missing-in-osu ... Fix resume overlay not appearing after pausing when mouse cursor is inside window but outside of actual playfield area	2024-04-16 22:11:17 +09:00
Bartłomiej Dach	e5e345712e	Fix resume overlay not appearing after pausing inside window but outside of actual playfield area ... Related to https://github.com/ppy/osu/discussions/27871 (although does not actually fix the issue with the pause button, _if_ it is to be considered an issue - the problem there is that the gameplay cursor gets hidden, so the other condition in the modified check takes over). Regressed in bce3bd55e5. Reasoning for breakage is silent change in `this` when moving the `Contains()` check (`DrawableRuleset` will encompass screen bounds, while `OsuResumeOverlay` is only as big as the actual playfield).	2024-04-16 13:45:09 +02:00
Bartłomiej Dach	f9873968a5	Apply NRT in OsuResumeOverlay	2024-04-16 13:39:06 +02:00
Bartłomiej Dach	c4bf03e640	Add failing test	2024-04-16 13:39:05 +02:00
Bartłomiej Dach	d2a67d2d54	Merge pull request #27881 from smoogipoo/fix-mod-refilter ... Don't re-filter unless mods may change the filter	2024-04-16 11:21:35 +02:00
Bartłomiej Dach	2c90ba9614	Merge pull request #27891 from peppy/stop-background-process-high-performance ... Fix high memory usage during spectator modes when background processing is running	2024-04-16 10:57:33 +02:00
Dean Herbert	926424d8ea	Update HighPerformanceSessionManager.cs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-04-16 16:37:11 +08:00
Dean Herbert	a651cb8d50	Stop background processing from running when inside a high performance session	2024-04-16 10:04:38 +08:00
Dean Herbert	d89edd2b4f	Expose high performance session state	2024-04-16 10:04:38 +08:00
Dean Herbert	7e4782d4b1	Allow nested high performance sessions ... Mostly just for safety, since I noticed this would pretty much fall over in this scenario until now.	2024-04-16 10:04:38 +08:00
Dan Balasescu	0e218ee271	Merge pull request #27148 from Givikap120/traceable_pp ... Add Traceable performance calculation support	2024-04-16 04:54:57 +09:00
Dan Balasescu	343b3ba0e6	Don't re-filter unless mods may change the filter	2024-04-15 21:07:36 +09:00
Dan Balasescu	fe7df808b6	Add tests	2024-04-15 21:07:08 +09:00
Dean Herbert	1c02cbfa5d	Merge pull request #27877 from bdach/fix-faded-pp-on-stable-scores ... Fix stable scores showing with faded out pp display due to classic mod presence	2024-04-15 18:21:21 +08:00
Bartłomiej Dach	7c4c8ee75c	Fix stable scores showing with faded out pp display due to classic mod presence	2024-04-15 11:53:05 +02:00
Bartłomiej Dach	8506da725d	Add failing test	2024-04-15 11:49:47 +02:00
Dan Balasescu	d34834af05	Merge pull request #27853 from Drison64/mask-volume-bar ... Fix toolbar volume bar masking	2024-04-15 03:36:31 +09:00
Ondřej Vajďák	ed6680a61d	Fixed type inconsistency and rounding	2024-04-14 15:10:05 +02:00
Ondřej Vajďák	9833dd955f	Fix toolbar volume bar masking	2024-04-14 01:30:59 +02:00
Dan Balasescu	e14e2a4629	Merge pull request #27845 from Loreos7/beatmap_hash ... Fix missing underscore in `invalid beatmap_hash` notification message	2024-04-13 21:16:55 +09:00
Loreos7	5a8b8908dd	fix missing underscore	2024-04-13 14:53:51 +03:00
Givikap120	4a21ff9726	removed duplication	2024-04-13 13:59:09 +03:00
Givikap120	feb9b5bdb8	Make traceable pp match HD	2024-04-13 13:42:57 +03:00
Dean Herbert	b7b3401b34	Merge pull request #27839 from smoogipoo/fix-macos-crash ... Fix crash when entering multiplayer on macOS	2024-04-13 12:54:00 +08:00
Dan Balasescu	c7f3a599c9	Fix crash when entering multiplayer on macOS	2024-04-13 13:17:06 +09:00
Dan Balasescu	3793a552b8	Merge pull request #27832 from peppy/skin-editor-new-items-apply ... Fix newly placed items in skin editor not getting correct anchor placement	2024-04-12 21:00:52 +09:00
Dean Herbert	c0dce94f15	Fix newly placed items in skin editor not getting correct anchor placement	2024-04-12 17:08:49 +08:00