75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix

  Fix for nearly straight sliders causing a crash

  Dean Herbert · 2024-05-31 20:00:47 +09:00
  4162d0babe
• Merge pull request #28363 from peppy/external-link-open-trusted

  Bypass external link dialog for links on the trusted osu! domain

  Bartłomiej Dach · 2024-05-31 09:11:49 +02:00
  b76ec9654d
• Add commentary on presence of IsPresent override
  Bartłomiej Dach · 2024-05-31 08:47:19 +02:00
  69990c35cb
• Fix incorrect prefix check
  Dean Herbert · 2024-05-31 15:38:26 +09:00
  c6a7082034
• Updated comments
  Aurelian · 2024-05-31 08:20:19 +02:00
  9111da81d2
• Fix mismatching localisation key prefix

  The `Strings` suffix is not supposed to be in here, judging by other
  localisation classes.

  Bartłomiej Dach · 2024-05-31 08:09:25 +02:00
  1a26a5dbda
• Fix compile failures
  Bartłomiej Dach · 2024-05-31 08:09:06 +02:00
  cb72630ce1
• Merge branch 'master' into account-for-sliders-in-accuracy-pp
  Bartłomiej Dach · 2024-05-31 07:41:04 +02:00
  b2722521fa
• Move dialog strings to more common class name
  Dean Herbert · 2024-05-31 11:46:32 +09:00
  5dfeaa3c4a
• Use common header text
  Dean Herbert · 2024-05-31 11:44:53 +09:00
  e52f524ea2
• Use question mark for more grammatical correctness

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Dean Herbert · 2024-05-31 10:46:30 +09:00
  474ff5b99d
• Add test coverage of menu banner link opening
  Dean Herbert · 2024-05-31 03:15:26 +09:00
  53b7c29488
• Bypass external link dialog for links on the trusted osu! domain
  Dean Herbert · 2024-05-31 02:44:51 +09:00
  ed64bfff8d
• Improve text on external link warning dialog
  Dean Herbert · 2024-05-31 02:44:45 +09:00
  87a331fdde
• Merge pull request #28337 from bdach/catch-conversion-my-old-friend-ive-come-to-talk-to-you-again

  Remove rounding of slider velocity multiplier on juice streams

  Dean Herbert · 2024-05-30 22:16:54 +09:00
  8196c0026d
• Merge pull request #28359 from smoogipoo/autopilot-resume-overlay

  Use delayed resume overlay for autopilot

  Dean Herbert · 2024-05-30 19:52:58 +09:00
  b46222db19
• Merge pull request #27977 from DavidBeh/magnetised-judgements

  Make judgements follow hitcircles and enable them in magnetised, repel and depth

  Dan Balasescu · 2024-05-30 19:21:20 +09:00
  3c2599c50f
• Use delayed resume overlay for autopilot
  Dan Balasescu · 2024-05-30 19:17:18 +09:00
  f6a59bee9a
• Merge pull request #28357 from peppy/dont-fail-acks

  Avoid `ChatAckRequest` failures flooding console in `OsuGameTestScene`s

  Dan Balasescu · 2024-05-30 18:15:25 +09:00
  981b69de2f
• Merge pull request #28358 from bdach/fix-main-menu-button-bg

  Fix main menu button backgrounds not covering their entire width sometimes

  Dean Herbert · 2024-05-30 17:57:53 +09:00
  f37546cc77
• Remove using statement
  Dean Herbert · 2024-05-30 17:45:32 +09:00
  f3bc944ac8
• Fix main menu button backgrounds not covering their entire width sometimes

  I thought I had fixed this already once but it still looks broken.
  Basically when hovering over main menu buttons every now and then it
  will look like their backgrounds are not covering their entire width
  when they expand.
  
  The removed X position set looks wrong to me when inspecting the draw
  visualiser with the element because the element looks to be off centre
  horizontally, and removing it fixes that.

  Bartłomiej Dach · 2024-05-30 10:38:22 +02:00
  50bd0897f6
• Fix typo in IAPIProvider xmldoc
  Dean Herbert · 2024-05-30 17:38:05 +09:00
  36d7775032
• Avoid ChatAckRequest failures flooding console in OsuGameTestScenes
  Dean Herbert · 2024-05-30 17:37:55 +09:00
  2f2bc8e52e
• Only take initial judgement position from object instead of following

  Looks less bad with mods like depth active.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-05-30 09:03:02 +02:00
  8916f08f86
• Update CatchPerformanceCalculator.cs
  Givikap120 · 2024-05-29 19:25:58 +03:00
  f5d2c549cb
• Fix incorrect handling of nested objects when inside parent object's duration
  Dean Herbert · 2024-05-29 23:30:47 +09:00
  fdb47f8dfa
• Apply results rather than fake a replay frame
  Dean Herbert · 2024-05-29 23:28:37 +09:00
  126837fadd
• Fix the majority of cases where gameplay stil doesn't end due to judgement count mismatch
  Dean Herbert · 2024-05-29 22:57:17 +09:00
  3b5b7b2f88
• Fix naming convention
  Nathen · 2024-05-29 09:40:59 -04:00
  f8f18b6cbd
• Save deviation calculations to variables
  Nathen · 2024-05-29 09:40:39 -04:00
  1714567342
• Merge pull request #28349 from bdach/do-not-hardcode-api-version

  Derive API response version from game version

  Dan Balasescu · 2024-05-29 21:35:19 +09:00
  0a7336ef17
• Avoid passing beatmap in from editor when it's already present
  Dean Herbert · 2024-05-29 21:32:55 +09:00
  d2c86b0813
• Add xmldoc to APIAccess.APIVersion
  Bartłomiej Dach · 2024-05-29 14:10:07 +02:00
  ab01fa6d45
• Derive API response version from game version

  (Or local date, in the case of non-deployed builds).
  
  Came up when I was looking at https://github.com/ppy/osu-web/pull/11240
  and found that we were still hardcoding this.
  
  Thankfully, this *should not* cause issues, since there don't seem to be
  any (documented or undocumented) API response version checks for
  versions newer than 20220705 in osu-web master.
  
  For clarity and possible debugging needs, the API response version is
  also logged.

  Bartłomiej Dach · 2024-05-29 14:10:01 +02:00
  cc13655617
• Merge branch 'master' into fix/editor-test-exit
  Dean Herbert · 2024-05-29 21:08:36 +09:00
  16e2fa2c6a
• Use hopefully safer implementation of anchoring judgements to objects
  Bartłomiej Dach · 2024-05-29 11:11:43 +02:00
  a6c776dac8
• Merge pull request #28339 from bdach/fix-legacy-body-piece-animation-not-resetting-sometimes

  Fix legacy mania note body animation not resetting sometimes

  Dan Balasescu · 2024-05-29 18:04:39 +09:00
  fa1da193ff
• Revert unrelated changes
  Bartłomiej Dach · 2024-05-29 10:57:30 +02:00
  22a2adb5e6
• Merge branch 'master' into magnetised-judgements
  Bartłomiej Dach · 2024-05-29 10:56:53 +02:00
  9fb7cc5900
• Merge pull request #28309 from OliBomby/scale-tool

  Add precise scaling control to osu! editor

  Bartłomiej Dach · 2024-05-29 10:52:00 +02:00
  bf7dc715de
• Remove unused fields
  Bartłomiej Dach · 2024-05-29 10:18:22 +02:00
  84513343d6
• Merge branch 'master' into scale-tool
  Bartłomiej Dach · 2024-05-29 10:15:48 +02:00
  7b7e439d03
• Change editor scale hotkey to Ctrl-E

  Forgot that Ctrl-T was taken by the game-global toolbar already, so it
  wasn't working.

  Bartłomiej Dach · 2024-05-29 10:14:47 +02:00
  9477e3b67d
• Rename method
  Bartłomiej Dach · 2024-05-29 10:04:51 +02:00
  9bd4b0d613
• Simplify logic
  Bartłomiej Dach · 2024-05-29 10:01:04 +02:00
  ba40737356
• Use more generic tooltip copy
  Bartłomiej Dach · 2024-05-29 09:59:19 +02:00
  96a8bdf920
• Simplify toolbox button enable logic
  Bartłomiej Dach · 2024-05-29 09:49:16 +02:00
  bd5060965f
• Rename another method
  Bartłomiej Dach · 2024-05-29 09:43:09 +02:00
  4a8273b6ed
• Use better name if we're renaming
  Bartłomiej Dach · 2024-05-29 09:40:29 +02:00
  4c881b5633