75266 Commits

This Branch

This Branch

All Branches

• Reduced subpoints limit to be a more practical value
  Aurelian · 2024-05-29 09:39:46 +02:00
  542809a748
• Merge pull request #28343 from Hecatia-Lapislazuli/reworked-slider-ball-rotation

  Always compute slider ball rotation based on tangent

  Dan Balasescu · 2024-05-29 14:23:19 +09:00
  ba3880ad54
• Merge pull request #24138 from tybug/negative-frame-handling

  Handle replay frames with negative time delta appropriately

  Dan Balasescu · 2024-05-29 13:46:24 +09:00
  98ad8f807a
• Merge branch 'master' into negative-frame-handling
  Dan Balasescu · 2024-05-29 13:14:59 +09:00
  655b0f5343
• SliderBall's rotation updates based on CurvePositionAt
  Aurelian · 2024-05-28 19:38:33 +02:00
  b74f66e335
• End circle only gets brighter once shift is held
  OliBomby · 2024-05-28 19:01:53 +02:00
  203e9284eb
• Merge remote-tracking branch 'upstream/master' into free-sliders
  OliBomby · 2024-05-28 18:42:34 +02:00
  2261d65b01
• disable playfield centre origin when scaling slider and simplify logic
  OliBomby · 2024-05-28 18:27:01 +02:00
  9a18ba2699
• fix axis checkboxes being disabled in playfield origin scale
  OliBomby · 2024-05-28 17:24:31 +02:00
  9548585b15
• refactor CanScaleFromPlayfieldOrigin and GetClampedScale to derived class
  OliBomby · 2024-05-28 17:12:16 +02:00
  d143a697d2
• Bind axis checkbox disabled state to CanScaleX/Y
  OliBomby · 2024-05-28 16:57:24 +02:00
  7cdc755c16
• Merge pull request #28338 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2024-05-28 16:46:24 +02:00
  4828215674
• remove redundant CanScaleFromSelectionOrigin
  OliBomby · 2024-05-28 16:19:57 +02:00
  8eb23f8a60
• rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled
  OliBomby · 2024-05-28 16:14:16 +02:00
  a89ba33b47
• Change scale hotkey to Ctrl+T
  OliBomby · 2024-05-28 15:56:59 +02:00
  36453f6215
• Fix legacy mania note body animation not resetting sometimes

  Hopefully closes https://github.com/ppy/osu/issues/28284.
  
  As far as I can tell this is a somewhat difficult one to reproduce
  because it relies on a specific set of circumstances (at least the
  reproduction case that I found does). The reset to frame 0 would
  previously be called explicitly when `isHitting` changed:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs#L144
  
  However, it can be the case that `bodyAnimation` is not loaded at the
  point of this call. This is significant because
  `SkinnableTextureAnimation` contains this logic:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game/Skinning/LegacySkinExtensions.cs#L192-L211
  
  which cannot be moved any earlier (because any earlier the `Clock` may
  no longer be correct), and also causes the animation to be seeked
  forward while it is stopped.
  
  I can't figure out a decent way to layer this otherwise (by scheduling
  or whatever), so this commit is just applying the nuclear option of just
  seeking back to frame 0 on every update frame in which the body piece is
  not being hit.

  Bartłomiej Dach · 2024-05-28 15:29:15 +02:00
  bf0040447c
• Update framework
  Dean Herbert · 2024-05-28 21:29:29 +09:00
  c2e7cdfdcc
• Remove rounding of slider velocity multiplier on juice streams

  Compare: https://github.com/ppy/osu/pull/26616
  
  This came up elsewhere, namely in
  https://github.com/ppy/osu/pull/28277#issuecomment-2133505958.
  
  As it turns out, at least one beatmap among those whose scores had
  unexpected changes in total score, namely
  https://osu.ppy.sh/beatmapsets/971028#fruits/2062131, was using slider
  velocity multipliers that were not a multiple of 0.01 (the specific
  value used was 0.225x). This meant that due to the rounding applied to
  `SliderVelocityMultiplierBindable` via `Precision`, the raw value was
  being incorrectly rounded, resulting in incorrect conversion.
  
  The "direct" change that revealed this is most likely
  https://github.com/ppy/osu-framework/pull/6249, by the virtue of
  shuffling the `BindableNumber` rounding code around and accidentally
  changing midpoint rounding semantics in the process. But it was not
  at fault here, as rounding was just as wrong before that change
  as after in this specific context.

  Bartłomiej Dach · 2024-05-28 13:14:44 +02:00
  a3b8493751
• Add failing test case for catch conversion

  Test is an abridged / cropped version of
  https://osu.ppy.sh/beatmapsets/971028#fruits/2062131 to demonstrate
  the specific failure case (unfortunately can't use the whole beatmap
  due to other conversion failures).

  Bartłomiej Dach · 2024-05-28 13:13:17 +02:00
  96af0e1ec3
• Merge branch 'master' into footer-v2-transitions
  Dean Herbert · 2024-05-28 18:49:39 +09:00
  8c4931eeec
• Merge pull request #28183 from frenzibyte/footer-v2-back-button

  Add new footer back button and fix shearing being different between components

  Dean Herbert · 2024-05-28 18:49:24 +09:00
  182ca145c7
• Merge branch 'master' into footer-v2-back-button
  Dean Herbert · 2024-05-28 15:50:34 +09:00
  4408039b3e
• Merge branch 'master' into hitposition
  Dean Herbert · 2024-05-28 10:35:46 +09:00
  00fd22841d
• Merge pull request #28277 from bdach/total-score-without-mods-once-more

  Compute total score without mods during standardised score conversion

  Dan Balasescu · 2024-05-28 07:49:27 +09:00
  e2b4e25ffa
• Added check for infinite subpoints for PerfectCurve
  Aurelian · 2024-05-27 20:32:18 +02:00
  6c4def1c09
• Added missing brackets for formulas
  Aurelian · 2024-05-27 19:41:38 +02:00
  172cfdf88d
• Test for accuracy of perfect curves
  Aurelian · 2024-05-27 19:35:33 +02:00
  d81be56adf
• Merge branch 'master' into total-score-without-mods-once-more
  Bartłomiej Dach · 2024-05-27 15:16:58 +02:00
  daee363743
• Merge pull request #28333 from peppy/preview-playlist-items

  Allow previewing audio of playlist items

  Bartłomiej Dach · 2024-05-27 14:22:49 +02:00
  c6c66fbd01
• Fix mod display not being aligned with mapper text
  Bartłomiej Dach · 2024-05-27 13:36:44 +02:00
  405c72c0d6
• Adjust size of play button / progress to match BeatmapCardThumbnail usage
  Dean Herbert · 2024-05-27 20:33:24 +09:00
  aad0982e26
• Pass the same thing in twice for better maybe
  Dean Herbert · 2024-05-27 20:30:01 +09:00
  75d961e6f2
• Standardise padding on both sides of difficulty icon
  Dean Herbert · 2024-05-27 19:59:25 +09:00
  d976224912
• Fix test failure
  Bartłomiej Dach · 2024-05-27 12:01:02 +02:00
  1f41261fc7
• Remove unused using directive
  Bartłomiej Dach · 2024-05-27 11:44:55 +02:00
  1e2cac3e92
• Merge branch 'master' into LeaderBoardScore_clean
  Dean Herbert · 2024-05-27 17:18:41 +09:00
  740a3377fa
• Allow previewing audio of playlist items
  Dean Herbert · 2024-05-27 17:09:37 +09:00
  b6471f0b9c
• Merge pull request #28332 from peppy/cinema-mod-overlay-hiding

  Fix cinema mod not hiding playfield skin layer

  Bartłomiej Dach · 2024-05-27 08:48:10 +02:00
  525663fc27
• Merge branch 'master' into cinema-mod-overlay-hiding
  Bartłomiej Dach · 2024-05-27 08:27:28 +02:00
  d22b72a75c
• Fix xmldoc reference
  Bartłomiej Dach · 2024-05-27 08:26:00 +02:00
  bdfce4b9da
• Merge pull request #28311 from Joppe27/taiko-glow-scale

  Correct scale of `taiko-glow` element to match stable

  Dean Herbert · 2024-05-27 15:19:06 +09:00
  5aa537f0c8
• Merge pull request #28327 from peppy/windows-16px-icon

  Revert windows 16px icon to original version

  Bartłomiej Dach · 2024-05-27 08:18:41 +02:00
  0aec8da102
• Fix cinema mod not hiding playfield skin layer
  Dean Herbert · 2024-05-27 14:52:28 +09:00
  11c3d11db9
• Share scale factor with hit target
  Dean Herbert · 2024-05-27 14:20:28 +09:00
  0d6adf160b
• Revert windows 16px icon to original version

  This also fixes the 48px version looking uncanny due to smaller paddings.

  Dean Herbert · 2024-05-27 11:42:36 +09:00
  a62b9fa633
• Use correct operation for 0 difficulty case
  js1086 · 2024-05-26 14:21:47 +01:00
  c25e1bdeb5
• Fix NaN case when difficulty is 0
  js1086 · 2024-05-26 11:24:06 +01:00
  61afda1089
• Follow slanted flow logic precedent in test

  See `ModSelectOverlay` components.

  Joseph Madamba · 2024-05-26 00:24:03 -07:00
  8e14c24ee3
• Correct scale of taiko-glow element
  Joppe27 · 2024-05-25 23:28:51 +02:00
  76f13b21da
• Merge branch 'master' into estimation-removal
  Fina · 2024-05-25 14:21:34 -07:00
  8dea601329