48098 Commits

• Merge branch 'master' into tips-remove-fps
  Salman Alshamrani · 2024-11-23 20:57:14 -05:00
  6b78553559
• Remove FPS shortcut tip
  SupDos · 2024-11-24 02:34:30 +01:00
  2f096f71d3
• Merge branch 'master' into fix-song-ticker-contrast
  Salman Alshamrani · 2024-11-23 20:14:33 -05:00
  608bda135a
• Remove using directive
  Salman Alshamrani · 2024-11-23 20:13:57 -05:00
  2f45ebeec8
• Fix daily challenge results screen beginning score fetch from user highest
  Salman Alshamrani · 2024-11-23 15:45:29 -05:00
  eed02c2ab1
• expand and contract settings from hover
  Sheppsu · 2024-11-23 01:09:58 -05:00
  3713bb48b7
• Merge branch 'master' into remove-macos-recommendation
  Salman Alshamrani · 2024-11-22 23:14:09 -05:00
  c9dc6628fc
• Merge pull request #30812 from smoogipoo/playlist-populate-on-enter

  Fix joining playlists room sometimes not selecting the first item

  Dean Herbert · 2024-11-22 23:57:45 +09:00
  ce41c000a1
• Add localisation
  Dan Balasescu · 2024-11-22 21:21:04 +09:00
  5ebaab7e9a
• Improve handling of multiplayer room status
  Dan Balasescu · 2024-11-22 21:21:04 +09:00
  82a63228de
• Fix chat channel listing not being ordered to expectations

  - Public channels (and announcements) are now alphabetically ordered.
  - Private message channels are now ordered by most recent activity.
  
  Closes https://github.com/ppy/osu/issues/30835.

  Dean Herbert · 2024-11-22 19:53:26 +09:00
  9930922769
• Use TryGetValue wherever possible

  Rider says so.

  Dean Herbert · 2024-11-22 19:11:16 +09:00
  c844d65a81
• Fix incorrect comment
  Bartłomiej Dach · 2024-11-22 11:06:36 +01:00
  ead7e99c59
• Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default
  Dean Herbert · 2024-11-22 19:05:29 +09:00
  c590bef4c3
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Merge branch 'master' into scale-profile-beatmaps
  Dean Herbert · 2024-11-22 18:33:37 +09:00
  e33e0e16e8
• Fix song ticker having very bad contrast against bright backgrounds

  Closes #30814.

  Dean Herbert · 2024-11-22 18:17:55 +09:00
  04ed954387
• Fix Room.CopyFrom() skipping a field

  Was making the close button not display when creating a room anew.

  Bartłomiej Dach · 2024-11-22 09:57:57 +01:00
  8b68859d9d
• Add close button to playlists footer
  Bartłomiej Dach · 2024-11-22 09:57:56 +01:00
  cfc38df889
• Add extra check to ensure closed rooms can't be closed harder
  Bartłomiej Dach · 2024-11-22 09:54:56 +01:00
  69c2c988a1
• Allow setting osu!mania scroll speed to single decimal precision

  Addresses https://github.com/ppy/osu/discussions/30663.

  Dean Herbert · 2024-11-22 17:36:28 +09:00
  29757ffdf2
• Cleanup CopyFrom() method

  Though the code appears slightly different, it should be semantically
  equivalent. APIUser equality is implemented on `Id` and `Host` should
  never transition from non-null to null.

  Dan Balasescu · 2024-11-22 17:22:30 +09:00
  39504c348d
• No longer remove expired playlist items from Room model
  Dan Balasescu · 2024-11-22 17:19:26 +09:00
  e59ac9e7c8
• Merge branch 'master' into close-playlists
  Bartłomiej Dach · 2024-11-22 09:02:41 +01:00
  3b2f43012e
• Merge pull request #30799 from peppy/fix-player-loader-focus-fux

  Fix beatmap load not continuing when when settings slider is focused

  Bartłomiej Dach · 2024-11-22 08:57:10 +01:00
  479ff7eb41
• Change some beatmap default settings to match stable

  - Countdown should [be off by
  default](https://github.com/peppy/osu-stable-reference/blob/9a0748563812b5085a0ef5f8600b997408330eab/osu!/GameplayElements/Beatmaps/Beatmap.cs#L372)
  - Samples match playback rate
  [also](https://github.com/peppy/osu-stable-reference/blob/9a0748563812b5085a0ef5f8600b997408330eab/osu!/GameplayElements/Beatmaps/Beatmap.cs#L210)

  Dean Herbert · 2024-11-22 16:55:37 +09:00
  a76b4418b9
• Merge branch 'master' into multiplayer-nrt
  Bartłomiej Dach · 2024-11-22 08:09:42 +01:00
  512d2c6e3b
• Merge pull request #30766 from Darius-Wattimena/catch-improve-info-on-selected

  Add snapping info to the catch selected objects inspector

  Bartłomiej Dach · 2024-11-22 08:08:33 +01:00
  4a129ac0bf
• Merge pull request #29640 from smoogipoo/mania-imperfect-ss

  Make mania award SS even if there are GREAT judgements

  Dean Herbert · 2024-11-22 14:42:32 +09:00
  6a0ac4c29e
• Rename variable to imply it is now a function
  Dean Herbert · 2024-11-22 13:11:32 +09:00
  41addaae9a
• Recreate beatmap every test run in ModTestScene
  Salman Alshamrani · 2024-11-21 17:48:33 -05:00
  5dffc322af
• Fix tests
  Dan Balasescu · 2024-11-22 01:26:35 +09:00
  2a7266cb23
• Populate rooms as soon as they're joined
  Dan Balasescu · 2024-11-21 23:48:04 +09:00
  f738fb2a89
• Populate parameter description

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2024-11-21 22:47:46 +09:00
  84ac3097c2
• Merge branch 'master' into patch-1
  Bartłomiej Dach · 2024-11-21 13:06:19 +01:00
  74170ea28e
• Enable NRT in TestMultiplayerRoomManager
  Dan Balasescu · 2024-11-21 21:03:12 +09:00
  209380cbac
• Fix crash due to being too forgiving of nulls

  This one is super duper annoying to test, because we already have e.g.
  `TestScenePlaylistsScreen`. The only way to test it would be to use an
  `OsuGameTestScene`.
  
  Maybe this is okay?

  Dan Balasescu · 2024-11-21 20:52:34 +09:00
  cc59434ea4
• Fix inspection
  Dan Balasescu · 2024-11-21 20:41:14 +09:00
  dc45816566
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Merge branch 'master' into catch-improve-info-on-selected
  Bartłomiej Dach · 2024-11-21 12:17:54 +01:00
  0e4d078beb
• Add back macOS precheck
  Dean Herbert · 2024-11-21 18:13:00 +09:00
  033b7c17d5
• Fix playlist room status resetting on enter
  Dan Balasescu · 2024-11-21 18:11:41 +09:00
  7018672275
• Add failing test
  Dan Balasescu · 2024-11-21 18:09:39 +09:00
  fe8e9d455a
• Use consistent decimal places in BeatmapAttributeText
  Cadence Ember · 2024-11-21 14:04:42 +13:00
  37394a5027
• Merge pull request #30798 from frenzibyte/fix-precision

  Add sane precision values to all settings

  Dean Herbert · 2024-11-21 03:00:49 +09:00
  2c0140f865
• Fix beatmap load not continuing when when settings slider is focused

  Regressed with recent sliderbar focus changes.
  
  Closes #30716.

  Dean Herbert · 2024-11-21 02:28:35 +09:00
  ae98f63b51
• Fix more cases of settings with no defined precision values
  Salman Alshamrani · 2024-11-20 12:11:38 -05:00
  40b95901e3
• Fix "positional hitsounds level" setting not specifying a precision constraint
  Salman Alshamrani · 2024-11-20 12:08:57 -05:00
  1ef02fec06
• Add ability to close playlists within grace period after creation
  Bartłomiej Dach · 2024-11-20 12:36:12 +01:00
  a679f0736e
• Changed multiplier from 2 to 3.5
  Fivoka · 2024-11-20 12:29:29 +01:00
  7726ca02b0