93 Commits

• Fix old looping samples not stopping when replacing a SkinnableSound's Samples

  Closes https://github.com/ppy/osu/issues/30365.

  Bartłomiej Dach · 2024-10-22 14:35:21 +02:00
  1008d32ddb
• Remove LINQ calls in hot paths
  Dean Herbert · 2024-01-07 14:31:22 +09:00
  9d9e6fcfdb
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Drank some coffee and figured out the fix
  Terochi · 2023-03-15 10:49:59 +01:00
  edc6314634
• Update the pauseLoop sample instantly on skin change
  Terochi · 2023-03-15 09:05:34 +01:00
  b0f1a69523
• Cache any skin changes in SkinReloadableDrawable to ScheduledDelegate
  Terochi · 2023-03-15 09:03:29 +01:00
  a9c349fa6d
• Reloading samples before playing then when skin change occurs
  Terochi · 2023-03-14 21:35:52 +01:00
  390ad335d0
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Apply NRT to all simple auxiliary skin classes
  Dean Herbert · 2023-01-26 17:53:04 +09:00
  4352c56c3e
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Fix back to front initialisation order
  Dean Herbert · 2021-03-20 10:51:58 +09:00
  ca943a897a
• Fix regression meaning SkinnableSound initialisation may never happen
  Dean Herbert · 2021-03-19 19:22:50 +09:00
  c0c8b3e46c
• Remove unnecessary duplicated skin changed handling

  For some reason we were handling this both in `DrawableSkinnableSound`
  and `PoolableSkinnableSample` in very similar ways. Only one seems
  required.

  Dean Herbert · 2021-03-19 15:23:32 +09:00
  0e821e857e
• Merge branch 'master' into fix-unsafe-skinnable-sample-play
  smoogipoo · 2021-02-22 18:31:27 +09:00
  ee6a94273d
• Add missing methods from updated audio component interface implementation
  Dean Herbert · 2021-02-22 14:18:52 +09:00
  63dd55c92c
• Update interface implementations with framework changes
  Dean Herbert · 2021-02-18 18:52:34 +09:00
  487a39eea9
• Update implementation of AdjustableAudioComponents
  Dean Herbert · 2021-02-18 15:44:23 +09:00
  143e145670
• Restart sound on play
  smoogipoo · 2021-01-20 13:59:30 +09:00
  bdb9d4f7d0
• Initial sample + samplechannel rework
  smoogipoo · 2021-01-19 17:11:40 +09:00
  de9d075f94
• Update namespaces
  Dean Herbert · 2021-01-18 21:24:10 +09:00
  ced7a36788
• Add support for playing a SkinnableSample without restarting it
  Dean Herbert · 2021-01-15 17:16:12 +09:00
  8a6857f151
• Invert back-to-front logic
  Bartłomiej Dach · 2020-12-06 18:59:38 +01:00
  f6d15b9757
• Merge branch 'master' into fix-multiple-playback-on-skin-change
  Bartłomiej Dach · 2020-12-06 18:21:24 +01:00
  fcd9483ffa
• Better API for dealing with the contained drawable samples
  smoogipoo · 2020-11-30 19:26:25 +09:00
  c29ad8edf8
• Apply simple PR reviews
  smoogipoo · 2020-11-30 18:40:22 +09:00
  afb8eb636d
• Fix samples being played more than once on skin change
  Dean Herbert · 2020-11-20 20:38:26 +09:00
  8080fe942c
• Add more xmldocs
  smoogipoo · 2020-11-19 22:48:21 +09:00
  7c83a27002
• Fix missing SkinChanged event + safety
  smoogipoo · 2020-11-19 22:42:44 +09:00
  8a656f7cee
• Cleanup, refactoring, and restart sample on skin change
  smoogipoo · 2020-11-19 22:30:21 +09:00
  d388c44428
• Fix volume discrepancies
  smoogipoo · 2020-11-19 21:21:30 +09:00
  0287269b2f
• Cleanups
  smoogipoo · 2020-11-19 20:38:36 +09:00
  70cb197957
• Fix looping not being propagated
  smoogipoo · 2020-11-19 20:29:09 +09:00
  812d5d59b1
• Separate files
  smoogipoo · 2020-11-19 19:52:34 +09:00
  003fed857c
• Add initial hit sample pooling
  smoogipoo · 2020-11-19 19:51:09 +09:00
  730b14b5bb
• Don't force Gameplay prefix on all skin sample lookups
  Dean Herbert · 2020-10-30 11:59:40 +09:00
  0b28cca7e6
• Merge branch 'master' into fix-storyboard-sample-pausing
  Dean Herbert · 2020-09-30 22:42:26 +09:00
  367b35bb10
• Reverse inheritance order of SkinnableSound's pause logic
  Dean Herbert · 2020-09-30 15:45:14 +09:00
  414c40d298
• Make DrawableStoryboardSample a SkinnableSound

  Allows sharing pause logic with gameplay samples.

  Dean Herbert · 2020-09-29 14:25:39 +09:00
  136843c8e4
• Fix pause loop sound not working because paused
  Dean Herbert · 2020-09-29 14:20:41 +09:00
  74e74e1c31
• Use existing bindable flow instead
  Dean Herbert · 2020-09-29 12:50:17 +09:00
  d6f3beffb6
• Remove a pointless portion of the inline comment
  Salman Ahmed · 2020-09-19 05:54:40 +03:00
  735b6b0d6f
• Fix gameplay samples potentially start playing while player is paused
  Salman Ahmed · 2020-09-16 01:59:07 +03:00
  35c7677d0a
• Merge branch 'master' into fix-skinnable-sound-mute
  Dean Herbert · 2020-08-10 23:55:51 +09:00
  365aae799e
• Reverse direction of bool to make mental parsing easier
  Dean Herbert · 2020-08-08 23:25:52 +09:00
  ffb2e56a8d
• Merge branch 'master' into fix-skinnable-sound-mute
  Dean Herbert · 2020-08-08 23:24:03 +09:00
  0d1f273603
• Adjust comment to read better

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2020-08-08 23:23:02 +09:00
  1090137da3
• Update usages
  Dean Herbert · 2020-08-06 21:53:20 +09:00
  c84452cfbf