88 Commits

• Fix argon judgement counter looking misaligned with wireframe off

  Closes https://github.com/ppy/osu/issues/34959.
  
  `ArgonCounterTextComponent` is pretty terrible and prevents being able
  to fix the issue easily. The core issue is that this is the first
  instance of the component's usage where the label text can be longer
  than the counter in the X dimension, so the total width of any counter
  is equal to max(label width, counter width), and the label will be
  aligned to the left of that width, while the counter will be aligned to
  the right of that width.
  
  The fix sort of relies on the fact that I don't expect *any* consumer of
  `ArgonCounterTextComponent` that meaningfully uses the wireframe digits
  to want the non-wireframe digits to be aligned to the *left* rather than
  the right. It's not what I'd expect any segmented display to work.
  (There are usages that specify `TopLeft` anchor, but they usually
  display the same number of wireframe and non-wireframe digits, so for
  them it doesn't really matter if the digits are left-aligned to the
  wireframes or not.)

  Bartłomiej Dach · 2025-09-13 11:11:45 +09:00
  e73e9275ba
• Merge pull request #34932 from Joehuu/fix-argon-judgement-colored-numbers

  Fix `ArgonJudgementCounterDisplay` not showing colored numbers when "Show label" is off

  Dean Herbert · 2025-09-09 15:20:49 +09:00
  11696a7a3c
• Guard against ArgonJudgementCounterDisplay crashing due to fuckery

  I can't see how this can happen in a normal flow, so just doing it as a
  safety measure. Pointed out in https://github.com/ppy/osu/issues/34940
  but likely due to a third party fuck being loaded.

  Dean Herbert · 2025-09-09 14:56:21 +09:00
  335bc6cdf6
• Fix ArgonJudgementCounterDisplay not showing colored numbers when "Show label" is off
  Joseph Madamba · 2025-09-05 12:25:40 -07:00
  18b5c652a3
• Always show the same number of placeholder digits in argon judgement counter when it is vertical
  Bartłomiej Dach · 2025-09-03 13:42:17 +02:00
  98c3437174
• Fix abysmal code quality
  Bartłomiej Dach · 2025-09-03 13:23:12 +02:00
  a56f81a731
• Merge branch 'master' into argon-judgement-counter
  Bartłomiej Dach · 2025-09-03 13:01:57 +02:00
  dac534e22a
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Remove unnecessary skin settings descriptions
  Salman Alshamrani · 2025-06-30 12:00:21 +03:00
  2b92b59504
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Fix SkinDeserialisationTest failing
  LukynkaCZE · 2025-03-08 23:02:57 +01:00
  1e2468d2bb
• forgot remove initializer vlaue
  LukynkaCZE · 2025-03-08 21:46:17 +01:00
  cc7e60daab
• fix ToString
  LukynkaCZE · 2025-03-08 21:38:45 +01:00
  bb588566e6
• add test scene
  LukynkaCZE · 2025-03-08 21:34:27 +01:00
  cbab183ea1
• add ArgonJudgementCounterDisplay
  LukynkaCZE · 2025-03-08 21:07:51 +01:00
  b1e0cf8532
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Use consistent decimal places in BeatmapAttributeText
  Cadence Ember · 2024-11-21 14:04:42 +13:00
  37394a5027
• Round to integral units

  The rounding matches the implementation of `PerformancePointsCounter`.

  Dan Balasescu · 2024-11-01 22:43:52 +09:00
  ef22b6b1a8
• Merge branch 'master' into bat-max-performance
  Bartłomiej Dach · 2024-11-01 13:13:20 +01:00
  3dc2408965
• Add missing disposal
  Bartłomiej Dach · 2024-11-01 11:26:59 +01:00
  5f63950598
• Merge branch 'master' into bat-mods
  Dan Balasescu · 2024-10-18 18:58:45 +09:00
  def499e7cb
• Return empty strings rather than erroring

  Preventing malicious actors from permanently destroying games via skins.

  Dan Balasescu · 2024-10-18 17:18:01 +09:00
  e27aa0c761
• Only add as many values as are replaced
  Dan Balasescu · 2024-10-18 17:16:42 +09:00
  2de5e3392e
• Use better exception messaging
  Bartłomiej Dach · 2024-10-18 08:51:01 +02:00
  8804769da1
• Discard unused argument
  Bartłomiej Dach · 2024-10-18 08:39:23 +02:00
  b455b9ad09
• Use stored difficulty to reduce flickering
  Dan Balasescu · 2024-10-17 20:39:50 +09:00
  0473f0b60a
• Merge branch 'bat-mods' into bat-max-performance
  Dan Balasescu · 2024-10-17 20:38:29 +09:00
  2ce1475303
• Store difficulty to reduce flickering

  The computation usually finishes in a few milliseconds anyway.

  Dan Balasescu · 2024-10-17 20:37:37 +09:00
  b40c31af3a
• Add max performance beatmap attribute text
  Dan Balasescu · 2024-10-17 20:00:18 +09:00
  6749768b9e
• Also bind to mod setting changes
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  f9a9ceb41c
• Show bpm and length inclusive of mods
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  9ea15a3961
• Show difficulty values inclusive of mods
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  400142545d
• Show star difficulty attribute inclusive of mods
  Dan Balasescu · 2024-10-17 17:57:49 +09:00
  1e2c1323ff
• Refactor BeatmapAttributeText to compute values on the fly
  Dan Balasescu · 2024-10-17 16:10:06 +09:00
  102f55a213
• Actually use bindables rather than stick things in Update()
  Bartłomiej Dach · 2024-09-24 15:15:28 +02:00
  9f4e48dde7
• Rename FontColour to TextColour
  Daniel Cios · 2024-09-20 16:50:17 +02:00
  73b6744a97
• Rename Colour to AccentColour
  Daniel Cios · 2024-09-20 16:38:26 +02:00
  ec575e9de4
• Add colour customisation to skin components
  Daniel Cios · 2024-09-19 17:27:25 +02:00
  e81e356d59
• Fix BeatmapAttributeText breaking due to enum serialisation woes
  Bartłomiej Dach · 2024-05-03 14:27:34 +02:00
  a23d25e0a1
• Add ability to show beatmap source using skin editor's beatmap attribute text

  As per https://github.com/ppy/osu/discussions/27955.

  Dean Herbert · 2024-04-24 09:01:31 +08:00
  16fdd4e08d
• Allow use of skin username/flag/avatar components outside of gameplay
  Dean Herbert · 2023-11-23 17:15:03 +09:00
  5239fee947
• Change default value and range of BoxElement's corner radius to match other usages
  Dean Herbert · 2023-11-15 10:45:01 +09:00
  2264e1e249
• Rename property to match expctations
  Dean Herbert · 2023-11-15 10:40:59 +09:00
  74fb1b5f81
• Use existing localisation for corner radius in BoxElement
  Joseph Madamba · 2023-11-14 14:13:20 -08:00
  535282ba7d
• Rename RoundedLine to BoxElement and make more generically useful
  Dean Herbert · 2023-11-10 16:20:05 +09:00
  60df2722ab
• Use a better default size for line
  Dean Herbert · 2023-11-10 15:53:05 +09:00
  99d9db5b76
• Rename and move skinnable line component to a more commomn place
  Dean Herbert · 2023-11-10 15:53:05 +09:00
  f31c1c9c79
• Add player name skin component

  3 minute implementation.
  
  Addresses https://github.com/ppy/osu/discussions/25340.

  Dean Herbert · 2023-11-06 15:24:16 +09:00
  e2b07628fb
• Fix publicly-settable bindables
  Dean Herbert · 2023-10-06 16:51:24 +09:00
  f2e56bbb65