50 Commits

• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Fix crash when resetting offset after a play with no hit events

  Closes https://github.com/ppy/osu/issues/30573.

  Dean Herbert · 2024-11-14 16:03:15 +09:00
  88d220f4c5
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Do not show non-basic results in timing distribution graph

  Closes https://github.com/ppy/osu/issues/24274.
  
  Bit of an ad-hoc resolution but maybe fine? This basically proposes to
  bypass the problem described in the issue by just not showing tick hits
  at all on the distribution graph.

  Bartłomiej Dach · 2024-04-25 11:20:07 +02:00
  b250a924b1
• Adjust metrics of HitEventTimingDistributionGraph
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  0881f4772c
• Centralise font size specification for statistic items (and reduce slightly)
  Dean Herbert · 2023-07-13 18:31:40 +09:00
  d54cf63983
• Fix animation restarting unexpectedly
  Dean Herbert · 2023-07-13 15:07:26 +09:00
  1d62a041cc
• Fix graph breaking when resized vertically
  Dean Herbert · 2023-07-13 14:57:01 +09:00
  21f26f98da
• Split bar drawable creation into own method
  Dean Herbert · 2023-07-13 14:43:41 +09:00
  e2b5abd4e8
• Fix timing distribution graph sometimes not displaying correctly

  Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)

  Dean Herbert · 2023-07-12 19:21:39 +09:00
  4f4c481a67
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing
  Acid Chicken (硫酸鶏) · 2022-09-12 16:25:29 +09:00
  4f298db066
• fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth
  Acid Chicken (硫酸鶏) · 2022-09-12 16:20:33 +09:00
  0d0e2e7bcc
• Avoid using bindables
  Dean Herbert · 2022-09-12 15:56:06 +09:00
  96951057df
• Move helper functions down in file
  Dean Herbert · 2022-09-12 15:50:10 +09:00
  bcd2445d9b
• Apply NRT to HitEventTimingDistributionGraph
  Dean Herbert · 2022-09-12 15:48:50 +09:00
  0755289ec3
• fix(osu.Game): handle size changes in timing distribution graph
  Acid Chicken (硫酸鶏) · 2022-09-12 04:46:32 +09:00
  ac324c63e2
• Rename ordering helper method
  Dean Herbert · 2022-09-08 17:50:27 +09:00
  c6521e4c72
• chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult
  Acid Chicken (硫酸鶏) · 2022-09-07 23:34:46 +09:00
  267465df18
• refactor(osu.Game): arrange the code for the timing distribution graph
  Acid Chicken (硫酸鶏) · 2022-09-07 23:29:10 +09:00
  b560b6f745
• Simplify children assignment
  Dean Herbert · 2022-09-07 16:51:51 +09:00
  99ef0c95fe
• refactor(osu.Game): improve code quality
  Acid Chicken (硫酸鶏) · 2022-09-07 02:29:15 +09:00
  3003fc1061
• chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one
  Acid Chicken (硫酸鶏) · 2022-09-06 00:04:10 +09:00
  b109e5de6c
• chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 04:44:27 +09:00
  7e77c9e8b4
• chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 03:45:51 +09:00
  b67fd3d880
• chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 02:02:38 +09:00
  0af6b3dc0f
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use const for minimum height specification in final usage location

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-06 01:01:22 +09:00
  06512e8bd9
• Don't consider judgements beneath the minimum height as being applicable

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-06 01:00:47 +09:00
  f8ef352306
• Hide adjustment when no adjustment is applied
  Dean Herbert · 2022-03-04 15:19:55 +09:00
  5a164e4520
• Only construct the adjustment portion of bars when required
  Dean Herbert · 2022-03-04 15:01:54 +09:00
  8c7b1e0aa8
• Only apply animation if the bar is going to be larger than the minimum height
  Dean Herbert · 2022-03-04 14:59:53 +09:00
  2785218b79
• Add the ability to set and show an offset value on timing distribution graph
  Dean Herbert · 2022-03-04 14:36:15 +09:00
  540d7d0e2c
• Colour centre bin in distribution graph differently
  Dean Herbert · 2022-03-04 14:09:27 +09:00
  d3e04fe594
• Fix autosize weirdness by specifying a constant size for the x axis
  Dean Herbert · 2022-03-04 14:05:42 +09:00
  c063a73742
• Allow an offset to be shown on the timing distribution graph
  Dean Herbert · 2022-03-04 14:05:42 +09:00
  010fa7ed01
• Merge branch 'master' into fix-hit-distribution-rounding
  Dean Herbert · 2022-03-04 12:43:57 +09:00
  835cb09537
• Ensure rounding is still applied in non-midpoint cases
  Dean Herbert · 2022-03-04 12:42:07 +09:00
  8b504bb5ac
• Fix hit distribution graph midpoint rounding not looking great around zero

  Not sure this will be accepted and it's likely only ever going to show
  in tests, but seems to be a better approach to midpoint rounding for
  this case?

  Dean Herbert · 2022-03-03 15:43:02 +09:00
  a06d806fb9
• Remove padding from distribution graph bars to fix some bars becoming invisible at low sizes
  Dean Herbert · 2022-03-03 15:13:42 +09:00
  ab0ee26540
• Fix test logic and stabilise rounding direction
  Dean Herbert · 2020-10-09 05:04:03 +09:00
  ff5a1937f5
• Fix incorrect timing distribution display due to lack of rounding
  Dean Herbert · 2020-10-09 04:41:45 +09:00
  a5b2c4195e
• Replace comparison references to HitResult.Miss with IsHit
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  2b1ef16f89
• Hide misses from timing distribution graph
  Dean Herbert · 2020-08-31 14:15:47 +09:00
  abdb991923
• Exclude EmptyHitWindow from being considered in TimingDistributionGraph
  Derrick Timmermans · 2020-06-29 15:53:56 +08:00
  bb81f908fb
• Fix div-by-zero errors with autoplay
  smoogipoo · 2020-06-22 20:32:04 +09:00
  ff2f3a8484
• Add minimum height to the timing distribution graph
  smoogipoo · 2020-06-19 22:21:34 +09:00
  4cb49cd606
• Fix potential off-by-one
  smoogipoo · 2020-06-19 20:53:30 +09:00
  34a8fcfd2f
• Adjust API for returning statistics
  smoogipoo · 2020-06-19 20:31:52 +09:00
  83e6c3efdb
• Move timing distribution graph to osu.Game
  smoogipoo · 2020-06-19 20:03:18 +09:00
  1cbbd6b442