81 Commits

• Reorder class to suck a bit less
  Dean Herbert · 2025-08-15 22:55:49 +09:00
  12811e2506
• Always use UR algorithm
  Dean Herbert · 2025-08-15 22:51:37 +09:00
  2d8aa403f7
• Adjust code to be more reviewable
  Salman Alshamrani · 2025-08-15 13:59:04 +03:00
  a1f0cd3b31
• Add inline comment
  Salman Alshamrani · 2025-08-15 13:35:55 +03:00
  d5758cd8fb
• Fix current change check not solid enough
  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  76630cff98
• Fix calibrating offset with auto-adjust enabled does not account for UR

  Covered by test `TestAutomaticAdjustmentWithUnstableRate`.

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  de7e3c96a6
• Move beatmap offset write logic to a separate method

  Note that calling `writeOffsetToBeatmap` from `currentChanged` is still intentionally not
  scheduled, see https://github.com/ppy/osu/pull/34612#discussion_r2269052138.
  
  This commit is done so that if that call is scheduled, then the logic
  above it that update the play graph and visibility state of the button
  still don't get scheduled, otherwise the test will fail (as noticed in https://github.com/ppy/osu/pull/34612#discussion_r2269208998).

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  1db49d250f
• Display calibration button when offset is manually adjusted
  Salman Alshamrani · 2025-08-12 11:05:36 +03:00
  43d10608b4
• Adjust offset text and fix incorrect display in certain scenarios
  Salman Alshamrani · 2025-08-12 11:05:13 +03:00
  9b360e5ea9
• Allow adjusting beatmap offset automatically based on last play
  Salman Alshamrani · 2025-08-11 10:37:31 +03:00
  de0eb7ccf3
• Merge pull request #33530 from JackArmstrong22/fix-negative-zero-audio-offset

  Fix beatmap offset control potentially reporting negative zero

  Dean Herbert · 2025-07-23 16:54:33 +09:00
  9f6b156d0c
• Add test coverage of incorrect formatting output

  Fix a cosmetic UI issue where -0.0 is displayed when clicking the Calibrate using last play button.
  
  Removed changes to AudioOffsetAdjustControl and added check to ToStandardFormattedString for if floatValue is 0

  Dean Herbert · 2025-07-23 14:47:38 +09:00
  44531794a1
• Adjust commentary to not suck

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-06-11 15:55:08 +09:00
  38ad48bb35
• Allow using previous valid score for offset calibration when subsequent retries are too short

  As proposed in https://github.com/ppy/osu/discussions/33572.
  
  Note that this won't work if you leave to song select. We could make
  that work but it would require further global faffing and I don't think
  it's worth the effort.

  Dean Herbert · 2025-06-11 15:26:02 +09:00
  cdb2f216f2
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Rename some variables
  Dean Herbert · 2025-04-03 18:55:45 +09:00
  332b081603
• Increase number of timed hits needed to activate button
  sineplusx · 2025-03-26 17:23:19 +01:00
  77d73c5f50
• Use median instead of mean for automatic beatmap offset adjustment
  sineplusx · 2025-03-26 15:41:48 +01:00
  bb8f8e8d8c
• Merge pull request #31645 from peppy/offset-adjust-more-lenience

  Make offset adjust more lenient

  Bartłomiej Dach · 2025-01-24 14:01:25 +01:00
  7845c5cfb7
• Fix average button not correctly becoming disabled where it previously would
  Dean Herbert · 2025-01-24 17:17:34 +09:00
  721b2dfbba
• Move line to correct location
  Dean Herbert · 2025-01-24 16:45:14 +09:00
  28a59f4e29
• Bypass offset disallowed status when handling realm callbacks

  Hopefully don't need to overthink this one.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  8f8a6455b4
• Add safeties against attempting to apply previous play while offset adjust is not allowed

  This should theoretically not be possible, but while we are sharing this
  control's implementation between gameplay and non-gameplay usages, let's
  ensure nothing weird can occur.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  ee78e1b223
• Consume GameplayStartTime for more lenient offset adjustments
  Dean Herbert · 2025-01-24 15:30:02 +09:00
  fb10996951
• Fix gameplay limitations for adjusting offset not actually being applied
  Dean Herbert · 2025-01-16 18:05:59 +09:00
  1d240eb405
• Apply beatmap offset on every beatmap set difficulty if they have the same audio
  Rudi Herouard · 2025-01-15 04:12:54 +01:00
  57a9911b22
• Add static memory of last applied offset score

  I don't really like adding this new session static, but we don't have a
  better place to put this.

  Dean Herbert · 2025-01-02 16:20:25 +09:00
  2a28c5f4de
• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49
• Fix offset adjust control not correctly applying changes after song select quit

  This is an interesting scenario where we arrive at a fresh
  `BeatmapOffsetControl` but with a reference score (from the last play).
  
  Our best assumption here is that the beatmap's offset hasn't changed
  since the last play, so we want to use it for the `lastPlayBeatmapOffset`.
  But due to unfortunate order of execution, `Current.Value` was not yet
  initialised.

  Dean Herbert · 2024-09-05 19:04:52 +09:00
  37f61b26ea
• Inline enabled setting
  Dean Herbert · 2024-06-15 17:34:04 +08:00
  ff2d721029
• Set to enable or disable at load time
  Shiumano · 2024-06-14 21:43:17 +09:00
  6c82f1de9b
• Show tooltip on global offset adjust slider bar
  Dean Herbert · 2024-01-17 17:57:49 +09:00
  cc7be137bc
• Change display text for beatmap audio offset adjust to make more sense
  Dean Herbert · 2024-01-17 17:51:46 +09:00
  123e36a999
• Fix code quality inspection
  Bartłomiej Dach · 2023-12-28 14:12:28 +01:00
  619b0cc69b
• Expose the ability to update global offset from the player loader screen
  Dean Herbert · 2023-12-28 20:01:34 +09:00
  b7f3c83514
• Migrate BeatmapOffsetControl to use session static directly
  Bartłomiej Dach · 2023-12-27 19:19:27 +01:00
  1b7af989ec
• Add conditions to match stable offset adjust limitations
  Dean Herbert · 2023-12-24 02:36:27 +09:00
  72bec527fd
• Don't bother with alt support for now
  Dean Herbert · 2023-12-24 01:59:48 +09:00
  92b490f2e7
• Allow external use of offset text explanation
  Dean Herbert · 2023-12-23 20:46:12 +09:00
  7e9522a722
• Add basic hotkey offset adjust support (via existing offset control)
  Dean Herbert · 2023-12-23 19:55:05 +09:00
  27a9dcc5a1
• Change offset calibration control to adjust for all difficulties of the current beatmap set
  Dean Herbert · 2023-07-19 17:13:19 +09:00
  5ec9cd84b2
• Add IHasNoTimedInputs interface to scope change further
  Dean Herbert · 2023-06-06 22:22:42 +09:00
  247fa088db
• Don't show offset calibration controls when "relax" mod is active

  Closes https://github.com/ppy/osu/issues/22892.

  Dean Herbert · 2023-03-22 15:45:04 +09:00
  c65a79614d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Apply changes in line with framework NRT updates
  Dean Herbert · 2022-11-18 18:13:15 +09:00
  06ce8130c2
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use LocalisableString.Interpolate instead of invalid TranslatableStrings
  Salman Ahmed · 2022-04-28 11:38:40 +03:00
  691bec6f16
• Only null the realm write task if it actually completed
  Dean Herbert · 2022-03-09 13:52:58 +09:00
  6bf436cd62
• Ensure the value used during realm async write is the same as whe compared for equality
  Dean Herbert · 2022-03-08 19:36:23 +09:00
  960b6528ca