1160 Commits

• Detach gameplay score from replay recorder before importing

  Closes #13320.

  Dean Herbert · 2021-06-04 02:00:02 +09:00
  d444fed46f
• Apply review fixes
  smoogipoo · 2021-06-03 18:32:05 +09:00
  e887807ae7
• Merge branch 'master' into fix-spectator-frame-conversion
  smoogipoo · 2021-06-03 17:42:01 +09:00
  c3280083a2
• Add framestable-bypassing seek for spectator
  smoogipoo · 2021-06-03 17:27:21 +09:00
  420df124b5
• Remove OnAdd/OnRemove of HitObjectContainer

  Instead, override `AddDrawable`/`RemoveDrawable`.

  ekrctb · 2021-06-03 15:00:16 +09:00
  b321b20e9d
• Make HitObjectContainer.Clear non-virtual

  It just call `Remove` for all entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  0ce7baa3f3
• Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property

  It can be used for dynamically added entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  2c9e5b6c7e
• Factor out lifetime management logic of HitObjectContainer
  ekrctb · 2021-06-03 14:57:28 +09:00
  fe2934db1d
• Merge branch 'master' into autoplay-pause-support
  Dan Balasescu · 2021-06-03 13:26:00 +09:00
  44b1102241
• Merge branch 'master' into fix-scrolling-lifetime
  smoogipoo · 2021-06-02 11:08:28 +09:00
  8ee2b3a2d2
• Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)
  Dean Herbert · 2021-06-02 11:06:30 +09:00
  8a76d97b63
• Fix editor no longer creating autoplay frames
  Dean Herbert · 2021-06-01 17:28:41 +09:00
  f14c0eae99
• Change timing of HitObjectContainer.OnAdd/OnRemove

  Now, `OnAdd` is always invoked after the DHO is added to the container.
  This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.

  ekrctb · 2021-05-31 20:56:25 +09:00
  ff04942295
• Merge branch 'simplify-shoc' into fix-scrolling-lifetime

  # Conflicts:
  #	osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs

  ekrctb · 2021-05-31 16:50:47 +09:00
  948a14a627
• Reset lifetime to initial lifetime when layout is invalidated
  ekrctb · 2021-05-31 16:47:10 +09:00
  86d1225aad
• Remove scrollLength caching field

  It was not clear when the field is updated.

  ekrctb · 2021-05-31 16:28:02 +09:00
  6d96846776
• Remove delay of lifetime update

  The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.

  ekrctb · 2021-05-31 16:24:13 +09:00
  742c5b442b
• Don't add nested hit objects to the sets

  Only top-level hit objects are checked for layout computation caching.
  Also, lifetime of nested hit objects are not managed by the HitObjectContainer.

  ekrctb · 2021-05-31 16:20:35 +09:00
  3cedc0824d
• Merge branch 'master' into realm-key-binding-store
  Dean Herbert · 2021-05-25 17:18:33 +09:00
  a249bb9e69
• Ignore certain banned InputKeys for gameplay purposes
  Dean Herbert · 2021-05-24 18:40:40 +09:00
  57640810b5
• Rename SpectatorStreamingClient -> SpectatorClient
  smoogipoo · 2021-05-20 15:55:07 +09:00
  6beeb7f7c4
• Merge branch 'master' into always-use-lifetime-entry
  Dan Balasescu · 2021-05-18 20:10:12 +09:00
  ef81bdf63f
• Revert "Use entry to calculate lifetime in ScrollingHOC"

  This reverts commit 632bb70e

  ekrctb · 2021-05-18 19:55:31 +09:00
  84a1a86c63
• Revert "Fix uninitialized scrollLength value is used"

  This reverts commit 73dfb04d

  ekrctb · 2021-05-18 19:55:25 +09:00
  2c65b8fa93
• Revert the change of not adding non-pooled DHO to HOC until alive
  ekrctb · 2021-05-04 16:44:48 +09:00
  913fc8c3bc
• Move caching of IBeatmap to base DrawableRuleset
  Dean Herbert · 2021-05-01 21:32:45 +09:00
  a551958eeb
• Fix uninitialized scrollLength value is used
  ekrctb · 2021-04-29 15:17:30 +09:00
  73dfb04df8
• Use entry to calculate lifetime in ScrollingHOC

  DHOs cannot be used to calculate lifetime, it is not created before the entry became alive.

  ekrctb · 2021-04-29 15:04:32 +09:00
  632bb70e0f
• Expose lifetime entries from HOC
  ekrctb · 2021-04-29 14:42:41 +09:00
  c83c804057
• Replace failed mania test (pooling not accounted) with a more robust test

  Also fix null reference in Playfield

  ekrctb · 2021-04-29 14:38:01 +09:00
  799d2a3300
• Always use LifetimeEntry to manage hit objects in HitObjectContainer

  Previously, non-pooled DHOs were immediately added as children of the HOC when Add is called. Also, non-pooled DHOs were always attached to the HOC as children.
  New behavior is that non-pooled DHOs are only added after CheckChildLifetime, and only attached to the HOC while the DHOs are alive.
  
  - LifetimeManagementContainer inheritance of HOC is removed, as it is now all DHOs are "unmanaged" (previously `AddInternal(false)`).
  - The signature of `Clear` is changed, and it is now always not disposing the children immediately.

  ekrctb · 2021-04-29 14:38:01 +09:00
  d262956146
• Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry

  Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject

  Dan Balasescu · 2021-04-21 17:08:21 +09:00
  cf55383fff
• Deprecate old overload of Apply
  ekrctb · 2021-04-21 14:32:37 +09:00
  3fbeadf318
• Record every 60fps interval
  smoogipoo · 2021-04-16 19:42:44 +09:00
  d26fa46ef2
• Remove manual handling of IsActive in RulesetInputManager

  Now it is supported in framework

  ekrctb · 2021-04-16 14:13:41 +09:00
  936bde28a3
• Merge branch 'master' into refactor-framed-replay-input-hander
  Dan Balasescu · 2021-04-15 21:48:58 +09:00
  ac8e462d32
• Remove usage of Lazy<List<...>> in NestedPlayfields
  ekrctb · 2021-04-15 18:26:01 +09:00
  d8aa436e81
• Merge conditionals for readability
  Dean Herbert · 2021-04-15 14:19:59 +09:00
  ba325de595
• Avoid empty list allocation
  ekrctb · 2021-04-12 18:49:38 +09:00
  6d18b3db00
• Throw when getting a frame of an empty replay
  ekrctb · 2021-04-12 11:17:56 +09:00
  d6d8ea5b6b
• Merge branch 'master' into fix-unsafe-skinnable-sample-play
  Bartłomiej Dach · 2021-03-18 19:51:46 +01:00
  aec859b4d1
• Add note about finalizers required for audio store clean-up
  Dean Herbert · 2021-03-02 16:07:51 +09:00
  c4ba045df1
• Remove unused using statement
  Dean Herbert · 2021-02-23 14:56:03 +09:00
  ec4b770cba
• When disable mouse buttons during gameplay is selected, disable more globally

  Until now the disable setting would only apply to left/right buttons,
  and only in gameplay. This change will cause any global actions bound to
  mouse buttons to also not work during gameplay.
  
  Closes #11879.

  Dean Herbert · 2021-02-23 14:37:46 +09:00
  672fd3f9d2
• Merge branch 'master' into fix-unsafe-skinnable-sample-play
  smoogipoo · 2021-02-22 18:31:27 +09:00
  ee6a94273d
• Add missing methods from updated audio component interface implementation
  Dean Herbert · 2021-02-22 14:18:52 +09:00
  63dd55c92c
• Update interface implementations with framework changes
  Dean Herbert · 2021-02-18 18:52:34 +09:00
  487a39eea9
• Update implementation of AdjustableAudioComponents
  Dean Herbert · 2021-02-18 15:44:23 +09:00
  143e145670
• Merge branch 'master' into non-concurrent-sample-playback
  smoogipoo · 2021-02-12 17:22:15 +09:00
  d3f0c0730d
• Expose Mods in DrawableRuleset to avoid using external DI
  Dean Herbert · 2021-02-11 17:47:29 +09:00
  f84ea30637