1160 Commits

• Make OsuGame dependency optional for sanity
  Dean Herbert · 2025-09-02 21:40:52 +09:00
  a1105ba16f
• Change bass workaround fix to use game clock intead of another-audio-clock

  paper trail:
  https://github.com/ppy/osu/pull/34890#issuecomment-3244549790

  Dean Herbert · 2025-09-02 21:39:12 +09:00
  bee6c32b83
• Fix gameplay freezing on stutter frames / long load times

  Closes https://github.com/ppy/osu/issues/34732.
  
  May hotfix for this one.

  Dean Herbert · 2025-09-02 17:37:33 +09:00
  677beb4251
• Revert "Adjust bass invalid data threshold"

  This reverts commit ddce11fbc8.

  Dean Herbert · 2025-09-02 17:36:08 +09:00
  a8ef57ad0a
• Merge pull request #34757 from bdach/new-mod-icons

  Update mod icons

  Dean Herbert · 2025-08-23 19:55:10 +09:00
  acafc06bcc
• Adjust icon sizings in mod display to match new assets
  Bartłomiej Dach · 2025-08-21 09:00:48 +02:00
  c053cfbf9b
• Log bass issues for more than one frame
  Dean Herbert · 2025-08-21 13:27:14 +09:00
  e75a6b4010
• Adjust bass invalid data threshold
  Dean Herbert · 2025-08-21 13:27:13 +09:00
  ddce11fbc8
• Fix half written comment and adjust threshold down slightly
  Dean Herbert · 2025-08-15 15:40:30 +09:00
  1f10bff7a7
• Don't enforce hotfix during debug builds, to allow interactive tests to run correctly
  Dean Herbert · 2025-08-15 15:29:51 +09:00
  69647f4c9c
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Fix mod adjustment marker not masking correctly
  Joseph Madamba · 2025-06-16 22:46:13 -07:00
  f9bae1fe2f
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Do not emit multiple consequent replay frames with the exact same data

  With judgements occurring forcing emission of important frames, there's
  the question of emitting redundant frames. In a majority of cases
  still, a judgement *will* be tied to a specific user input, which means
  that there's a high likelihood of duplicate frames, as one will be
  emitted by the input change, and another by the judgement.
  
  To a degree this is a pre-existing issue. The replay recording code
  responds to both mouse movement and key presses by recording frames, so
  depending on the intrinsic (basically undefined) ordering between
  handling mouse move and key presses, it was possible for multiple frames
  to be emitted with the same timestamp to the replay, each containing
  partial input state changes (e.g. first frame with mouse position
  changed, and the second with a key pressed).
  
  The extent to which this increases the frame count will obviously depend
  on the beatmap, but in my ballpark testing across all rulesets on a
  single "relatively standard" beatmap (think no aspire chicanery), around
  4-10% of frames can end up being duplicates / not meaningful. This has
  implications both on replay size and on playback performance.
  
  This commit therefore performs de-duplication of the frames based on
  timestamp - only the last frame with a given timestamp ends up in the
  final replay.
  
  The CPU cost of this is negligible to the point of not being useful to
  profile - it's a single condition gated behind a single float comparison

  Bartłomiej Dach · 2025-05-16 08:40:07 +02:00
  cd4ab9307c
• Emit important replay frames on every judgement

  - Closes https://github.com/ppy/osu/issues/4287
  - Probably closes https://github.com/ppy/osu/issues/25405 (but not
    retroactively)
  
  Up until now, whether or not a replay frame is emitted depended solely
  on the user's input, i.e. mouse movement or key presses/releases. This,
  intersected with the replay playback system which is given allowance to
  perform interpolation between replay frames, leads to potential
  situations wherein a replay can play inaccurately when a judgement takes
  place without user input meaningfully changing. One such case is slider
  ends with their 36ms of judgement leniency; see
  https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
  details on that.
  
  To that end, this commit aims to counteract that issue by *forcing* an
  important replay frame to be emitted on every new judgement recorded
  during gameplay. This will only benefit rulesets wherein judgements can
  occur that are not inherently tied to user input changing, which are
  going to be osu! as mentioned above, and maybe possibly catch. I don't
  foresee this doing anything relevant for taiko or mania.

  Bartłomiej Dach · 2025-05-15 11:43:09 +02:00
  9f91c2e25c
• Remove unnecessary replay recorder depth hack

  Addresses https://github.com/ppy/osu/pull/33102#discussion_r2087963889.

  Bartłomiej Dach · 2025-05-14 11:25:31 +02:00
  acebf3e95e
• Fix mod tooltip not handling settings changes to same mod instance
  Salman Alshamrani · 2025-05-12 15:04:51 +03:00
  d5be4bf8d4
• Fix adjustment marker not updating when settings' states change
  Dean Herbert · 2025-04-30 13:04:50 +09:00
  0c5193ba59
• Adjust colours to match icon better
  Dean Herbert · 2025-04-30 12:48:07 +09:00
  713fbfb2c8
• Show marker when settings are adjusted
  Dean Herbert · 2025-04-28 18:14:14 +09:00
  1e8d9b3482
• Merge pull request #32675 from peppy/disable-scroll-adjust-during-gameplay

  Disallow adjusting scroll speed during gameplay

  Bartłomiej Dach · 2025-04-07 11:05:58 +02:00
  82c52918c8
• Resolve test failures
  Dan Balasescu · 2025-04-04 23:17:16 +09:00
  319e3db14e
• Fix thread-race leading to OnScreenDisplay crash
  Dan Balasescu · 2025-04-04 22:48:33 +09:00
  abfda9cbcd
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Introduce rich mod tooltip
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  9b55325526
• Fix taiko swell ending samples playing at results sometimes

  Closes https://github.com/ppy/osu/issues/32052.
  
  Sooooo... this is going to be a rant...
  
  To understand why this is going to require a rant, dear reader, please
  do the following:
  
  1. Read the issue thread and follow the reproduction scenario (download
     map linked, fire up autoplay, seek near end, wait for results, hear
     the sample spam).
  2. Now exit out to song select, *hide the toolbar*, and attempt
     reproducing the issue again.
  3. Depending on ambient mood, laugh or cry.
  
  Now, *why on earth* would the *TOOLBAR* have any bearing on anything?
  
  Well, the chain of failure is something like this:
  
  - The toolbar hides for the duration of gameplay, naturally.
  - When progressing to results, the toolbar gets automatically unhidden.
  - This triggers invalidations on `ScrollingHitObjectContainer`. I'm not
    precisely sure which property it is that triggers the invalidations,
    but one clearly does. It may be position or size or whichever.
  - When the invalidation is triggered on `layoutCache`, the next
    `Update()` call is going to recompute lifetimes for ALL hitobject
    entries.
  - In case of swells, it happens that the calculated lifetime end of the
    swell is larger than what it actually ended up being determined as at
    the instant of judging the swell, and thus, the swell is *resurrected*,
    reassigned a DHO, and the DHO calls `UpdateState()` and plays the
    sample again despite the `samplePlayed` flag in `LegacySwell`, because
    all of that is ephemeral state that does not survive a hitobject
    getting resurrected.
  
  Now I *could* just fix this locally to the swell, maybe, by having some
  time lenience check, but the fact that hitobjects can be resurrected by
  the *toolbar* appearing, of all possible causes in the world, feels
  just completely wrong. So I'm adding a local check in SHOC to not
  overwrite lifetime ends of judged object entries.
  
  The reason why I'm making that check specific to end time is that I can
  see valid reasons why you would want to recompute lifetime *start* even
  on a judged object (such as playfield geometry changing in a significant
  way). I can't think of a valid reason to do that to lifetime *end*.

  Bartłomiej Dach · 2025-02-24 14:30:55 +01:00
  41db3c1501
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Fix rate adjustments changing the spacing between replay frames
  Dean Herbert · 2025-01-09 13:30:04 +09:00
  c8f72fdbe9
• Allow locking orientation on iOS in certain circumstances
  Salman Alshamrani · 2024-12-29 22:15:21 -05:00
  7563a18c7f
• Implement skinnable mod display

  Also makes the mod display initialization sequence (start expanded, then
  unexpand) controlled by HUDOverlay rather than mod display itself. This
  enabled different treatment depending on whether the mod display is
  viewed in the skin editor or in the player.
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Thomas Müller · 2024-12-07 12:06:33 +09:00
  0a00f7a7c2
• Stop loudly logging backwards seek bug to sentry

  Several users have reported stutters when this happens. It's potentially
  from the error report overhead. We now know that this is a BASS level
  issue anyway, so having this logging is not helpful.

  Dean Herbert · 2024-11-30 21:01:22 +09:00
  1e2e364cd3
• Initialise container earlier to avoid null reference failures
  Dean Herbert · 2024-10-23 18:46:20 +09:00
  064aaeb60e
• Fix playfield skinning layer no longer correctly rotating with the playfield

  Closes https://github.com/ppy/osu/issues/30353.
  
  Regressed in
  https://github.com/ppy/osu/commit/4a39873e2aac3a6fa71a3be06407d9afb7df8922.

  Bartłomiej Dach · 2024-10-21 13:49:12 +02:00
  e89a4561ab
• Merge branch 'master' into scroll-speed-std
  Dan Balasescu · 2024-08-30 00:41:05 +09:00
  4e8fb0dcab
• Increase mod icon acronym font weight
  clayton · 2024-08-25 20:42:57 -07:00
  70d08b9e97
• Use more contrasting color for mod icon foreground
  clayton · 2024-08-25 20:42:34 -07:00
  2bb72762ad
• Add property EditorShowScrollSpeed to Ruleset
  OliBomby · 2024-08-22 19:53:34 +02:00
  998b5fdc12
• Fix judgement animation getting cut early
  Dan Balasescu · 2024-07-16 17:32:59 +09:00
  bd4f3e28d9
• Use alternative method of releasing user-pressed keys when activating autoplay
  Bartłomiej Dach · 2024-07-03 14:37:07 +02:00
  0ab13e4486
• Fix user-pressed keys remaining pressed whtn autoplay is turned on
  Bartłomiej Dach · 2024-07-03 10:32:08 +02:00
  84c7d34b77
• Clear pressed keys and last replay frame when detaching replay from ruleset input manager
  Bartłomiej Dach · 2024-07-03 10:19:59 +02:00
  294aa09c41
• Enable NRT in RulesetInputManager
  Bartłomiej Dach · 2024-07-03 09:33:48 +02:00
  29c3ff0677
• Merge branch 'master' into LeaderBoardScore_clean
  Dean Herbert · 2024-05-27 17:18:41 +09:00
  740a3377fa
• Replace "X mods" text with a pill indicator
  Salman Ahmed · 2024-05-25 16:11:24 +03:00
  5955378004
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e