42 Commits

• Fix operations in PooledDrawableWithLifetimeContainer.CheckChildrenLife being in wrong order

  Previously CompositeDrawable.CheckChildrenLife() would be run before lifetimeManager.Update() which lead to the new drawables being inserted into the container but not being made alive immediately, leading to the drawable not becoming visibile until the next update loop.

  marvin · 2025-08-28 23:36:29 +02:00
  bb9f9e4d35
• Merge branch 'master' into scrolling-alloc
  Bartłomiej Dach · 2024-02-05 19:59:47 +01:00
  f65449375e
• Use SlimReadOnlyDictionaryWrapper for AliveEntries
  Andrei Zavatski · 2024-02-03 19:54:08 +03:00
  4aa27482a9
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Expose as ReadOnlyDictionary
  Dan Balasescu · 2024-01-31 22:52:57 +09:00
  0642d74014
• Make AliveDrawableMap public
  Andrei Zavatski · 2024-01-31 07:54:07 +03:00
  3aefc91967
• Fix FollowPointConnection pool filling up when follow points are hidden

  Closes https://github.com/ppy/osu/issues/26642.
  
  I think this applied to all pooling cases here.

  Dean Herbert · 2024-01-21 10:31:27 +09:00
  1999e772f6
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451
• Redirect HitObjectEntryManager child mapping to HOLE
  Bartłomiej Dach · 2023-07-04 23:41:06 +02:00
  bae7670855
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix up xmldoc
  Dan Balasescu · 2022-09-15 16:06:21 +09:00
  e56ea58e71
• Add some inline comments
  Dan Balasescu · 2022-09-15 16:00:35 +09:00
  c847cc521e
• Precondition against entryMap intead of parentMap
  Dan Balasescu · 2022-09-15 15:43:15 +09:00
  68e4d22898
• Don't store nulls to parentMap
  Dan Balasescu · 2022-09-15 15:38:44 +09:00
  31bc067dd1
• Apply NRT to hitobject lifetime related classes
  Dean Herbert · 2022-09-14 15:24:20 +09:00
  5dc0d32e42
• Remove createLifetimeEntry from HitObjectEntryManager
  ekrctb · 2022-09-14 15:19:33 +09:00
  c59aa57450
• Add doc comments to HitObjectEntryManager
  ekrctb · 2022-09-14 15:19:05 +09:00
  47539e2129
• Manage entries of nested hit objects in HitObjectEntryManager

  - Fix nested hit objects are leaked when parent hit object is edited or deleted

  ekrctb · 2022-09-14 15:19:05 +09:00
  bde390828b
• Factor out pooling logic from Playfield
  ekrctb · 2022-09-14 15:19:05 +09:00
  a9eba27129
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add xmldoc remark
  smoogipoo · 2021-06-18 19:27:10 +09:00
  42c5a962fb
• Don't set entry immediately
  smoogipoo · 2021-06-18 19:23:37 +09:00
  36d51d5117
• Add exception on Apply() while loading
  smoogipoo · 2021-06-18 19:20:57 +09:00
  36d2199a02
• Use property instead of backing field consistently
  ekrctb · 2021-06-17 10:31:20 +09:00
  e7954ecb60
• Allow setting Entry of PoolableDrawableWithLifetime

  It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
  Also, the object initializer syntax can be used.

  ekrctb · 2021-06-16 16:00:08 +09:00
  117e94bc94
• Make HitObjectContainer.Clear non-virtual

  It just call `Remove` for all entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  0ce7baa3f3
• Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property

  It can be used for dynamically added entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  2c9e5b6c7e
• Factor out lifetime management logic of HitObjectContainer
  ekrctb · 2021-06-03 14:57:28 +09:00
  fe2934db1d
• Simplify lifetime setter

  Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.

  ekrctb · 2021-06-01 14:46:43 +09:00
  40949f6c1b
• Fix wrong code
  ekrctb · 2021-06-01 14:38:02 +09:00
  0f381f7758
• Revert invalid code transformation
  ekrctb · 2021-06-01 14:28:23 +09:00
  86020adf64
• Apply code styling suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  ekrctb · 2021-06-01 13:17:30 +09:00
  d5714e63b9
• Update drawable lifetime on entry lifetime change
  ekrctb · 2021-05-31 14:45:29 +09:00
  e25cca6fbe
• Don't couple PoolableDrawableWithLifetime lifetime with its entry

  It turns out the incompatibility with `LifetimeManagementContainer` causes more issues than anticipated.

  ekrctb · 2021-05-20 14:56:15 +09:00
  0489ae719d
• Fix setting lifetime during KeepAlive is ignored
  ekrctb · 2021-05-04 16:56:48 +09:00
  aa42cf2fc0
• Throw an exception if try to modify lifetime of PoolableDrawableWithLifetime without lifetime
  ekrctb · 2021-05-04 16:04:58 +09:00
  36438175a0
• Completely delegate DHO lifetime to Entry lifetime

  A downside is lifetime update is not caught by LifetimeManagementContainer if used.

  ekrctb · 2021-04-29 14:38:01 +09:00
  5aa522b1c2
• Always use LifetimeEntry to manage hit objects in HitObjectContainer

  Previously, non-pooled DHOs were immediately added as children of the HOC when Add is called. Also, non-pooled DHOs were always attached to the HOC as children.
  New behavior is that non-pooled DHOs are only added after CheckChildLifetime, and only attached to the HOC while the DHOs are alive.
  
  - LifetimeManagementContainer inheritance of HOC is removed, as it is now all DHOs are "unmanaged" (previously `AddInternal(false)`).
  - The signature of `Clear` is changed, and it is now always not disposing the children immediately.

  ekrctb · 2021-04-29 14:38:01 +09:00
  d262956146
• Rename DrawableObject -> PoolableDrawableWithLifetime
  ekrctb · 2021-04-26 12:06:21 +09:00
  6561a7c7d6
• freeIfInUse -> free, and add comments
  ekrctb · 2021-04-26 12:04:59 +09:00
  20e3cadd30
• Factor out pooling and lifetime management logic of DHO to a base class
  ekrctb · 2021-04-21 17:37:42 +09:00
  b877a29737