93 Commits

• Fix xmldoc error and reword
  Salman Alshamrani · 2025-08-24 18:55:45 +03:00
  3cca458c21
• Fix flashlight not handling internal playfield sizing changes

  Note that this does not handle sizing/scaling changes applied directly
  to `Playfield`, but it handles any changes within the layers inside
  `PlayfieldAdjustmentContainer`.

  Salman Alshamrani · 2025-08-24 17:51:05 +03:00
  bc59270f3e
• Fix flashlight not correctly scaled to match playfield
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  a049f5065d
• Fix Flashlight having increased radius when Barrel Roll is active

  Closes https://github.com/ppy/osu/issues/33893.
  
  Regressed in https://github.com/ppy/osu/pull/29841.
  
  This sucks but I don't have better ideas.

  Bartłomiej Dach · 2025-06-27 13:48:44 +02:00
  96569e7829
• Disallow selected mods from being valid for freestyle as required mods due to them not being consistently compatible with other mods across rulesets

  Closes https://github.com/ppy/osu/issues/33444.
  
  The issue here is that for a set of required mods to make sense in the
  context of a freestyle playlist item, it must be consistently either
  valid or invalid *as a combination* across all four default rulesets,
  because freestyle also permits changing ruleset. There are two
  pertinent cases here:
  
  - Flashlight and Hidden are compatible in osu!, taiko, and catch, but
    not compatible in mania. In this case I've disallowed both mods
    because of symmetry, basically - I don't see one "better mod" to
    disallow here.
  
  - Accuracy Challenge and Easy are incompatible in osu!, catch, and mania
    (because the mod gives extra lives) there, but *compatible* in taiko,
    where it does not. In this case I've disallowed Accuracy Challenge
    only, because I find its value in being forced on a freestyle room
    to be much smaller than Easy's.
  
  In the large scale of things I don't see this being very important
  because my view is that 99% of the use case of required mods in
  freestyle is going to be changing the track speed. So I don't think
  anyone is going to care about this going away - but we can reassess if
  I'm proven wrong.

  Bartłomiej Dach · 2025-06-05 15:00:54 +02:00
  05496111d6
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Fix Flashlight not appearing on top of bubbles from Bubbles mod

  Inadvertently regressed in 44d0dc6113.

  Bartłomiej Dach · 2024-09-11 15:54:07 +02:00
  b78ef81bf1
• Fix 1px flashlight gaps when gameplay scaling mode is active

  Closes https://github.com/ppy/osu/issues/27522.
  
  Concerns mostly taiko and catch.
  
  Not much of a proper fix rather than a workaround but it is what it is.
  I tried a few other things, including setting `MaskingSmoothness = 0` on
  the scaling container itself, to no avail.

  Bartłomiej Dach · 2024-03-08 11:07:30 +01:00
  44d0dc6113
• Merge branch 'master' into flashlight-playfield-based-size-
  Bartłomiej Dach · 2024-02-26 10:55:06 +01:00
  353485a707
• Assert proportional scaling rather than assume average

  Because if scaling is ever actually non-proportional then this should be
  somewhat loud.
  
  Also use the absolute value to prevent funny things happening if/when
  someone does negative scale.

  Bartłomiej Dach · 2024-02-26 10:53:04 +01:00
  115d82664b
• Annotate mods that give pp
  Bartłomiej Dach · 2024-01-31 14:59:35 +01:00
  f89923aeae
• Make ScoreProcessor.Rank read-only
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  705f25e4b9
• Make flashlight scale with playfield

  When the playfield is shrunk with mods such as BarrelRoll, flashlight does not account for this, making it significantly easier to play. This makes it scale along with the playfield.

  rushiiMachine · 2023-12-27 23:02:45 -08:00
  75b9d0fe66
• Adjust with framework changes
  Dan Balasescu · 2023-12-04 08:51:21 +09:00
  b56a78c6ec
• Change flashlight depth in a more standard way
  Dean Herbert · 2023-05-02 17:00:54 +09:00
  414b80d44e
• Merge branch 'master' into bubble_mod_implementation_clean
  Dean Herbert · 2023-05-02 16:59:55 +09:00
  b2b9f2a036
• Update UBO usages inline with framework changes
  Salman Ahmed · 2023-03-16 14:06:35 +03:00
  678e8ed736
• Merge branch 'master' into bubble_mod_implementation_clean
  Dean Herbert · 2023-03-16 13:45:22 +09:00
  7b34607676
• Merge branch 'master' into veldrid-renderer
  Dean Herbert · 2023-03-14 17:35:38 +09:00
  969c0e9c9d
• Adjust DrawNodes to use UBOs
  Dan Balasescu · 2023-02-25 01:42:55 +09:00
  dd9748a25c
• Use Overlays container rather than KeyBindingInputManager for flashlight
  Dean Herbert · 2023-02-14 17:36:07 +09:00
  b42b5f97cf
• Add "ModBubbles" for the osu ruleset.
  mk56-spn · 2022-12-25 23:09:52 +01:00
  bbb22479a8
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Improve flashlight display on break periods
  Salman Ahmed · 2022-10-11 17:16:57 +03:00
  84fdd2e107
• Extract combo scale to virtual function
  Dan Balasescu · 2022-10-07 14:26:19 +09:00
  7385ef3e1b
• Adjust flashliht scaling to match classic
  Dan Balasescu · 2022-10-03 18:38:29 +09:00
  deae7cff60
• Add ability to adjust flashlight smoothness
  Dan Balasescu · 2022-10-03 18:24:56 +09:00
  0df217d85c
• Fix when flashlight shrinking takes place
  O Thiago · 2022-09-18 18:59:17 -04:00
  a4e9c7711c
• Revert changes

  This reverts commit beef3b418a.
  
  Revert "Use linq expression for handling breaks"
  
  This reverts commit 8464a1941b.
  
  Revert "renames variables to make more logical sense"
  
  This reverts commit 3b87ecf56c.
  
  Revert "Removes overhead when not combo based size"
  
  This reverts commit ac4229e3d4.

  O Thiago · 2022-09-18 18:57:53 -04:00
  407b104116
• Removes overhead when not combo based size
  O Thiago · 2022-09-18 00:38:01 -04:00
  ac4229e3d4
• renames variables to make more logical sense
  O Thiago · 2022-09-18 00:19:40 -04:00
  3b87ecf56c
• Use linq expression for handling breaks
  O Thiago · 2022-09-17 23:49:23 -04:00
  8464a1941b
• Simplifies size calculation
  O Thiago · 2022-09-17 23:41:23 -04:00
  beef3b418a
• Change mod description type to LocalisableString
  naoei · 2022-08-10 15:54:48 -04:00
  60dae70a18
• Adjust using directives for vertices
  Dan Balasescu · 2022-08-05 20:37:33 +09:00
  802dc90cb1
• Apply IRenderer changes
  Dan Balasescu · 2022-08-02 19:50:57 +09:00
  b4e55f7309
• Apply DrawNode batching changes
  Dan Balasescu · 2022-07-29 23:32:09 +09:00
  09979d44aa
• Apply DrawNode parameter changes
  Dan Balasescu · 2022-07-29 22:33:34 +09:00
  155dac55d0
• Mark the shader as non-nullable because shader should always has the value.

  And initialize the breaks to avoid get the null instance.

  為什麼 · 2022-07-19 20:39:41 +08:00
  317558f876
• Remove the nullable disable annotation.

  Also, mark as nullable for some properties.

  andy840119 · 2022-07-19 20:39:41 +08:00
  1f9f2b413e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix flashlight size multiplier printing with too many decimal digits
  Bartłomiej Dach · 2022-02-02 20:41:25 +01:00
  82f9ad63f5
• Simplify flashlight parameter passing flow
  Bartłomiej Dach · 2022-01-24 21:03:02 +01:00
  a227af75ed
• Extract DefaultFlashlightSize to base flashlight class
  Bartłomiej Dach · 2022-01-24 21:03:02 +01:00
  5874475dff
• Rename flashlight settings to be more accurate
  Bartłomiej Dach · 2022-01-24 21:03:02 +01:00
  a7c0d507ce
• ModeMultiplier rename
  mk-56 · 2022-01-24 11:38:52 +01:00
  948867898c
• Remove bindable from ModeMultiplier
  mk-56 · 2022-01-24 09:07:07 +01:00
  161a2a321e
• Adjust values to Bdach's refined taste
  mk-56 · 2022-01-24 00:42:43 +01:00
  ed84ae0ac0
• Separate the settings for each modes radiuses
  mk-56 · 2022-01-22 19:38:56 +01:00
  955bab926f