53 Commits

• Rewrite fix in a more legible way

  - Use better param name ("restoring" what bindings? the key information
    there is that the *defaults* are being restored)
  - Split ugly and not easily understandable (but probably
    best-that-can-be-done) conditional out to a method and comment it
    appropriately

  Bartłomiej Dach · 2024-11-01 19:38:45 +01:00
  f5a2674f66
• Fixed formatting for InspectCode
  Luke Knight · 2024-10-30 03:02:51 -05:00
  0f61e19857
• Prevent key bind conflict on reversion
  Luke Knight · 2024-10-30 02:04:03 -05:00
  b42fa23e42
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Null-propagate all calls to GetContainingFocusManager()
  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  8a4ae5d23d
• Update focus specifications in line with framework changes
  Dean Herbert · 2024-05-22 21:32:49 +08:00
  66ceda1d67
• Fix key binding row fire-and-forgetting writes

  Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129
  
  This is what happens if you carelessly fire and forget.
  
  The working theory (that I'm not sure I have the tools to conclusively
  confirm) is that the async write from the key binding changing could
  fire _after_ the section is reset.
  
  I briefly considered having the test wait for the change, but given that
  the entirety of the surrounding flow is using sync operations, this just
  looks like a bug to me. And there's no real sane way to inject async
  into that flow due to dependence on `OsuButton.Action`.

  Bartłomiej Dach · 2023-10-31 12:25:09 +01:00
  9f5a280bc2
• Add audio feedback for when keys are pressed during key binding
  Jamie Taylor · 2023-10-20 21:01:37 +09:00
  fbf8f52f7d
• Split KeyBindingRow out into partial pieces
  Dean Herbert · 2023-10-13 18:29:06 +09:00
  9b0c4acdef
• Switch records to classes for sanity

  I don't have anything against records except for the capitalisation when
  including the paramter names in a constructor.
  
  ie. `new Record(This: 1);`

  Dean Herbert · 2023-10-13 18:19:12 +09:00
  8e609b6f1d
• Move type back next to exposing class
  Bartłomiej Dach · 2023-10-12 20:26:01 +02:00
  f083309e64
• Refactor conflict handling flow to be less back-and-forth
  Bartłomiej Dach · 2023-10-12 20:25:59 +02:00
  991e425b9a
• Integrate key binding conflict popover into keybindings panel
  Bartłomiej Dach · 2023-10-12 16:04:46 +02:00
  f5a6781e5a
• Hoist database update to subsection level

  The end goal here is to be able to better coordinate deconfliction of
  bindings at the subsection level rather than try to jam that logic into
  individual rows somehow.
  
  The flipside is that this is going to require a flow to update the
  individual rows after the subsection's intervention, but that's what the
  previous commit was for.

  Bartłomiej Dach · 2023-10-12 16:01:51 +02:00
  aa8dbd742e
• Prepare KeyBindingRow for accepting external changes
  Bartłomiej Dach · 2023-10-12 16:00:20 +02:00
  5f0b1d69a5
• Refactor key binding panel leveraging new helper methods
  Bartłomiej Dach · 2023-10-12 15:03:29 +02:00
  c2e92cbb70
• Enable NRT in KeyBindingRow
  Bartłomiej Dach · 2023-10-11 08:50:00 +02:00
  797109c05c
• Add xmldoc
  Bartłomiej Dach · 2023-10-11 08:50:00 +02:00
  0b2b065383
• Use init-only properties where applicable
  Bartłomiej Dach · 2023-10-11 08:49:58 +02:00
  7ac874d17a
• Reorder KeyBindingRow members
  Bartłomiej Dach · 2023-10-11 08:18:59 +02:00
  1acc02405e
• Rename RestoreDefaultValueButton to RevertToDefaultButton

  Because I can't find it every time I search.

  Dean Herbert · 2023-07-13 13:46:50 +09:00
  1bfe5a18cb
• Sprinkle some more null-forgiving operators
  Bartłomiej Dach · 2023-07-06 22:08:48 +02:00
  ae2896ba7e
• Merge branch 'master' into update-framework
  Bartłomiej Dach · 2022-11-26 16:19:36 +01:00
  894ef15e79
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Combine TriangleButton and RoundedButton classes
  Dean Herbert · 2022-11-24 16:26:57 +09:00
  53b03df93d
• Merge pull request #21270 from peppy/auto-advance-bindings

  Auto-advance binding for ruleset key bindings

  Dan Balasescu · 2022-11-18 16:19:54 +09:00
  e4fc14faee
• Fix being able to bind two non-modifier keys to the same binding
  Dean Herbert · 2022-11-18 15:34:41 +09:00
  e658efbefa
• Refactor a bit for readability
  Dan Balasescu · 2022-11-18 13:55:37 +09:00
  551192b413
• Auto-advance binding for ruleset key bindings
  Dean Herbert · 2022-11-17 15:23:20 +09:00
  d1b2116400
• Implement tablet button bindings
  Aki · 2022-10-15 15:16:14 +08:00
  91358f4a6a
• Use async flow for storing key binding changes to realm
  Dean Herbert · 2022-10-11 15:37:22 +09:00
  6f6290a21a
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Change FilterTerms to use LocalisableString
  Dan Balasescu · 2022-05-16 14:09:37 +09:00
  a633501687
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Fix various cases of creating realm contexts from update thread when not necessary
  Dean Herbert · 2022-01-21 01:44:56 +09:00
  a5d2047f05
• Switch realm ruleset key bindings to use ruleset's ShortName as key
  Dean Herbert · 2021-11-22 18:52:30 +09:00
  d94b27a8a2
• Move HoverClickSounds to the clickable button
  Susko3 · 2021-11-08 14:32:00 +01:00
  8a23b648fe
• Debounce and schedule updates to key combinations
  Dean Herbert · 2021-11-08 18:29:11 +09:00
  49c26a465c
• Add missing null check
  Dean Herbert · 2021-11-08 18:26:12 +09:00
  b4225804ed
• Shorten variable names
  Dean Herbert · 2021-11-08 18:24:37 +09:00
  f5842e7587
• Revert "Change font to default"

  This reverts commit cc286f165d.

  Dean Herbert · 2021-11-08 18:16:06 +09:00
  82f24b0502
• Change font to default

  Non-english letters look tiny with size 10
  and don't fit into the look.

  Susko3 · 2021-11-08 06:56:57 +01:00
  cc286f165d
• Change to use ReadableKeyCombinationProvider

  Changes all usages of `KeyCombination.ReadableString()` to
  `ReadableKeyCombinationProvider.GetReadableString()`.
  
  Subscribing to `KeymapChanged` is only required in `KeyButton`.
  All other places query `GetReadableString()` every time.

  Susko3 · 2021-11-08 06:55:26 +01:00
  c3069ad002
• Remove grid usage in KeyBindingRow
  Bartłomiej Dach · 2021-10-18 22:07:30 +02:00
  6c3637a62a
• Adjust key binding rows to accommodate new default value indicator
  Bartłomiej Dach · 2021-10-17 21:50:04 +02:00
  552fc1dc8a
• Adjust appearance of keybinding subpanel
  Bartłomiej Dach · 2021-10-10 00:34:12 +02:00
  b8616bf910
• Refine RealmContext implementation API
  Dean Herbert · 2021-09-30 23:56:38 +09:00
  9fa901f6aa
• Add localisation for GlobalActions
  kj415j45 · 2021-09-16 16:02:04 +08:00
  51997fa533