163 Commits

• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Add matching comment in SpectatorClient for clarity
  Dean Herbert · 2025-05-17 23:33:46 +09:00
  7c44883042
• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Allow spectator button to work without begin play requests
  Dean Herbert · 2025-03-16 01:42:02 +09:00
  0bde11b504
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Restore virtual modifier to fix tests (and mark for posterity)
  Bartłomiej Dach · 2025-01-16 15:13:16 +01:00
  1f1e940ada
• Add client methods allowing users to be notified of who is watching them
  Bartłomiej Dach · 2025-01-15 14:18:01 +01:00
  43fc48a3f3
• Send mods in spectator frame headers
  Bartłomiej Dach · 2024-10-07 13:45:34 +02:00
  ec5f5a2336
• Fix SpectatorClient holding references to Player
  Dan Balasescu · 2024-04-03 17:32:02 +09:00
  b5adcf2e0e
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Merge pull request #25522 from bdach/no-concurrent-connections

  Implement flow allowing disconnection from online services when another client instance for same user is detected

  Dean Herbert · 2023-11-28 19:09:38 +09:00
  537c9e031d
• Revert incorrect xmldoc change
  Bartłomiej Dach · 2023-11-27 11:35:10 +09:00
  7f788058cd
• Reduce access to various fields and events in SpectatorClient

  Restore some `virtual` specs to appease Moq

  Dean Herbert · 2023-11-24 14:26:09 +09:00
  ed5375536f
• Centralise and improve messaging around online state

  When the server requests a disconnect due to a user connecting
  via a second device, the client will now log the user out on the first
  device and show a notification informing them of the cause of
  disconnection.

  Bartłomiej Dach · 2023-11-21 15:15:46 +09:00
  42fada578e
• Implement client-side disconnection flow
  Bartłomiej Dach · 2023-11-21 15:15:45 +09:00
  1c612e2e0c
• Make ScoreInfo.BeatmapInfo nullable
  Dean Herbert · 2023-07-04 14:50:34 +09:00
  d74b1e148d
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Pass ScoreProcessorStatistics to FrameHeader, rather than the full processor
  Dean Herbert · 2023-05-29 20:00:42 +09:00
  df662afbd5
• Change statistics type, remove overridability
  Dan Balasescu · 2023-05-23 15:36:34 +09:00
  e1feeded12
• Add score processor statistics to replay header
  Dan Balasescu · 2023-05-19 16:29:24 +09:00
  6c6f8621c1
• Fix multiplayer leaderboard not working
  Dan Balasescu · 2023-05-19 13:16:57 +09:00
  035d0d5c9c
• Add TotalScore to replay frame headers
  Dan Balasescu · 2023-05-18 20:08:49 +09:00
  808818768b
• Initial implementation of ScoreV2
  Dan Balasescu · 2023-05-09 19:33:33 +09:00
  3c3c812ed6
• Fix intermittent failure in tests with restarting player instances
  Salman Ahmed · 2023-01-15 16:06:06 +03:00
  13c1b8f5a4
• Add score processed callback to spectator client
  Bartłomiej Dach · 2022-12-20 21:23:50 +01:00
  b03291330f
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Merge branch 'master' into beginplaying-score-token
  Bartłomiej Dach · 2022-12-13 17:15:24 +01:00
  849245b90c
• Move score token to BeginPlaying
  Dan Balasescu · 2022-12-12 13:59:27 +09:00
  caa0b7c290
• Store maximum statistics to spectator state
  Dan Balasescu · 2022-12-09 20:15:07 +09:00
  e9998f1690
• Add score token to spectator state
  Dan Balasescu · 2022-12-09 19:09:51 +09:00
  4a65f5c864
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Make score type consistent
  maromalo · 2022-11-06 19:59:27 -03:00
  b7ef9b176d
• Silence unobserved exceptions in BeginPlayingInternal

  Closes #20526.

  Dean Herbert · 2022-10-05 14:31:13 +09:00
  74db42394a
• watchedUsers -> watchedUsersRefCounts
  Salman Ahmed · 2022-08-25 09:50:52 +03:00
  6840e906e7
• Fix spectator client not handling multiple watch calls properly
  Salman Ahmed · 2022-08-24 10:02:21 +03:00
  7e5086c8d7
• Revert blocking call when sending spectator frames

  There are a lot of these requests, and we don't really care about
  waiting on them to finish sending. This may have negatively affected
  send performance for users with very high latency.
  
  Reverts part of 0533249d11.
  
  Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.

  Dean Herbert · 2022-07-29 12:24:54 +09:00
  fd09155990
• Reword comment slightly
  Salman Ahmed · 2022-07-25 04:39:14 +03:00
  e0266b0d81
• Fix players potentially not displaying in spectator after restart
  Salman Ahmed · 2022-07-25 04:21:53 +03:00
  f5a5887669
• Fix BeginPlayingInternal firing actual errors when beatmap not available online
  Dean Herbert · 2022-07-19 17:14:57 +09:00
  12e5bc3f3d
• Merge pull request #19189 from peppy/peform-actions-after-reconnect

  Fix creating multiplayer game during server migration not joining new room correctly

  Dan Balasescu · 2022-07-19 14:46:29 +09:00
  c07f78409e
• Update all OnlineSpectatorCalls to InvokeAsync
  Dean Herbert · 2022-07-18 14:34:02 +09:00
  0533249d11
• Perform actions after server reconnection
  Dean Herbert · 2022-07-17 21:09:48 +09:00
  da7edd5d49
• Fix spectator client not correctly reconnecting after shutdown
  Dean Herbert · 2022-07-17 21:07:11 +09:00
  8e7e1e6b51
• Use debug.assert for better readable.
  andy840119 · 2022-07-03 19:27:56 +08:00
  8c2f4b48fc
• Use AsNonNull() instead.
  andy840119 · 2022-07-02 19:48:32 +08:00
  0a1543c6e8
• pretend that the beatmap property will not be null.

  Not really throw exception will be the better way?

  andy840119 · 2022-07-02 13:20:46 +08:00
  c6d0f0f81b
• Handle task exception outside of schedule to avoid unobserved exceptions
  Dean Herbert · 2022-06-28 15:09:28 +09:00
  22b254e5c5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850