234 Commits

• Fix transaction not being disposed
  Dean Herbert · 2022-07-07 18:15:38 +09:00
  ac216d94a8
• Add automatic transaction handling to realm helper methods
  Dean Herbert · 2022-07-07 17:36:25 +09:00
  5197d0fa9e
• Add more verbose logging to realm blocking process
  Dean Herbert · 2022-07-02 12:36:56 +09:00
  4fd47b5fa0
• Merge pull request #18835 from peppy/beatmap-update-flow

  Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow

  Dan Balasescu · 2022-07-01 20:28:04 +09:00
  3b1842a2c2
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-30 19:07:15 +09:00
  447b496eff
• Merge branch 'master' into beatmap-update-flow
  Dean Herbert · 2022-06-30 16:44:17 +09:00
  98938821e5
• Add reproduction of transaction not being exited correctly
  Dean Herbert · 2022-06-30 15:15:09 +09:00
  0abb400f64
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-29 22:39:05 +09:00
  a3b4a515fc
• Add test coverage of async writes during a blocking operation
  Dean Herbert · 2022-06-28 17:07:49 +09:00
  d64959ad0c
• Add test coverage of realm async writes
  Dean Herbert · 2022-06-27 19:38:14 +09:00
  6203885040
• Remove unnecessary Task.Run workaround in tests
  Dean Herbert · 2022-06-27 19:21:05 +09:00
  1fc4fa6820
• Remove unused using statement
  Dean Herbert · 2022-06-27 18:04:52 +09:00
  5af1106fa5
• Update rollback test expectations

  I can't find a better way to do this. It's very hard to trigger an
  actual failure in the import process these days. For now I've just made
  this work with the new assumptions. May be worth removing the test in
  the future if this ever backfires.

  Dean Herbert · 2022-06-27 17:04:35 +09:00
  8c3c1f095e
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Move beatmap processing tasks to new BeatmapUpdater class
  Dean Herbert · 2022-06-24 21:02:37 +09:00
  06d59b717c
• Add timeout for all ManualResetEventSlim.Wait invocations

  Timeout values were taken as best-guesses of upper values we'd expect
  from sane execution.

  Dean Herbert · 2022-06-23 14:46:00 +09:00
  7ef8b7df5f
• Merge pull request #18777 from peppy/output-directory-on-import-failure

  Silence exception and provide more log output when import fails due to empty `.osu` files

  Dan Balasescu · 2022-06-20 17:36:21 +09:00
  c402e90598
• Add test coverage of import throwing when no valid .osu files are found
  Dean Herbert · 2022-06-20 16:06:22 +09:00
  e82d948acc
• Rename Import(TModel) to ImportModel to differentiate from other import methods
  Dean Herbert · 2022-06-20 15:18:07 +09:00
  92f1a2958c
• Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask)
  Dean Herbert · 2022-06-20 15:14:57 +09:00
  a6c8a832aa
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove RealmArchiveModelManager from hierarchy
  Dean Herbert · 2022-06-16 18:53:13 +09:00
  f3984d98e6
• Update usages of BeatmapModelManager which only require importing to use BeatmapImporter
  Dean Herbert · 2022-06-16 17:59:24 +09:00
  84dba36cf5
• Move remaining realm classes out of Stores namespace
  Dean Herbert · 2022-06-15 21:56:00 +09:00
  f23ddfe6cc
• Merge pull request #18689 from peppy/quick-import-only-on-batch

  Always perform full consistency checks for single imports

  Dean Herbert · 2022-06-15 17:06:06 +09:00
  080f2859ef
• Fix test files stream not disposed after creation
  Salman Ahmed · 2022-06-15 08:24:20 +03:00
  3d638abc52
• Add failing test case
  Salman Ahmed · 2022-06-15 07:33:21 +03:00
  ee8045d507
• Re-enable ignored tests that will work again now
  Dean Herbert · 2022-06-15 00:51:08 +09:00
  cac724f436
• Remove custom hash function flow
  Dean Herbert · 2022-06-15 00:42:30 +09:00
  f11fe54385
• Update realm to latest version

  Contains minor changes to async usage in line with upstream API changes.
  
  I believe a feedback issue we were seeing with offset changes (the only
  component using async write flow) may have been resolved by these
  upstream changes (see [release
  notes](https://github.com/realm/realm-dotnet/releases/tag/10.14.0)) but
  am not investigating further just yet.

  Dean Herbert · 2022-06-03 14:16:10 +09:00
  1b4c89c418
• Update unsafe file write usages
  Dean Herbert · 2022-05-16 18:05:27 +09:00
  218642c300
• Add failing test coverage of adding a file to a detached beatmap across threads
  Dean Herbert · 2022-05-10 21:04:30 +09:00
  87f6f74795
• Move all usages of client.realm filename to a single const
  Dean Herbert · 2022-03-30 13:34:48 +09:00
  975883da5c
• Fix realm potentially not being refreshed in time for test asserts in BeatmapImporterTests

  As seen at https://github.com/ppy/osu/runs/5659368512?check_suite_focus=true
  
  Went through every usage of `.Import` and added either an
  `EnsureLoaded`, or where that provides too many checks, an explicit
  `realm.Refresh()`.

  Dean Herbert · 2022-03-24 12:59:17 +09:00
  4d0b4c2541
• Fix beatmap date added not being updated on reimporting a soft deleted beatmap

  Addresses concerns raised in https://github.com/ppy/osu/discussions/17399.

  Dean Herbert · 2022-03-22 14:10:36 +09:00
  0fcb3bdba9
• Add extension method to detect and isolate realm collection-level changes
  Dean Herbert · 2022-03-08 14:50:47 +09:00
  2a55c5e02e
• Add test coverage of proeprty changed subscriptions
  Dean Herbert · 2022-03-03 17:56:49 +09:00
  1485a3a28a
• Add RealmAccess.WriteAsync method
  Dean Herbert · 2022-03-01 18:44:05 +09:00
  9a117467b5
• Update existing usages to point to RealmRulesetStore
  Dean Herbert · 2022-02-16 17:13:54 +09:00
  0138f22c8d
• Remove pointless constructor in RulesetInfo
  Dean Herbert · 2022-01-27 15:37:27 +09:00
  714177cce1
• Fix completely invalid method of testing realm migration
  Dean Herbert · 2022-01-26 19:03:26 +09:00
  abe2cccaae
• Merge branch 'master' into fix-out-of-order-events-on-block-fail
  Dean Herbert · 2022-01-26 15:21:10 +09:00
  91e0d1021f
• Remove ILive<> interface (and use abstract Live<> instead)
  Dean Herbert · 2022-01-26 13:38:56 +09:00
  cd71ec0edd
• Remove synchronization context hacks in realm tests
  Dean Herbert · 2022-01-25 17:41:22 +09:00
  ffd7877a1e
• Merge pull request #16604 from peppy/less-async-import

  Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter`

  Dan Balasescu · 2022-01-25 16:47:07 +09:00
  d8270fe14f
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Fix compilation issues due to misnamed fild
  Dean Herbert · 2022-01-25 15:29:45 +09:00
  ae0fea8e26
• Merge branch 'master' into realm-block-timeout-assert-failure
  Dean Herbert · 2022-01-25 15:05:11 +09:00
  35e1c7de7d
• Merge branch 'master' into realm-block-timeout-assert-failure
  Dean Herbert · 2022-01-25 14:47:34 +09:00
  bda77fb6b3
• Fix broken test due to SynchronizationContext never running expected work
  Dean Herbert · 2022-01-25 14:47:21 +09:00
  56d7d81465