305 Commits

• Fix grammar in comment
  Bartłomiej Dach · 2025-08-05 10:48:17 +02:00
  50daae399b
• Fix special cases of mania beatmaps not playing sliding samples

  Apparently mania sliders are a thing. See https://github.com/ppy/osu/pull/34500#issuecomment-3150610188

  Salman Alshamrani · 2025-08-05 10:25:39 +03:00
  03dae97ff3
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy
  diquoks · 2025-06-21 21:01:48 +03:00
  cad4382350
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1
• Introduce numeric value in beatmap hit count statistics
  Salman Alshamrani · 2025-04-12 00:14:53 +09:00
  85556e0c3e
• Shorten beatmap hit statistics names
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  1dbcbbde15
• Fix incorrect lastPattern value

  In particular, mania-specific beatmaps that normally go via the
  "passthrough" generator should not adjust the stored pattern value.
  
  The "spinner" generator, which was previously intended to be used for
  non-mania-specific beatmaps, is now valid even for mania-specific
  beatmaps, and uses this value.
  
  In other words, another way of writing this would be:
  ```csharp
  if (conversion is SpinnerPatternGenerator || conversion is
  PassThroughPatternGenerator) ? lastPattern : newPattern;
  ```

  Dan Balasescu · 2024-12-13 16:08:12 +09:00
  d597232c2a
• Handle non-legacy types

  Also used in some tests (e.g. beatmaps containing `HitCircle`s).

  Dan Balasescu · 2024-12-06 17:47:49 +09:00
  ec8b320e21
• NRT refactorings + rename generators to match usage

  In particular, "EndTimeObject" is no longer correct - it's strictly used
  for spinners and not holds.

  Dan Balasescu · 2024-12-06 17:16:04 +09:00
  e703d9e814
• Add some explanatory comments

  In particular, the spinner one is the most relevant to this batch of
  changes.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  1bbf32d567
• Rename LegacyPatternGenerator to stop naming conflicts
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e8728abc00
• Simplify implementation
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e65f8ba7a0
• Split out + rename PassThroughPatternGenerator

  Better symbolises the intent of this generator which is to convert
  hitobjects in their most simple forms - anything with an end time
  converts to a hold or otherwise converts to a normal note.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  8e1bd98386
• Always convert mania spinners

  A big part of these changes is refactoring, which is somewhat necessary
  because it was previously implemented as two separate pathways which
  in-fact need to be joined at the hip when handling spinners.
  
  I've chosen to use `IHasLegacyHitObjectType` here because there's no
  other flag that allows us to tell `ConvertHold` apart from
  `ConvertSpinner`.

  Dan Balasescu · 2024-12-06 16:40:28 +09:00
  8b456e1379
• Fix osu!mania hold notes playing a sound at their tail in the editor

  Closes #29584.

  Dean Herbert · 2024-08-27 14:06:02 +09:00
  9840a07eaf
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Fully qualify LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-04-01 17:02:32 +09:00
  8e0ca11d1c
• Remove unused OriginalTargetColumns
  Dan Balasescu · 2024-03-28 22:51:13 +09:00
  ce21235db4
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Refactor pattern generation to not require ManiaBeatmap
  Dan Balasescu · 2024-03-28 22:32:27 +09:00
  64399e9dd9
• Refactor usage of object counts for mania key count lookup to be a bit safer

  Protects against non-initialised values and also div-by-zero.

  Dean Herbert · 2023-12-19 18:28:04 +09:00
  372f930f8b
• Merge branch 'master' into mania-convert-song-select-keycount
  Dan Balasescu · 2023-12-13 13:53:50 +09:00
  6ed5613c22
• Simplify implementation
  Dan Balasescu · 2023-12-13 13:43:14 +09:00
  2930b53edd
• Add keycount to song select details panel and carousel panels
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  b36db3518c
• Fix osu!mania converted key count edge cases
  Dan Balasescu · 2023-12-09 15:39:54 +09:00
  81fe15f288
• Re-fix mania conversion following new discoveries
  Dan Balasescu · 2023-12-08 16:33:10 +09:00
  0fe2e1e8d6
• Fix FP precision issue when converting mania beatmaps
  Dan Balasescu · 2023-12-07 12:26:02 +09:00
  d6cb8b70bb
• Use IHasPath instead of IHasDistance for mania/taiko
  Dan Balasescu · 2023-11-29 17:30:21 +09:00
  1c3bcbd548
• Fix mania and taiko slider conversion distance
  Dan Balasescu · 2023-11-28 21:14:56 +09:00
  16577829e2
• Add LegacyBeatmapConversionDifficultyInfo abstraction
  Dan Balasescu · 2023-10-02 16:52:01 +09:00
  b4b7a7ea5e
• Make not extension method
  Dean Herbert · 2023-09-15 18:13:04 +09:00
  56cc2b62f0
• Move to extension method and throw on non-legacy ruleset
  Dean Herbert · 2023-09-15 17:38:34 +09:00
  0031da76ff
• Make rounding error even less precise

  Basically matching the old code more closely to avoid too much precision
  from doing math in a slightly different way.

  Dean Herbert · 2023-09-12 18:41:09 +09:00
  4ecc4632aa
• Remove braces
  Bartłomiej Dach · 2023-09-07 18:47:03 +02:00
  e71fef4b6a
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Optimise mania density calculation during beatmap conversion
  Dan Balasescu · 2023-06-15 20:00:15 +09:00
  145530035c
• removing using
  OliBomby · 2023-04-26 13:22:13 +02:00
  39d9f0c3f5
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• clean up code stuff
  OliBomby · 2023-04-25 19:06:29 +02:00
  e4b64bdc3e
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Add method to get stage from column index
  Dean Herbert · 2022-10-07 15:24:37 +09:00
  dee01abab1
• Move column initialisation to ctor and fix remaining tests
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  2ae1aef0be
• Cache StageDefinition for consumption (and remove ColumnType)
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  7796a4c109
• Move ColumnType to constructor
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  df3ad618e1