70 Commits

• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Add failing test case
  Salman Ahmed · 2024-08-20 12:39:41 +09:00
  a3234e2cde
• Merge pull request #26254 from frenzibyte/mania-combo-counter

  Add argon/classic osu!mania combo counter

  Dean Herbert · 2024-08-15 17:56:28 +09:00
  5710f0f302
• Merge branch 'master' into mania-combo-counter
  Dean Herbert · 2024-08-14 15:12:00 +09:00
  e465049050
• Remove legacy non-pooled pathway to DrawableJudgement
  Dean Herbert · 2024-08-13 21:03:00 +09:00
  2221c4891f
• Merge branch 'master' into mania-combo-counter
  Dean Herbert · 2024-08-09 00:19:17 +09:00
  e645651ef4
• Fix tests
  clayton · 2024-08-07 14:36:04 -07:00
  48d9bc982f
• Fix failing tests due to pooling safety changes
  Dean Herbert · 2024-01-21 12:17:16 +09:00
  18d16018d3
• Add various visual test coverage
  Salman Ahmed · 2023-12-30 05:29:44 +03:00
  95961dc989
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Allow toggling SVs in the editor
  Dan Balasescu · 2023-08-18 18:55:24 +09:00
  a2fd7707a1
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Add better test coverage of dual stages in skinnable tests
  Bartłomiej Dach · 2023-06-17 10:27:43 +02:00
  688e65475d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Remove broken KeyArea test scene

  Use `TestSceneStage` instead.

  Dean Herbert · 2022-10-07 20:05:13 +09:00
  a4f827c7fd
• Remove pointless colour specifications in test scenes
  Dean Herbert · 2022-10-07 15:45:35 +09:00
  6f8533ef6b
• Make Column.AccentColour bindable
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  6b79f16461
• Move column initialisation to ctor and fix remaining tests
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  2ae1aef0be
• Remove unnecessary Beatmap parameter in ManiaLegacySkinTransformer
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  1a0b953846
• Remove StageDefinition flow in ManiaSkinComponent
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  46c3cfe54d
• Cache StageDefinition for consumption (and remove ColumnType)
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  7796a4c109
• Move ColumnType to constructor
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  df3ad618e1
• Add test scene for visually adjusting mania BarLines
  Dean Herbert · 2022-08-08 17:38:46 +09:00
  d3ee2a0b8e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove index ctor param from ColumnHitObjectArea

  No longer used since 5692cecaa4.

  Bartłomiej Dach · 2022-02-01 21:49:52 +01:00
  e4028b8fc1
• Fix drawable mania judgement scene looking broken
  Bartłomiej Dach · 2022-01-16 18:56:21 +01:00
  093b76e0ff
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Fix mania hitobject tests
  smoogipoo · 2021-09-15 15:22:27 +09:00
  f9af24df23
• Update existing function type rather than adding an override
  Dean Herbert · 2021-06-02 16:04:53 +09:00
  f8ae70e562
• Initial implementation of DHO pooling
  smoogipoo · 2021-05-12 16:35:05 +09:00
  5692cecaa4
• Adjust namespace
  ekrctb · 2020-12-07 12:32:52 +09:00
  e3c035fe9c
• Merge branch 'master' into legacy-jugement-match-stable-transforms
  Bartłomiej Dach · 2020-11-18 20:33:58 +01:00
  24d7fa03d8
• Fix whitespace issues
  Dean Herbert · 2020-11-18 19:47:35 +09:00
  191b95810c
• Fix mania misses not correctly animating (temporary solution)
  Dean Herbert · 2020-11-18 19:34:00 +09:00
  20bb64c627
• Add test case for fading hold note
  Bartłomiej Dach · 2020-11-13 20:52:15 +01:00
  2ccc81ccc0
• Move drawable instatiation to [SetUp]
  Bartłomiej Dach · 2020-11-13 20:52:15 +01:00
  2f33aeac9f
• Fix tests specifying steps in their constructors
  Dean Herbert · 2020-10-02 18:23:18 +09:00
  1a0171fb2d
• Merge branch 'master' into hold-note-lighting
  smoogipoo · 2020-08-26 20:22:07 +09:00
  1db836e9e0
• Make hitobject tests display the column
  smoogipoo · 2020-08-26 20:00:38 +09:00
  e6116890af
• Fix tests
  smoogipoo · 2020-08-25 14:49:29 +09:00
  7e9567dae9
• Fix test scene and add pooling support
  smoogipoo · 2020-07-29 16:25:17 +09:00
  e5ebd21156
• tidy up code
  mcendu · 2020-06-13 11:31:34 +08:00
  aa476835e7
• fix tests incorrectly showing judgements not present in mania
  mcendu · 2020-06-12 23:06:19 +08:00
  7def6a9181
• Remove all RequiredTypes usages
  smoogipoo · 2020-05-16 18:17:12 +09:00
  648999a2de
• Add test
  smoogipoo · 2020-04-21 17:15:13 +09:00
  4642a6093c
• Implement bottom stage image
  smoogipoo · 2020-04-08 16:20:54 +09:00
  83db6cebb6
• Initial structure
  smoogipoo · 2020-04-08 15:35:37 +09:00
  e429c274a9