1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 22:27:25 +08:00
Commit Graph

58953 Commits

Author SHA1 Message Date
tsrk
11d0e185b8
refactor: separate impl of KeyCounterDisplay
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
tsrk
74a58fb674
refactor: separate things in KeyCounter
To implement different different sources of input for KeyCounter, it
is now possible to create a Trigger class (to inherit) instead of
inheriting KeyCounter. This eases the creation of more input sources
(like for tests) while allowing to implement different UI variants.

That way, if another variant of the key counter needs to implemented
(for whathever reason), this can be done by only inheriting KeyCounter
and changing how things are arranged visually.
2023-02-13 01:24:27 +00:00
Bartłomiej Dach
8fb72b971d
Merge pull request #22597 from peppy/editor-select-timing-on-enter
Automatically select the closest timing point on entering the timing screen
2023-02-11 17:08:08 +01:00
Bartłomiej Dach
774eae98cc
Merge branch 'master' into editor-select-timing-on-enter 2023-02-11 16:27:22 +01:00
Bartłomiej Dach
a3cc0d23b3
Fix typo in xmldoc 2023-02-11 16:26:32 +01:00
Bartłomiej Dach
7b2c5ab7eb
Merge pull request #22608 from peppy/update-dependencies
Update realm and other dependencies
2023-02-11 12:37:02 +01:00
Bartłomiej Dach
ebf469272f
Merge pull request #22544 from peppy/fix-change-join-leave-loop
Attempt to fix channel join / leave loop
2023-02-11 12:26:26 +01:00
Dean Herbert
20f3ab167e Re-centralise BannedApiAnalysers nuget package 2023-02-11 19:36:40 +09:00
Bartłomiej Dach
8292052dc2
Merge pull request #22598 from peppy/fix-skip-intro-replay
Fix "skip" key binding no longer working in replay playback
2023-02-11 11:27:10 +01:00
Dean Herbert
0c5dae5f26
Merge pull request #22529 from ItsShamed/dsc/presence
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
Dean Herbert
86c8675910 Update realm and other dependencies 2023-02-11 13:52:24 +09:00
Dean Herbert
463e8221e0
Merge pull request #22600 from Terochi/song-progress-time-left-fix
Song progress incorrectly displaying `timeLeft` counter after rotation
2023-02-11 13:19:06 +09:00
Dean Herbert
2ecc3e773b
Merge pull request #22607 from Joehuu/fix-skin-component-one-frame-sizing
Fix skin component previews on toolbox buttons having incorrect size for one frame
2023-02-11 12:49:37 +09:00
Joseph Madamba
bfd83768c1 Fix skin component previews on toolbox buttons having incorrect size for one frame 2023-02-10 17:58:34 -08:00
Bartłomiej Dach
65bb3a5cad
Merge pull request #22588 from Joehuu/fix-clickable-avatar-bloat
Remove code bloat from `ClickableAvatar`
2023-02-10 22:07:49 +01:00
Bartłomiej Dach
75e19bb89f
Merge branch 'master' into fix-clickable-avatar-bloat 2023-02-10 21:30:40 +01:00
Bartłomiej Dach
11296c4ffe
Use better exception type 2023-02-10 21:25:19 +01:00
Terochi
81c3e0da31 Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation 2023-02-10 17:58:48 +01:00
Dean Herbert
5c795f492f Reorder game key bindings to allow skip overlay to have precedence over replay controls 2023-02-10 18:57:21 +09:00
Dean Herbert
96fbd04698 Add failing test coverage of skip no longer working in replay playback 2023-02-10 18:57:04 +09:00
Dean Herbert
4f7d26b776 Actually apply new parameter 2023-02-10 18:29:39 +09:00
Dean Herbert
6d876fdb9a Automatically select the closest timing point on entering the timing screen 2023-02-10 17:48:56 +09:00
Dean Herbert
03e623d1d2 Move ControlPointList to own file 2023-02-10 17:37:31 +09:00
Dean Herbert
ad8b01b478
Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions
Always add to additions soundbank in `convertSoundType`
2023-02-10 17:14:29 +09:00
Dean Herbert
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
Dean Herbert
1df6fc6311 Use if statements rather than conditional case 2023-02-10 17:03:27 +09:00
Dean Herbert
f70614aa8b
Merge pull request #22587 from sw1tchbl4d3r/taiko_large_bonus
Make `LargeBonus` a valid `HitResult` in taiko
2023-02-10 17:00:53 +09:00
Dean Herbert
199fb0fd85 Apply NRT to ClickableAvatar and UpdateableAvatar 2023-02-10 16:32:58 +09:00
Dean Herbert
5866b67a5b Simplify tooltip implementation 2023-02-10 16:24:44 +09:00
Dean Herbert
68c37585e5 Use string.Empty instead of default 2023-02-10 16:22:06 +09:00
Joseph Madamba
a86f06df96 Add back Enabled checks to TooltipText and OnClick to fix guest case 2023-02-09 17:00:32 -08:00
Bartłomiej Dach
96c1832af4
Fix grammar in xmldoc
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2023-02-10 00:07:24 +01:00
sw1tchbl4d3
51816b92c6 Add conversion tests 2023-02-09 23:23:58 +01:00
sw1tchbl4d3
f0d11f44fc Always add to additions soundbank in convertSoundType 2023-02-09 22:27:52 +01:00
Joseph Madamba
0b41dbf579 Remove code bloat from ClickableAvatar 2023-02-09 12:59:26 -08:00
sw1tchbl4d3
2e2ab4081b Make LargeBonus a valid HitResult in taiko 2023-02-09 21:22:34 +01:00
Ruki
2c1154afc6
refactor: improve wording
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-09 17:15:30 +00:00
Dean Herbert
ab81397119
Merge pull request #22553 from OpenSauce04/taiko-stable-snapping
Snap Taiko hit objects to match Stable
2023-02-09 23:28:21 +09:00
Dean Herbert
34d1890f1c Change snapping to only apply to classic mod 2023-02-09 18:22:14 +09:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Dean Herbert
92eb6b6717 Simplify TestSceneAccuracyCircle test specifications 2023-02-09 15:42:03 +09:00
Dean Herbert
cf009432cc Centralise accuracy cutoff constants and add lookup helper methods 2023-02-09 15:41:58 +09:00
Dean Herbert
240a5f9c85
Merge pull request #22568 from Joehuu/address-init-only-todo
Address todos relating to init-only usages
2023-02-09 12:17:54 +09:00
Joseph Madamba
f1decb667e Address todos relating to init-only usages 2023-02-08 17:51:28 -08:00
Walavouchey
57312279f0 adjust RankNotch gap size to match original value 2023-02-09 02:20:05 +01:00
Joseph Madamba
3b5d573db1 Display tournament banner on user profile 2023-02-08 17:16:09 -08:00
Walavouchey
fd93bd3f50 move rank accuracy requirements to class-local constants 2023-02-09 00:46:24 +01:00
Walavouchey
9544a1d26d use values closer to the extremities for test cases 2023-02-09 00:02:32 +01:00
Walavouchey
ee40444fd3 use Precision.AlmostEquals for bounds check 2023-02-08 23:59:19 +01:00
Bartłomiej Dach
2873905cc6
Merge pull request #22506 from peppy/skin-editor-undo-support
Add very basic skin editor undo / redo support
2023-02-08 19:19:25 +01:00