50343 Commits

This Branch

This Branch

All Branches

• Fix potential null ref if UpdateTargetScreen is called too early
  Dean Herbert · 2022-04-07 23:42:42 +09:00
  11b4c5ca87
• Fix multiple issues with bindable safety in SkinEditor components
  Dean Herbert · 2022-04-07 19:12:12 +09:00
  a4d3afd06d
• Merge pull request #17700 from peppy/fix-skin-lookups-extension-specified

  Fix filename lookups on `LegacySkin`s going awry when extension is specified

  Dan Balasescu · 2022-04-07 17:03:27 +09:00
  f0698937b7
• Merge pull request #17701 from peppy/fix-storyboard-animation-sizing

  Fix storyboard animations getting incorrect positioning due to size not being set

  Dan Balasescu · 2022-04-07 17:00:39 +09:00
  5af93bd85d
• Fix DrawableStoryboardAnimation not specifying sizing correctly

  Usually this would be handled by `TextureAnimation`, but because we are
  inheriting from `DrawableAnimation` here for reasons, we needed to
  implement this ourselves. Follows the implementation in
  `TextureAnimation`.

  Dean Herbert · 2022-04-07 15:18:55 +09:00
  a7e262627f
• Merge pull request #17698 from Joehuu/fix-replay-button-local-being-disabled

  Fix replay button being disabled when available locally but not online

  Dean Herbert · 2022-04-07 14:18:02 +09:00
  eb0653fa7b
• Fix filename lookups on LegacySkins going awry when extension is specified

  Due to the logic present to handle `@2x` fallback, the extension was
  potentially being added at the wrong point in the filename. This change
  ensures that the lookup filenames are always correct.
  
  Closes https://github.com/ppy/osu/issues/17690.

  Dean Herbert · 2022-04-07 14:16:19 +09:00
  205edb65a2
• Merge pull request #17699 from nekodex/mp-countdown-sfx-2

  Add MP lobby 'warning' SFX for the final seconds of countdown

  Dean Herbert · 2022-04-07 14:13:29 +09:00
  04235ca76e
• Add test coverage of skin lookups failing when @2x and extension are present
  Dean Herbert · 2022-04-07 14:11:38 +09:00
  b7f8716de9
• Update resources
  Dean Herbert · 2022-04-07 13:35:07 +09:00
  9ed4f31048
• Move enabled setting to each case
  Joseph Madamba · 2022-04-06 21:22:56 -07:00
  358931842f
• Add MP lobby 'warning' SFX for the final seconds of countdown
  Jamie Taylor · 2022-04-07 13:12:33 +09:00
  8a73831115
• Fix replay button being disabled when available locally but not online
  Joseph Madamba · 2022-04-06 20:43:56 -07:00
  4432a93d09
• Add failing replay button enabled test asserts
  Joseph Madamba · 2022-04-06 20:43:56 -07:00
  edb556643e
• Merge pull request #17631 from bdach/mod-overlay/full-screen

  Implement basic layout & behaviour of new mod select screen

  Dan Balasescu · 2022-04-07 10:23:49 +09:00
  c997d0fcf0
• Merge pull request #17683 from huoyaoyuan/remove-outdated

  Remove some outdated packages

  Dan Balasescu · 2022-04-07 10:13:15 +09:00
  4c20e67478
• Merge pull request #17678 from peppy/get-virtual-time-length

  Change `WorkingBeatmap.GetVirtualTrack` to use length provided by `BeatmapInfo`

  Dan Balasescu · 2022-04-07 09:32:59 +09:00
  c440d89ef9
• Merge pull request #17576 from peppy/fix-multiplayer-unobserved

  Centralise exception handling of `MultiplayerClient` calls

  Dan Balasescu · 2022-04-07 09:09:55 +09:00
  4b3569ea79
• Merge pull request #17677 from peppy/fix-multiplayer-match-song-select-realm

  Fix dangerous realm operation in `TestSceneMultiplayerMatchSongSelect`

  Bartłomiej Dach · 2022-04-06 22:28:57 +02:00
  4f928232ee
• Merge branch 'master' into fix-multiplayer-match-song-select-realm
  Bartłomiej Dach · 2022-04-06 21:58:12 +02:00
  bcb9eef082
• Remove outdated NETCore packages.
  Huo Yaoyuan · 2022-04-06 19:18:18 +08:00
  ec4f1bcbc8
• Remove outdated NU1701 warning.
  Huo Yaoyuan · 2022-04-06 19:14:00 +08:00
  43724f477a
• Merge pull request #17679 from peppy/ensure-intro-is-protected

  Ensure intro beatmap has protected flag set

  Dan Balasescu · 2022-04-06 19:06:41 +09:00
  2c8fcadb97
• Ensure intro beatmap has protected flag set

  In cases this isn't set, the beatmap has likely entered a bad state.
  
  Closes https://github.com/ppy/osu/issues/17659.

  Dean Herbert · 2022-04-06 16:46:53 +09:00
  c42ef43faa
• Fix back-to-front conditional check
  Dean Herbert · 2022-04-06 15:13:02 +09:00
  2b8a5833dd
• Replace a couple more local test beatmap cases which can instead use TestResources methods
  Dean Herbert · 2022-04-06 15:04:15 +09:00
  d17890ca9a
• Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo

  A lot of tests are using test resources that populate the length field,
  but do not populate hitobjects. The general expectation is that
  components should be using the cached length in cases where hitobjects
  are not relevant, but `GetVirtualTrack` was doing its own local
  calculation.
  
  This could cause tests to fail due to `MusicController` changing track
  in the background.

  Dean Herbert · 2022-04-06 14:51:15 +09:00
  552ec5282f
• Fix dangerous realm operation in TestSceneMultiplayerMatchSongSelect

  The import process was running on the async load thread, but then
  accessed from the access thread later on. This seemed to somehow pass
  fine in headless runs, but would fail on visual test execution
  (specifically on `TestBeatmapConfirmed()`).

  Dean Herbert · 2022-04-06 14:01:41 +09:00
  220d7bc6db
• Add missing newline
  Dean Herbert · 2022-04-06 14:00:54 +09:00
  f795f77cf9
• Merge branch 'master' into fix-multiplayer-unobserved
  Dean Herbert · 2022-04-06 11:33:10 +09:00
  c540810943
• Simplify IsCurrentScreen check to only apply to relevant call
  Dean Herbert · 2022-04-06 11:32:35 +09:00
  01da3924cc
• Merge branch 'master' into mod-overlay/full-screen
  Bartłomiej Dach · 2022-04-05 21:29:40 +02:00
  9c91e6d8f5
• Add missing newline
  Dean Herbert · 2022-04-05 19:25:47 +09:00
  ac799aaf7a
• Use newly exposed framework helper function to find closest parent
  Dean Herbert · 2022-04-05 19:24:34 +09:00
  32daf64a31
• Remove left padding to allow left-most column to exist further to the.. left
  Dean Herbert · 2022-04-05 18:44:25 +09:00
  631aa2a6ec
• Adjust animation metrics slightly
  Dean Herbert · 2022-04-05 18:41:01 +09:00
  54715885af
• Fix multiplier display resetting transformations
  Dean Herbert · 2022-04-05 18:40:48 +09:00
  7a1820e6bb
• Animate individual ModColumns during togle of oerlay
  Dean Herbert · 2022-04-05 18:27:34 +09:00
  9fdeb20537
• Animate multiplier display
  Dean Herbert · 2022-04-05 18:25:27 +09:00
  901032bfa2
• Merge pull request #17597 from peppy/skin-editor-import-at-cursor

  Import new skin editor sprites to the cursor location

  Dan Balasescu · 2022-04-05 18:09:00 +09:00
  2022.405.0 6b0392f990
• Merge branch 'master' into skin-editor-import-at-cursor
  Dan Balasescu · 2022-04-05 17:39:11 +09:00
  7623f3b90b
• Merge pull request #17596 from peppy/skin-editor-sprites

  Allow importing sprites into a skin via drag-and-drop

  Dan Balasescu · 2022-04-05 17:38:58 +09:00
  2b59f76b2d
• Slightly adjust scroll handling and also apply to ModSettingsContainer
  Dean Herbert · 2022-04-05 17:19:33 +09:00
  497e5e3a36
• Limit FillFlow of columns to applicable direction
  Dean Herbert · 2022-04-05 17:15:05 +09:00
  a408776734
• Speed up customisation panel toggle a bit
  Dean Herbert · 2022-04-05 16:56:24 +09:00
  388322cd61
• Simplify and better comment nested scroll conditionals
  Dean Herbert · 2022-04-05 16:48:25 +09:00
  58e9147b12
• Fix lookup through transformers
  Dan Balasescu · 2022-04-05 16:47:15 +09:00
  2ec15a1ebe
• Improve nested scroll behaviour
  Dean Herbert · 2022-04-05 16:46:09 +09:00
  f156cb797d
• Move scroll view padding to content level

  Without doing this, there is a non-masked but also non-interactive area
  to the left or right of the view.

  Dean Herbert · 2022-04-05 16:43:00 +09:00
  23dad7bdc4
• Merge pull request #17604 from nekodex/mp-countdown-sfx

  Add SFX for multiplayer lobby countdown timer

  Dan Balasescu · 2022-04-05 16:40:26 +09:00
  c973d33bfd