46986 Commits

This Branch

This Branch

All Branches

• Merge pull request #15941 from ColdVolcano/correct-effects

  Fix BeatSyncedContainer using wrong EffectControlPoint when early activating

  Bartłomiej Dach · 2021-12-05 13:27:17 +01:00
  1028ec101d
• Add test coverage
  ColdVolcano · 2021-12-05 03:53:36 -06:00
  86c908c657
• Use correct effect points when EarlyActivationMilliseconds is not zero
  ColdVolcano · 2021-12-04 22:31:55 -06:00
  81215b9f0e
• Merge pull request #15936 from peppy/multiplayer-room-composite-event-debounce-fix

  Don't debounce `MultiplayerRoomComposite` events

  Bartłomiej Dach · 2021-12-04 18:17:18 +01:00
  7f68d81c85
• Merge branch 'master' into multiplayer-room-composite-event-debounce-fix
  Bartłomiej Dach · 2021-12-04 17:50:32 +01:00
  504210a6cd
• Merge pull request #15934 from bdach/fix-locale-dependent-replay-encoding

  Fix lazer replays not importing correctly on some locales

  Dean Herbert · 2021-12-05 01:46:49 +09:00
  92efe8a0db
• Don't debounce MultiplayerRoomComposite events

  This avoids accidental usage which could result in data being lost or
  ignored (as only the last `user` in a single frame would arrive).
  
  This was added specifically to debounce sample playback, but given that
  it's only debouncing on a single frame (hardly noticeable) I'm not going
  to add back support for that yet. It should be handled by sample
  playback concurrency or something more local to the usage.

  Dean Herbert · 2021-12-05 01:38:39 +09:00
  e1897f9998
• Fix score encoder being dependent on current culture

  As it turns out, on some cultures, the "negative integer" sign is not
  encoded using the U+002D HYPHEN-MINUS codepoint. For instance, Swedish
  uses U+2212 MINUS SIGN instead. This was confusing the legacy decoder,
  since it is correctly depending on the serialisation being
  culture-independent.
  
  To fix, ensure that the special "end replay" frame, as well as the
  replay MD5 hash, are generated in a culture-invariant manner.
  
  Thankfully the replay MD5 hash is currently being discarded in
  `LegacyScoreDecoder`, so it changing in future scores should not have
  any negative effect on lazer operation.

  Bartłomiej Dach · 2021-12-04 17:13:43 +01:00
  f051720fa1
• Add failing test case
  Bartłomiej Dach · 2021-12-04 17:13:43 +01:00
  ea6766d940
• Merge pull request #15919 from peppy/i-ruleset-store

  Add `IRulesetStore` to allow for transitional usage in upcoming manager classes

  Dean Herbert · 2021-12-05 00:01:40 +09:00
  70e818ff8f
• Revert tournament beatmap panel test change with comment
  Bartłomiej Dach · 2021-12-04 15:33:02 +01:00
  054543f58f
• Merge branch 'master' into i-ruleset-store
  Bartłomiej Dach · 2021-12-04 15:05:39 +01:00
  38702beabf
• Add null check to resolve inspection
  Bartłomiej Dach · 2021-12-04 14:55:35 +01:00
  53a6ef22ce
• Simplify slightly redundant assertions
  Bartłomiej Dach · 2021-12-04 14:42:01 +01:00
  16fd7f5a28
• Merge pull request #15890 from smoogipoo/new-multiplayer-playlist

  Implement multiplayer playlist with gameplay and historical ordering

  Dean Herbert · 2021-12-04 20:29:17 +09:00
  2021.1204.0 b5e5c75a0a
• Merge branch 'master' into new-multiplayer-playlist
  Dean Herbert · 2021-12-04 13:16:09 +09:00
  517a344bcc
• Merge pull request #15845 from smoogipoo/diffcalc-cli-arg

  Add legacy IPC endpoint for difficulty calculation

  Dean Herbert · 2021-12-04 12:09:35 +09:00
  07583a54e5
• Add serialisation/deserialisation explanation
  Dan Balasescu · 2021-12-03 21:29:20 +09:00
  34b0e374d8
• Remove unused event
  Dan Balasescu · 2021-12-03 20:35:47 +09:00
  9acc0556a4
• Merge branch 'master' into diffcalc-cli-arg
  Dan Balasescu · 2021-12-03 20:34:59 +09:00
  f4e07f1483
• Give playlist items a PlayedAt date
  Dan Balasescu · 2021-12-03 20:25:51 +09:00
  d5803e541b
• Merge pull request #15920 from peppy/clean-up-unused-resolves

  Clean up unused resolved properties

  Dan Balasescu · 2021-12-03 20:08:48 +09:00
  4145a16d5b
• Merge pull request #15918 from peppy/volume-adjust-during-gameplay-alt-exception

  Fix alt-scroll not adjusting volume in gameplay when scroll wheel is disabled

  Dan Balasescu · 2021-12-03 19:09:20 +09:00
  e350c68b5f
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Remove many unused resolutions of RulesetStore
  Dean Herbert · 2021-12-03 18:16:29 +09:00
  2acf46154a
• Cache and consume IRulesetStore where feasible
  Dean Herbert · 2021-12-03 18:16:01 +09:00
  e75e209053
• Add missing equality implementations on IRulesetInfo
  Dean Herbert · 2021-12-03 18:01:45 +09:00
  15db1372aa
• Add IRulesetStore to allow for transitional usage in upcoming manager classes
  Dean Herbert · 2021-12-03 17:57:40 +09:00
  675ecb603f
• Merge pull request #15915 from peppy/tournament-bracket-parsing-fix

  Fix `bracket.json` potentially getting saved after parsing failure

  Dan Balasescu · 2021-12-03 17:36:08 +09:00
  7084ef5245
• Merge pull request #15916 from peppy/dont-send-unnecessary-params-beatmap-get

  Avoid sending empty parameters in `GetBeatmapRequest`

  Dan Balasescu · 2021-12-03 17:33:58 +09:00
  637852a2aa
• Stop Player from blocking volume adjust when Alt it held

  Similar case to what we already have in `OsuScrollContainer`, so there
  is precedent for handling this locally in this fashion.

  Dean Herbert · 2021-12-03 17:18:07 +09:00
  6b73672403
• Reword mouse wheel disable setting to better explain its purpose
  Dean Herbert · 2021-12-03 17:18:07 +09:00
  aaa46960b3
• Add test coverage of mouse wheel scroll adjusting volume
  Dean Herbert · 2021-12-03 17:18:07 +09:00
  2927b235de
• Update TestMultiplayerClient with expired item ordering
  Dan Balasescu · 2021-12-03 17:01:33 +09:00
  9d6fe558c2
• Split out code so base methods aren't called
  Dan Balasescu · 2021-12-03 16:40:20 +09:00
  487a71312e
• Avoid sending empty parameters in GetBeatmapRequest
  Dean Herbert · 2021-12-03 16:23:39 +09:00
  dad5b06e84
• Avoid saving bracket if parsing failed, at all costs
  Dean Herbert · 2021-12-03 16:06:38 +09:00
  5158736839
• Centralise specification of bracket.json filename
  Dean Herbert · 2021-12-03 16:04:11 +09:00
  ba05a0a383
• Apply nullable
  Dean Herbert · 2021-12-03 15:51:00 +09:00
  f9ad307526
• Remove Console.WriteLine usage
  Dean Herbert · 2021-12-03 15:48:53 +09:00
  79d723172a
• Split out ruleset lookup code
  Dean Herbert · 2021-12-03 15:48:53 +09:00
  33992e11e0
• Adjust logging to avoid using tabs
  Dean Herbert · 2021-12-03 15:48:53 +09:00
  2262b7b331
• Remove gameplay_order, use existing playlist_order
  Dan Balasescu · 2021-12-03 15:45:13 +09:00
  0a1304b92a
• Merge branch 'master' into diffcalc-cli-arg
  Dean Herbert · 2021-12-03 15:10:55 +09:00
  9c717ce7ec
• Merge pull request #15909 from peppy/update-deps

  Update framework and resources

  Dan Balasescu · 2021-12-03 15:09:46 +09:00
  bd5140cbdf
• Update history list to also sort by gameplay order
  Dan Balasescu · 2021-12-03 15:05:56 +09:00
  b75a5b778e
• Add UpdatedAt to MultiplayerPlaylistItem
  Dan Balasescu · 2021-12-03 15:05:56 +09:00
  1d2d1bfcf3
• Update IPC usage to return null
  Dean Herbert · 2021-12-03 14:30:15 +09:00
  9803e63e6f
• Update resources
  Dean Herbert · 2021-12-03 14:26:53 +09:00
  6142566974
• Update framework
  Dean Herbert · 2021-12-03 14:18:03 +09:00
  abf7735b84