98 Commits

• Dispose previous waveform on track reload
  Salman Ahmed · 2022-12-23 00:35:59 +03:00
  30de9ba795
• Bind to clock instead of music controller
  ansel · 2022-12-22 15:35:53 +03:00
  f2e8776529
• Listen for track reload in timeline
  ansel · 2022-12-22 01:23:59 +03:00
  7089bb6c23
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix editor hard crash when beatmap file specified out-of-range timeline zoom value
  Dean Herbert · 2022-11-07 12:54:02 +09:00
  f6d93fcd5a
• Reuse function TimeAtPosition() and PositionAtTime().
  andy840119 · 2022-10-30 17:21:50 +08:00
  a753369d3e
• Use hit object time for timeline selection
  ekrctb · 2022-10-05 21:51:01 +09:00
  0ffde02f79
• Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Ondřej Vajďák · 2022-09-17 19:51:44 +02:00
  9d94343317
• Changed == to <= on TimelineZoom check
  Drison64 · 2022-09-17 19:00:50 +02:00
  c8768eb399
• Update
  Drison64 · 2022-09-17 18:57:09 +02:00
  3c7ea5c8fa
• Remove Track access in Timeline
  Dean Herbert · 2022-08-26 18:25:48 +09:00
  cd90536e4b
• Fix Timeline attempting to setup zoom with unloaded track
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  07c6b44864
• Fix timeline zoom receiving feedback from bindable changes

  This causes the focal point zooming to not work (as the focal point is
  lost). There's no need to handle ongoing changes to
  `BeatmapInfo.TimelineZoom` because it is not a property which is changed
  at runtime.

  Dean Herbert · 2022-07-22 15:25:57 +09:00
  6eb42d08ce
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix context menu no longer open on hitobjects in timeline
  Salman Ahmed · 2022-05-29 15:23:32 +03:00
  9cc5df9b13
• Fix Timeline potentially not updating visuals to correct state on first display
  Dean Herbert · 2022-05-24 18:11:05 +09:00
  1137545d4a
• Add enum to snap method as alternative to mutliple nested invocations
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  c0abce918f
• Fix timeline not handling mouse down events
  Salman Ahmed · 2022-05-11 09:39:27 +03:00
  0b597e712e
• Merge branch 'master' into cache-at-interface
  Dean Herbert · 2022-05-05 18:54:24 +09:00
  e83604a1fc
• Move snap provider caching to interfaces
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  1c6a233cc0
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Change "distance spacing" multipler type to double

  Avoids losing precision on initial load, causing an unnecessary
  hash change in `EditorChangeHandler`.
  
  Resolves test failures in `TestSceneEditorChangeStates`
  (https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).

  Salman Ahmed · 2022-02-16 03:28:12 +03:00
  0992bec2c8
• Expose distance spacing in IPositionSnapProvider for updating distance grid

  Alternate method is to expose a `SnapDistancesChanged` event in
  `IPositionSnapProvider` instead, but I chose this way as an analogue to
  `IBeatSnapProvider.BeatDivisor`, which might even make sense to be
  exposed as `BindableBeatDivisor` instead of caching that separately.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  528dc03b8c
• Reword event handler name and update xmldoc
  Salman Ahmed · 2022-01-25 19:36:19 +03:00
  4169e5592e
• Add support for reading/saving timeline zoom in editor
  Salman Ahmed · 2022-01-25 18:57:39 +03:00
  d1cbdf63f0
• Decrease default timeline zoom to "6 seconds visible" range
  Salman Ahmed · 2022-01-25 10:43:51 +03:00
  5a9524a74e
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Adjust timeline height to account for less global control points
  Dean Herbert · 2021-09-14 18:51:11 +09:00
  9d17f84681
• Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time

  This allows fetching the correct `DifficultyControlPoint` from the
  hitobject. Nothing more.

  Dean Herbert · 2021-09-03 17:11:12 +09:00
  d4e5a612ea
• Move zoom settings back to run in a non-loaded state
  Dean Herbert · 2021-04-16 01:01:03 +09:00
  c2340f1fe8
• Set the timeline's height to a sane non-zero default

  This isn't required but makes the initial appearance animation nicer.

  Dean Herbert · 2021-04-16 00:58:32 +09:00
  15d48a924b
• Simplify content creation of Timeline / TimelineArea
  Dean Herbert · 2021-04-14 21:03:52 +09:00
  d1c68cb92b
• Adjust timeline sizing to closer match designs (but not 1:1 yet)
  Dean Herbert · 2021-04-14 20:54:35 +09:00
  99f05253fd
• Allow timeline to expand in height when control points are to be displayed
  Dean Herbert · 2021-04-14 20:10:50 +09:00
  1209c9fa32
• Allow timeline to govern the size of the rest of the editor content
  Dean Herbert · 2021-04-14 18:17:27 +09:00
  a314f90d37
• Display the centre marker above the waveform

  Gives it a bit more visibility. This is where it was meant to sit, but
  didn't consider using a proxy drawable to make it work previously.

  Dean Herbert · 2021-04-14 14:52:48 +09:00
  b7d2821b55
• Add marker showing where 00:00:000 is
  Dean Herbert · 2021-04-06 14:24:22 +09:00
  8ff13845d1
• Merge branch 'master' into editor-song-end
  Bartłomiej Dach · 2021-03-17 18:18:19 +01:00
  a691291ae8
• Merge branch 'master' into fix-editor-scroll-interruption
  Dan Balasescu · 2021-01-21 17:46:18 +09:00
  04095cd5b9
• Apply comment suggestion

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2021-01-21 17:40:15 +09:00
  9eb74e86ed
• Expose and consume boolean covering whether an ongoing smooth seek is running
  Dean Herbert · 2021-01-15 16:14:38 +09:00
  831c06a3c7
• Fix editor timeline not snapping on non-precise wheel scroll

  For wheel input with precision, we still prefer exact tracking for now.
  May change this in the future based on feedback from mappers, but it
  makes little sense to do non-snapped scrolling when input is coming from
  a non-precise source.

  Dean Herbert · 2021-01-15 15:47:42 +09:00
  ed78be825f
• Make all objects in selection candidates for spatial snapping

  Closes #10898.

  Dean Herbert · 2020-11-24 17:35:54 +09:00
  c9a41f9dae
• Add timeline visible range adjustment
  smoogipoo · 2020-11-13 17:10:29 +09:00
  0219aff7bc
• Merge branch 'master' into fix-editor-play-after-drag
  Dan Balasescu · 2020-11-04 14:45:20 +09:00
  42c543f5b9
• Add handling of opacity to timeline waveform display
  Dean Herbert · 2020-11-03 16:07:01 +09:00
  0dcb4ea441
• Fix editor clock not always remaining stopped when dragging timeline

  Closes https://github.com/ppy/osu/issues/10461.

  Dean Herbert · 2020-11-03 15:00:01 +09:00
  34aa59f237
• Reapply waveform colour fix
  Dean Herbert · 2020-10-19 16:57:08 +09:00
  79a17b2371
• Fix remaining conflicts
  Dean Herbert · 2020-10-05 20:09:18 +09:00
  6bc0afdafb