8087 Commits

• Revert failing test to prior assertions too
  Bartłomiej Dach · 2023-07-26 21:51:32 +02:00
  f66093d3cf
• Merge pull request #24359 from peppy/fix-unknown-mod-test-failure

  Fix `TestSceneUnknownMod` failing due to null reference

  Bartłomiej Dach · 2023-07-25 22:40:03 +02:00
  653f01f4ce
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-25 21:58:13 +02:00
  3b9f250c1b
• Adjust cyclic selection test to hitcircle lifetime adjustments

  As it turns out, the tightening of hitcircle lifetimes in editor caused
  the test to fail, since the objects were too far apart and at the
  starting time of the test, the first object was fully faded out and as
  such not alive, therefore leading cyclic selection to fail to select it.
  
  To fix, bring all three objects closer together time-wise so that this
  does not happen and the test can continue to exercise its original
  behaviour.

  Bartłomiej Dach · 2023-07-25 18:54:13 +02:00
  d75e6f78d6
• Fix TestSceneUnknownMod failing due to null reference
  Dean Herbert · 2023-07-25 19:06:13 +09:00
  c1d93607e0
• Adjust failing test after metrics changes
  Bartłomiej Dach · 2023-07-21 19:08:40 +02:00
  2ef843261b
• Merge branch 'master' into editor-metrics
  Dean Herbert · 2023-07-21 14:26:32 +09:00
  ca3d1538ae
• Merge branch 'master' into menu-star-fountains
  Dean Herbert · 2023-07-21 14:21:16 +09:00
  b29a2081ac
• Merge pull request #24294 from peppy/toggle-all-freemods

  Add ability to toggle all free mods quickly at multiplayer song select

  Bartłomiej Dach · 2023-07-20 22:32:53 +02:00
  c77d3cd6bd
• Add test coverage of double click behaviour
  Bartłomiej Dach · 2023-07-20 20:51:17 +02:00
  48024cd17f
• Fix test step descriptions
  Bartłomiej Dach · 2023-07-20 20:47:33 +02:00
  f60a6e9893
• Merge branch 'master' into editor-cyclic-selection
  Bartłomiej Dach · 2023-07-20 20:19:46 +02:00
  708dd355cd
• Merge branch 'master' into editor-prefer-closest
  Bartłomiej Dach · 2023-07-20 19:16:09 +02:00
  210e114f7d
• Fix incorrect dependency caching

  These are tested framework-side to throw exceptions, but the
  test is ignored for the source generated version because it quietly
  allows this scenario.
  
  The source gen project should eventually have an analyser for these
  unsupported cases, or we could consider relaxing this particular case.

  Dan Balasescu · 2023-07-20 22:30:49 +09:00
  733ce4c382
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-19 21:26:41 +02:00
  f3a95d4c13
• Add ability to toggle all free mods quickly at multiplayer song select
  Dean Herbert · 2023-07-19 19:08:32 +09:00
  eb149942e5
• Apply NRT to TestSceneComposerSelection
  Dean Herbert · 2023-07-19 17:22:25 +09:00
  94c5b8ed32
• Add test coverage of beatmap editor cyclic selection
  Dean Herbert · 2023-07-19 17:21:20 +09:00
  d33b174243
• Update skin editor cyclic test to match expectations better
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  9d46d00294
• Add test coverage of selection preferring closest objects
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  4e4dcc9846
• Merge branch 'master' into editor-metrics
  Dean Herbert · 2023-07-19 15:00:51 +09:00
  7f336b8dac
• Fix regression in time jumping behaviour
  Dean Herbert · 2023-07-19 13:38:04 +09:00
  2e3d1fe950
• Remove unused local variable
  Bartłomiej Dach · 2023-07-16 17:10:26 +02:00
  a42992d3fd
• Add failing test covering exit dialog crash
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  72bf43e297
• Change BeatDivisorControl to retrive bindable divisor via DI
  Dean Herbert · 2023-07-14 14:03:25 +09:00
  56acc9e3dd
• Merge pull request #24199 from peppy/revert-to-default-design-change

  Update design of "revert to default" button

  Bartłomiej Dach · 2023-07-13 23:44:24 +02:00
  cdbb6f90be
• Merge pull request #24197 from peppy/allow-autoplay-failure

  Allow autoplay to fail

  Bartłomiej Dach · 2023-07-13 23:44:07 +02:00
  ff56e35093
• Fix broken test
  Bartłomiej Dach · 2023-07-13 22:28:26 +02:00
  e7dbe3c938
• Merge pull request #24190 from novialriptide/emoji-fix

  Replace emoji unicode with `[emoji]`

  Bartłomiej Dach · 2023-07-13 22:05:12 +02:00
  cef0dd1d61
• Rewrite test scene to show non-themed and themed variants
  Bartłomiej Dach · 2023-07-13 21:54:30 +02:00
  6b9dabbd3c
• Adjust failing test after permitting autoplay and no fail combo
  Bartłomiej Dach · 2023-07-13 21:22:48 +02:00
  ae7ed697ec
• Add some extra text coverage against potential emoji-to-link misparses
  Bartłomiej Dach · 2023-07-13 20:51:52 +02:00
  4859b8c994
• Merge pull request #24202 from peppy/save-preset-on-select

  Allow saving changes to mod presets using enter key

  Bartłomiej Dach · 2023-07-13 19:50:16 +02:00
  9b771ee798
• Crudely fix crashes when switching between TestResultsWithPlayer cases

  In the visual test browser, if two `TestResultsWithPlayer` test cases
  are ran consecutively, the second would die on `SoloStatisticsWatcher`
  seeing duplicated online score IDs. This surfaced after
  6ef39b87fe, which changed
  `TestResultsScreen` to inherit `SoloResultsScreen` rather than
  `ResultsScreen`.
  
  This is probably _not_ a very good fix, but I'm trying to be pragmatic
  for now. `SoloStatisticsWatcher` should probably not live in
  `OsuGameBase`.

  Bartłomiej Dach · 2023-07-13 19:06:02 +02:00
  4b06b6f34e
• Add kiai fountains to main menu
  Dean Herbert · 2023-07-13 22:13:40 +09:00
  1698caa078
• Change IBeatSyncProvider.Clock to always be non-null
  Dean Herbert · 2023-07-13 22:13:40 +09:00
  20e4e2581a
• Reorder tests for testability
  Dean Herbert · 2023-07-13 18:12:46 +09:00
  6ef39b87fe
• Add actual statistics changes to better visualise layout
  Dean Herbert · 2023-07-13 18:12:46 +09:00
  654a7057fc
• Show online stats on TestSceneStatisticsPanel

  Fix test regression

  Dean Herbert · 2023-07-13 18:12:37 +09:00
  aebbffacf2
• Add full statistics score to TestSceneResultsScreen
  Dean Herbert · 2023-07-13 18:12:35 +09:00
  b7ab46d87b
• Change order and test population in TestSceneStatisticsPanel to give better visible results
  Dean Herbert · 2023-07-13 18:12:19 +09:00
  6529c810fa
• Allow saving changes to presets in popover using "select" binding
  Dean Herbert · 2023-07-13 17:53:26 +09:00
  db37de45ac
• Don't hide mod select overlay when pressing select binding with no search
  Dean Herbert · 2023-07-13 17:50:07 +09:00
  f5c472c0fe
• Update design of "revert to default" button

  I keep getting feedback that the old design looked like anything *but* a
  button to revert defaults. Including people clicking it expecting
  opposite behaviour.
  
  This is intended to be a temporary design until we get the full new UI
  components online (where this is moved to the right-hand-side).

  Dean Herbert · 2023-07-13 14:26:03 +09:00
  94201579f6
• Rename RestoreDefaultValueButton to RevertToDefaultButton

  Because I can't find it every time I search.

  Dean Herbert · 2023-07-13 13:46:50 +09:00
  1bfe5a18cb
• Use OsuScoreProcessor in the scoring test scene
  Zyf · 2023-07-11 02:46:32 +02:00
  82364b4f9f
• Add failing test case for chat message length limit enforcement
  Bartłomiej Dach · 2023-07-09 21:40:27 +02:00
  2af8c7bc24
• Merge branch 'master' into taiko-hitsounding-final-attempt
  Bartłomiej Dach · 2023-07-08 18:10:04 +02:00
  055e4a78f0
• Merge branch 'master' into no-dismiss-all-progress-notifications
  Bartłomiej Dach · 2023-07-08 14:19:57 +02:00
  e2aaef6663
• Merge branch 'master' into fix-gameplay-samepl-trigger-source-rewind
  Bartłomiej Dach · 2023-07-08 13:33:04 +02:00
  832c1c0009