Naxess
049a2dec34
Remove unnecessary folder include
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-07-13 07:01:42 +02:00
Naxess
dc4285582b
Fix misplaced "f" in issue message
2021-07-13 06:07:04 +02:00
Naxess
c8f58cbf6c
Add audio in video check and tests
2021-07-13 04:17:41 +02:00
Naxess
a4a1919842
Add too short audio files check and tests
2021-07-13 03:46:45 +02:00
Naxess
0a8fd01b99
Add zero byte check and tests
2021-07-13 03:45:21 +02:00
Bartłomiej Dach
0fb16cb55f
Merge pull request #13746 from ekrctb/move-caught-object-vertical-offset
...
Move caught object stack vertical offset logic
2021-07-04 18:10:34 +02:00
Bartłomiej Dach
ff56a554f3
Merge branch 'master' into move-caught-object-vertical-offset
2021-07-04 17:26:24 +02:00
Bartłomiej Dach
f3cd0be230
Merge pull request #13765 from peppy/fix-initial-volume-display-when-zero
...
Fix volume metre not correctly showing volume when initially zero
2021-07-04 16:55:24 +02:00
Bartłomiej Dach
5e148b273e
Merge branch 'master' into fix-initial-volume-display-when-zero
2021-07-04 16:16:01 +02:00
Bartłomiej Dach
a7de3dd81c
Merge pull request #13766 from peppy/fix-zero-hit-score-submit
...
Don't attempt to submit score when nothing has been hit
2021-07-04 16:10:55 +02:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit
2021-07-04 15:31:38 +02:00
Bartłomiej Dach
d5fa972215
Merge pull request #13762 from peppy/remove-lazer-references
...
Remove some mentions of "lazer"
2021-07-04 15:01:56 +02:00
Bartłomiej Dach
19f02dc3d9
Ensure tests with no token have at least one hit
...
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
2021-07-04 14:34:52 +02:00
Dean Herbert
2a74b1c539
Add test coverage of new scenarios
2021-07-04 17:27:02 +09:00
Dean Herbert
7a710ceffe
Check count as well (statistics can be populated with zero counts)
2021-07-04 16:41:09 +09:00
Dean Herbert
ef82528309
Don't attempt to submit score when nothing has been hit
2021-07-04 15:16:18 +09:00
Dean Herbert
149a200f34
Fix volume metre not correctly showing volume when initially zero
...
Closes https://github.com/ppy/osu/issues/13761 .
2021-07-04 14:56:17 +09:00
Dean Herbert
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
ekrctb
623ba15919
Relax caught object stacking test
...
The stacking code currently uses an unseeded RNG and there is a non-zero chance the stack will be very flat (small Y position difference).
Technically, `RNG.NextSingle(0, 5)` can return `0`, but extremely unlikely that the all RNG calls return 0.
2021-07-04 10:23:49 +09:00
Bartłomiej Dach
05c612f9a1
Merge branch 'master' into move-caught-object-vertical-offset
2021-07-03 18:22:08 +02:00
Bartłomiej Dach
49090a0d1b
Merge pull request #7674 from LeNitrous/linkify-metadata
...
Linkify metadata in beatmap details and overlay
2021-07-03 16:43:53 +02:00
Bartłomiej Dach
fbe3b447e5
Merge branch 'master' into linkify-metadata
2021-07-03 15:51:08 +02:00
Bartłomiej Dach
6fb8ed4d07
Trim no longer used constant
2021-07-03 15:47:47 +02:00
Bartłomiej Dach
7dae93ad66
Remove unused using directives
2021-07-03 15:23:26 +02:00
Bartłomiej Dach
16d08df5e2
Remove mention of direct from xmldoc
2021-07-03 15:22:03 +02:00
Dan Balasescu
ace57a9ee9
Merge pull request #13727 from peppy/update-disclaimer
...
Update disclaimer
2021-07-02 21:08:43 +09:00
Dan Balasescu
5a7706edee
Merge pull request #13726 from nekodex/notch-tick-sfx
...
Add audio feedback for changing volume
2021-07-02 21:08:31 +09:00
Dean Herbert
6e31c781bb
Merge pull request #13382 from ribbanya/clamp-skin-scale
...
Fix skin elements flipping when scaled below zero
2021-07-02 20:50:47 +09:00
ekrctb
170513568b
Move caught object stack vertical offset logic
2021-07-02 20:43:47 +09:00
Dan Balasescu
4d85df6bbc
Merge branch 'master' into notch-tick-sfx
2021-07-02 20:38:30 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
...
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
Dean Herbert
8847915c6a
Update framework
2021-07-02 18:51:14 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
...
Submit scores on player exit
2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block
2021-07-02 18:19:46 +09:00
Dean Herbert
f37e5bdab8
Merge pull request #13742 from aitani9/skin-editor-flipping-reflect
...
Make flipping in the skin editor reflect across the axes of the selection box
2021-07-02 18:19:04 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls
...
Fix some incorrectly invoked `async` calls
2021-07-02 18:10:30 +09:00
Dean Herbert
362816492f
Move to more friendly namespace
2021-07-02 18:09:16 +09:00
Dean Herbert
1bbf578dfe
Merge pull request #13714 from bdach/colour-picker
...
Add osu!-styled colour picker control
2021-07-02 18:05:19 +09:00
Dean Herbert
eacf867073
Move shared types into their own classes
2021-07-02 18:05:00 +09:00
Dean Herbert
ecb4982281
Add missing blank lines
2021-07-02 17:51:54 +09:00
Dean Herbert
d67fc87dcb
Add some basic testability of external colour setting
2021-07-02 17:24:15 +09:00
Dean Herbert
f34c30f788
Merge pull request #13745 from Henry-YSLin/fix-incorrect-obsolete-message
...
Fix the obsolete message in `Mod.Ranked` property
2021-07-02 16:57:43 +09:00
Henry Lin
6a0c5b54c3
Fix obsolete message in Mod.Ranked
2021-07-02 15:55:25 +08:00
Dean Herbert
7b0f970e7d
Fix ongoing operation being begun in an async context
2021-07-02 16:09:02 +09:00
Dean Herbert
35f7966922
Merge conditionals in line with other case of same logic
2021-07-02 15:55:36 +09:00
Dean Herbert
63d2ac66d2
Fix one more instance of incorrect playback/frequency set order
2021-07-02 15:52:20 +09:00
Jamie Taylor
910fe3e9f8
Center pitch randomisation around base pitch
2021-07-02 15:51:23 +09:00
Dean Herbert
bd6664d541
Add note about intentional downward pitch, against expectations
2021-07-02 15:48:16 +09:00
Dean Herbert
13254d51fc
Remove usage of bool for initial playback
...
Also refactors the whole method to generally clean things up. One more
important fix is setting the frequency on the channel before starting
playback, so avoid the frequency potentially being adjusted after the
playback is already started.
2021-07-02 15:48:13 +09:00
Dean Herbert
69b1347730
Tidy up weird bind logic
2021-07-02 15:29:51 +09:00
