10719 Commits

• Fix hidden settings flow content still being interactive

  `AlwaysPresent` is a code smell here. Rather than doing this, let's just
  using masking as we usually do.
  
  Closes https://github.com/ppy/osu/issues/36748.

  Dean Herbert · 2026-02-25 14:35:24 +09:00
  047ea7c09d
• Fix flow animating its display initially when it shouldn't
  Dean Herbert · 2026-02-25 14:34:50 +09:00
  cb597c4120
• Tidy up how SettingsSubsection headings are created

  Previously we were always making header content in the base class then
  overwriting it, which felt ick.

  Dean Herbert · 2026-02-25 14:34:49 +09:00
  99ab245cf0
• Move spacing local to usages
  Dean Herbert · 2026-02-23 15:59:09 +09:00
  f39615a374
• Move toolbar button text local to single usage in ToolbarUserButton
  Dean Herbert · 2026-02-23 15:58:57 +09:00
  4916c87f14
• Move transformation logic local to transient drawable
  Dean Herbert · 2026-02-23 15:47:01 +09:00
  a09489d4c0
• Add ability for LoadingLayer to block all keyboard input
  Dean Herbert · 2026-02-18 20:01:38 +09:00
  83587e2265
• Add "spin" keyword for menu cursor rotation
  Dean Herbert · 2026-02-18 17:21:03 +09:00
  f15e086bb0
• Rename Ruleset.GetHitResults{ -> ForDisplay}()
  Bartłomiej Dach · 2026-02-09 12:00:15 +01:00
  dbce8886f8
• Allow binding left/right modifier keys separately for gameplay bindings (#36585)

  Addresses #36583.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  failaip12 · 2026-02-09 10:15:34 +09:00
  01982030ec
• Fix unreliable async loading due to incorrect single-child assumption

  See https://github.com/ppy/osu/actions/runs/21807684945/job/62913744850.

  Dean Herbert · 2026-02-09 10:05:13 +09:00
  bb83f3dcf2
• Improve handling of account registration errors (#36600)

  ## [Specify `Accept` header in registration
  request](https://github.com/ppy/osu/commit/28edb788f78723cda23281a8801acc2065592840)
  
  The lack of it meant that in specific scenarios web would respond with a
  chunk of HTML instead of JSON.
  
  ## [Allow showing registration error message even if no redirect is
  given](https://github.com/ppy/osu/commit/6ad49941ffd7cdf662ccd404836bb52fccec2142)
  
  There are scenarios where this can happen, and if it did, previously the
  strict requirement to have both would cause the specific message to be
  discarded and replaced with the generic "something happened" one.

  Bartłomiej Dach · 2026-02-09 00:51:31 +09:00
  7263551aa8
• Localise some more strings in settings (#36590)
  Denis Titovets · 2026-02-06 19:23:02 +09:00
  a616fa61c9
• Localize "Effect, Master, Music" in VolumeOverlay (#36594)
  Ботников Максим · 2026-02-06 19:22:06 +09:00
  e77e08c049
• Localise "running" in DigitalClockDisplay (#36589)
  Ботников Максим · 2026-02-05 23:22:25 +09:00
  5d4bb1bd37
• Implement sorting and display styles for currently online users (#33649)

  - Adds sorting and display styles.
  - Saves sort/display modes to the config.
  - Improves performance, especially on the 2nd+ time opening the overlay.
  
  
  https://github.com/user-attachments/assets/e32b50d0-58a1-4eef-b18c-988fb497e545
  
  ---
  
  Coming off some recent feedback in
  https://github.com/ppy/osu/discussions/33426#discussioncomment-13431275,
  I decided to take a bit of a detour and get a little bit more
  functionality in.
  
  Sorting by rank, although it should technically work, doesn't work right
  now. This is because the osu!web API doesn't return user rank on
  `/user/` lookups - it's only returned for the friends request. I'm
  leaving this open as a discussion topic.
  - We can make osu!web return the rank and osu! will require no further
  changes to work correctly, or
  - We can try to implement additional paths through
  `osu-server-spectator` which would blow this PR out of proportion and is
  best left for a task of its own.
  
  For simplicity, I've re-implemented this display mostly as its own
  component for now, lifting code from `FriendDisplay` which was recently
  overhauled. These implementations should eventually be combined somehow
  but that's dependent on:
  1. Figuring out the styling - friends can display offline users for
  which it makes no sense to display the "spectate" button.
  2. Figuring out how to handle the different users/presence pathways.
  It's mostly a code complexity issue.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2026-02-05 01:22:36 +09:00
  1230da33a5
• Fix revert to default button not resizing correctly after changing languages

  Closes #36519.

  Dean Herbert · 2026-02-03 18:17:53 +09:00
  b8b6327624
• Fix two mod presets having key binding of 1 (#36563)

  Fixes #36562 
  
  Currently there exists a bug where the mod preset hotkeys will wrap
  outside of the intended bounds.
  
  Fix is making sure the preset index is < 10
  
  Before:
  <img width="486" height="358" alt="image"
  src="https://github.com/user-attachments/assets/77f1ca9e-4fd0-4b29-b9f5-f53e652db42d"
  />
  
  After:
  <img width="1007" height="1295" alt="image"
  src="https://github.com/user-attachments/assets/ca81cc39-2f86-462c-a26b-002aceed77f4"
  />

  nil · 2026-02-02 00:42:49 +09:00
  85b8480e46
• Merge pull request #36387 from ArijanJ/cycle-skins

  Add skin cycling with shortcuts for next and previous skin

  Bartłomiej Dach · 2026-01-30 08:57:23 +01:00
  c9a50b40d0
• Fix some text boxes no longer having borders (#36526)

  Regressed in d6bf4fd90d.
  
  One very visible instance of this regression is the login form.
  
  
  https://github.com/user-attachments/assets/5ba10ac5-4cb1-49af-b55c-89cf58ca0b44
  
  The `CommentEditor` usage was discovered with one of my favourite tricks
  which is doing
  
  ```diff
  diff --git a/osu.Game/Graphics/UserInterface/OsuTextBox.cs b/osu.Game/Graphics/UserInterface/OsuTextBox.cs
  index fefe776b01..c17cca726b 100644
  --- a/osu.Game/Graphics/UserInterface/OsuTextBox.cs
  +++ b/osu.Game/Graphics/UserInterface/OsuTextBox.cs
  @@ -42,6 +42,12 @@ public partial class OsuTextBox : BasicTextBox
               Margin = new MarginPadding { Left = 2 },
           };
   
  +        public new bool Masking
  +        {
  +            get => base.Masking;
  +            set => base.Masking = value;
  +        }
  +
           protected bool DrawBorder { get; init; } = true;
   
           private OsuCaret? caret;
  
  ```
  
  and then looking for usages of the setter. That's all due diligence
  you're getting here, I'm not auditing every single text box in the game.
  
  And yes, the `CommentEditor` usage is OMEGA dodgy but the change applied
  here is the only one that preserves its visual appearance. I'm not
  putting in time to fix it.

  Bartłomiej Dach · 2026-01-29 19:11:10 +09:00
  7d476b4b7c
• Rewrite everything for code quality's sake
  Dean Herbert · 2026-01-29 02:40:24 +09:00
  3b3bb266fc
• Merge branch 'master' into cycle-skins
  Dean Herbert · 2026-01-29 02:19:36 +09:00
  487347dac6
• Add insult to injury for autosize workaround

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-01-27 19:58:45 +09:00
  6fad798227
• Add localisation support for "Device:" prefix
  Dean Herbert · 2026-01-27 19:03:23 +09:00
  60690cbccc
• Add back FinishTransforms at what cost
  Dean Herbert · 2026-01-27 19:02:28 +09:00
  6329e3ee1b
• Remove unnecessary depth change
  Dean Herbert · 2026-01-27 18:51:04 +09:00
  12eeab581e
• Fix revert button not always matching control's size
  Dean Herbert · 2026-01-27 18:36:49 +09:00
  786ea35274
• Adjust paddings to give more width to settings
  Dean Herbert · 2026-01-27 17:43:28 +09:00
  c407e07514
• Adjust size and icon of revert-to-default button
  Dean Herbert · 2026-01-27 17:06:15 +09:00
  ed0051d119
• Make binding configuration button bigger

  It's one of the more important sections so I want to make it easier to
  find.

  Dean Herbert · 2026-01-27 17:06:14 +09:00
  99ea19d55c
• Add prefix for input device header
  Dean Herbert · 2026-01-27 17:06:13 +09:00
  fdf28474bf
• Various metrics and visual tweaks
  Dean Herbert · 2026-01-27 17:06:13 +09:00
  6983227240
• Fix button spacing being weirdly small
  Dean Herbert · 2026-01-27 17:06:12 +09:00
  585ce682ef
• Fix revert button height
  Dean Herbert · 2026-01-27 17:06:12 +09:00
  3db3b603bc
• Fix logs failing to export after multiple failure attempts on file locks (#36469)

  Even if one file fails, we usually don't care and still want the archive
  to finish exporting.
  
  Closes https://github.com/ppy/osu/issues/36446
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-01-26 10:10:04 +01:00
  acdb4477f7
• Merge pull request #36471 from peppy/fix-previous-username-depth

  Fix previous usernames display showing underneath other elements

  Dean Herbert · 2026-01-26 10:09:39 +01:00
  4ff29339ed
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Merge pull request #36392 from iwa/feat/numeric-hotkeys-for-presets-mod-select

  Mod Select: Support numeric row hotkeys to quick select Presets

  Dean Herbert · 2026-01-23 03:28:52 +09:00
  6f038bff48
• Add visual hinting of keyboard shortcuts
  Dean Herbert · 2026-01-22 20:24:10 +09:00
  04e378c09f
• Merge branch 'master' into new-settings/overlay
  Dean Herbert · 2026-01-22 18:38:17 +09:00
  42302c45ec
• Standardise ruleset error logging to always include exception in logs

  Supersedes and closes https://github.com/ppy/osu/pull/36420.

  Dean Herbert · 2026-01-22 15:48:51 +09:00
  fdd13cd7e1
• refactor: move presets hotkey logic inside ModPresetColumn class
  iwa · 2026-01-20 22:22:10 +01:00
  ce2d54f118
• revert: changes made for preset hotkeys in SequentialModHotkeyHandler
  iwa · 2026-01-20 22:21:21 +01:00
  042f716b2a
• revert: remove IPresetHotkeyHandler
  iwa · 2026-01-20 22:20:54 +01:00
  0ea060c612
• Simplify cycleSkins, fix some logic and naming mistakes
  ArijanJ · 2026-01-20 21:47:34 +01:00
  ea8788a509
• fix: align OnKeyDown condition with existing from ModColumn
  iwa · 2026-01-19 22:07:32 +01:00
  2a0bafde8c
• feat: add logic to handle numeric hotkeys to select presets from mod select overlay
  iwa · 2026-01-19 17:15:15 +01:00
  91ee5eebc9
• feat: expose a public Toggle method for ModPresetPanel
  iwa · 2026-01-19 17:14:34 +01:00
  6bf95068ae
• refactor: rename HandleHotkeyPressed to HandleModHostkeyPressed to differentiate with presets handler
  iwa · 2026-01-19 17:14:02 +01:00
  6d999a8d8e
• Add skin cycling with shortcuts for next and previous skin
  ArijanJ · 2026-01-19 12:59:21 +01:00
  65f7037e84