1
0
mirror of https://github.com/ppy/osu.git synced 2026-06-07 05:43:41 +08:00

Fix logs failing to export after multiple failure attempts on file locks (#36469)

Even if one file fails, we usually don't care and still want the archive
to finish exporting.

Closes https://github.com/ppy/osu/issues/36446

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
This commit is contained in:
Dean Herbert
2026-01-26 18:10:04 +09:00
committed by GitHub
Unverified
parent 4ff29339ed
commit acdb4477f7
@@ -102,7 +102,7 @@ namespace osu.Game.Overlays.Settings.Sections.General
using (var zip = ZipArchive.Create())
{
foreach (string? f in logStorage.GetFiles(string.Empty, "*.log"))
FileUtils.AttemptOperation(z => z.AddEntry(f, logStorage.GetStream(f), true), zip);
FileUtils.AttemptOperation(z => z.AddEntry(f, logStorage.GetStream(f), closeStream: true), zip, throwOnFailure: false);
zip.SaveTo(outStream);
}